Changesets: fs2open

trunk r7626

2011-09-03 01:38

Echelon9


Ported: N/A

Details Diff
PVS-Studio fix: V581 The conditional expressions of the 'if' operators situated alongside each other are identical. Check lines: 1281, 1312.
mod - /trunk/fs2_open/code/menuui/optionsmenu.cpp Diff File

trunk r7625

2011-09-03 01:34

Echelon9


Ported: N/A

Details Diff
Suppress a PVS-Studio false positive
mod - /trunk/fs2_open/code/gamesnd/eventmusic.cpp Diff File

trunk r7624

2011-09-03 01:31

Echelon9


Ported: N/A

Details Diff
PVS-Studio fix: V592 The expression was enclosed by parentheses twice: ((expression)). One pair of parentheses is unnecessary or misprint is present (starfield.cpp).
mod - /trunk/fs2_open/code/starfield/starfield.cpp Diff File

trunk r7623

2011-09-03 01:20

Echelon9


Ported: N/A

Details Diff
PVS-Studio fix: V592 The expression was enclosed by parentheses twice: '((cur_sep > 0.9f * desired_sep))'. One pair of parentheses is unnecessary or misprint is present (aicode.cpp).

I think this is the right fix. In addition the code comments did not reflect what was happening, so I've updated these to reflect the if() comparison.
mod - /trunk/fs2_open/code/ai/aicode.cpp Diff File

trunk r7622

2011-09-03 00:30

Goober5000


Ported: N/A

Details Diff
whoops
mod - /trunk/fs2_open/code/parse/sexp.cpp Diff File

trunk r7621

2011-09-02 22:34

Goober5000


Ported: N/A

Details Diff
The_E made the wrong fix; this is the right one
mod - /trunk/fs2_open/code/fred2/missionsave.cpp Diff File

trunk r7620

2011-09-02 22:25

Goober5000


Ported: N/A

Details Diff
a bunch of small PVS-Studio fixes (mostly duplicate assignments)
mod - /trunk/fs2_open/code/ai/aicode.cpp Diff File
mod - /trunk/fs2_open/code/globalincs/pstypes.h Diff File
mod - /trunk/fs2_open/code/graphics/gropengl.cpp Diff File
mod - /trunk/fs2_open/code/hud/hudtarget.cpp Diff File
mod - /trunk/fs2_open/code/model/modelinterp.cpp Diff File
mod - /trunk/fs2_open/code/parse/sexp.cpp Diff File
mod - /trunk/fs2_open/code/weapon/beam.cpp Diff File

trunk r7619

2011-09-02 22:21

Goober5000


Ported: N/A

Details Diff
wl_fury_missile_offset_hack was only applicable for FS1
mod - /trunk/fs2_open/code/missionui/missionweaponchoice.cpp Diff File

trunk r7618

2011-09-02 21:48

Goober5000


Ported: N/A

Details Diff
PVS-Studio fix: V507 Pointer to local array 'name' is stored outside the scope of this array. Such a pointer will become invalid. code missioncampaign.cpp

(This is a Volition bug! In all other locations, Campaign_file_names and Campaign_names are set using strdup.)
mod - /trunk/fs2_open/code/mission/missioncampaign.cpp Diff File

trunk r7617

2011-09-02 21:45

Goober5000


Ported: N/A

Details Diff
PVS-Studio fix: V506 Pointer to local variable 'terminus' is stored outside the scope of this variable. Such a pointer will become invalid.
mod - /trunk/fs2_open/code/asteroid/asteroid.cpp Diff File

trunk r7616

2011-09-02 21:32

Goober5000


Ported: N/A

Details Diff
PVS-Studio fix: V804 Decreased performance. The 'strlen' function is called twice in the specified expression to calculate length of the same string.
mod - /trunk/fs2_open/code/cmdline/cmdline.cpp Diff File
mod - /trunk/fs2_open/code/mission/missioncampaign.cpp Diff File
mod - /trunk/fs2_open/code/network/multi_pxo.cpp Diff File
mod - /trunk/fs2_open/code/weapon/weapons.cpp Diff File

trunk r7615

2011-09-02 21:15

Goober5000


Ported: N/A

Details Diff
PVS-Studio fix: V804 Decreased performance. The 'strlen' function is called twice in the specified expression to calculate length of the same string.
mod - /trunk/fs2_open/code/cfile/cfilesystem.cpp Diff File

trunk r7614

2011-09-02 21:05

Goober5000


Ported: N/A

Details Diff
PVS-Studio fix: V805 Decreased performance. It is inefficient to identify an empty string by using 'strlen(str) != 0' construct. A more efficient way is to check: str[0] != '\0'.
(and sorry Kazan, you don't get to call your for statement a work of art if you use strlen inefficiently)
mod - /trunk/fs2_open/code/cfile/cfilesystem.cpp Diff File
mod - /trunk/fs2_open/code/mission/missionparse.cpp Diff File

trunk r7613

2011-09-01 15:35

Valathil


Ported: N/A

Details Diff
Changed Sun glow and lens flare rendering to not be obscured by objects
mod - /trunk/fs2_open/code/freespace2/freespace.cpp Diff File
mod - /trunk/fs2_open/code/starfield/starfield.cpp Diff File

trunk r7612

2011-09-01 12:16

Valathil


Ported: N/A

Details Diff
Enable alpha channel on render to texture targets and provide scripting functions with alpha capabilities
mod - /trunk/fs2_open/code/graphics/gropengl.cpp Diff File
mod - /trunk/fs2_open/code/graphics/gropengltexture.cpp Diff File
mod - /trunk/fs2_open/code/parse/lua.cpp Diff File

trunk r7611

2011-09-01 09:50

Echelon9


Ported: N/A

Details Diff
Documentation: Code cleanup of missionbriefcommon.cpp
mod - /trunk/fs2_open/code/mission/missionbriefcommon.cpp Diff File

trunk r7610

2011-09-01 09:08

Echelon9


Ported: N/A

Details Diff
Let's have another go at this one... around we go again
mod - /trunk/fs2_open/code/network/psnet2.cpp Diff File

antipodes r7609

2011-08-31 15:44

The_E


Ported: N/A

Details Diff
Ooops, messed up the merge here
mod - /branches/antipodes/code/network/psnet2.cpp Diff File

antipodes r7608

2011-08-31 15:36

The_E


Ported: N/A

Details Diff
Trunk sync r7607
mod - /branches/antipodes/code/autopilot/autopilot.cpp Diff File
mod - /branches/antipodes/code/hud/hudlock.cpp Diff File
mod - /branches/antipodes/code/hud/hudtarget.cpp Diff File
mod - /branches/antipodes/code/menuui/barracks.cpp Diff File
mod - /branches/antipodes/code/mission/missionbriefcommon.cpp Diff File
mod - /branches/antipodes/code/mission/missionhotkey.cpp Diff File
mod - /branches/antipodes/code/network/multi_sexp.cpp Diff File
mod - /branches/antipodes/code/network/psnet2.cpp Diff File
mod - /branches/antipodes/code/render/3dmath.cpp Diff File
mod - /branches/antipodes/code/ship/ship.cpp Diff File
mod - /branches/antipodes/code/sound/dscap.cpp Diff File

trunk r7607

2011-08-31 10:06

karajorma


Ported: N/A

Details Diff
Fix a mismatch.
mod - /trunk/fs2_open/code/network/multi_sexp.cpp Diff File

trunk r7606

2011-08-31 09:53

Echelon9


Ported: N/A

Details Diff
cppcheck fix: Memory leak in icon table parsing.
mod - /trunk/fs2_open/code/mission/missionbriefcommon.cpp Diff File

trunk r7605

2011-08-31 09:48

Echelon9


Ported: N/A

Details Diff
Undo my rather silly patch, apply niffiwan's patch as a temporary measure (at least).
mod - /trunk/fs2_open/code/network/psnet2.cpp Diff File

trunk r7604

2011-08-31 09:25

Echelon9


Ported: N/A

Details Diff
PVS-Studio fix: V522 Dereferencing of the null pointer 'snd' might take place. Check the logical condition (autopilot.cpp)
mod - /trunk/fs2_open/code/autopilot/autopilot.cpp Diff File

trunk r7603

2011-08-31 09:12

Echelon9


Ported: N/A

Details Diff
PVS-Studio fix: V523 The 'then' statement is equivalent to the 'else' statement (psnet2.cpp).

This one was particular bad as it code have lead to remotely induced crashes over the network with oversize packets.
mod - /trunk/fs2_open/code/network/psnet2.cpp Diff File

trunk r7602

2011-08-31 09:02

Echelon9


Ported: N/A

Details Diff
PVS-Studio false positive: V581 The conditional expressions of the 'if' operators situated alongside each other are identical.(hudtarget.cpp)
mod - /trunk/fs2_open/code/hud/hudtarget.cpp Diff File
 First  Prev  1 2 3 ... 40 ... 80 ... 120 ... 132 133 134 135 136 137 138 ... 160 ... 200 ... 240 ... 280 ... 320 ... 360 ... 400 ... 437 438 439  Next  Last