2020-01-21 23:58 EST


View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0002093FSSCPgraphicspublic2010-01-16 02:57
ReporterZacam 
Assigned ToHery 
PriorityhighSeveritycrashReproducibilityalways
StatusclosedResolutionfixed 
Product Version3.6.11 
Target Version3.6.12 RC1Fixed in Version 
Summary0002093: Exe ungracefully fails if -post_process is on, but shaders are not present
DescriptionAssert: image
File: gropenglpostprocessing.cpp
Line: 46

ntdll.dll! ZwWaitForSingleObject + 21 bytes
kernel32.dll! WaitForSingleObjectEx + 67 bytes
kernel32.dll! WaitForSingleObject + 18 bytes
fs2_open_3_6_11d_INF_SSE2.exe! SCP_DumpStack + 354 bytes
fs2_open_3_6_11d_INF_SSE2.exe! WinAssert + 208 bytes
fs2_open_3_6_11d_INF_SSE2.exe! opengl::bloom::blur + 65 bytes
fs2_open_3_6_11d_INF_SSE2.exe! opengl::bloom::begin + 117 bytes
fs2_open_3_6_11d_INF_SSE2.exe! opengl::post_processing::after + 354 bytes
fs2_open_3_6_11d_INF_SSE2.exe! gr_opengl_post_process_after + 59 bytes
fs2_open_3_6_11d_INF_SSE2.exe! game_render_frame + 924 bytes
fs2_open_3_6_11d_INF_SSE2.exe! game_frame + 722 bytes
fs2_open_3_6_11d_INF_SSE2.exe! game_do_frame + 239 bytes
fs2_open_3_6_11d_INF_SSE2.exe! game_do_state + 379 bytes
fs2_open_3_6_11d_INF_SSE2.exe! gameseq_process_events + 237 bytes
fs2_open_3_6_11d_INF_SSE2.exe! game_main + 782 bytes
fs2_open_3_6_11d_INF_SSE2.exe! WinMain + 330 bytes
fs2_open_3_6_11d_INF_SSE2.exe! __tmainCRTStartup + 358 bytes
fs2_open_3_6_11d_INF_SSE2.exe! WinMainCRTStartup + 15 bytes
kernel32.dll! BaseThreadInitThunk + 18 bytes
ntdll.dll! RtlInitializeExceptionChain + 99 bytes
ntdll.dll! RtlInitializeExceptionChain + 54 bytes
Steps To ReproduceRelocated post-processing shaders out of the load path.
Launched PostProcessing Demo mission, or any mission with a set-post-process event.
Crashes after parsing mission just prior to loading in player.
Additional InformationStandard currently is with the GLSL shaders, if not disabled and unable to find the shader files, it just reverts to disabling GLSL.

EX:
Initializing Shaders Manager...
Loading and compiling main shaders...
  Compiling main shader -> null-v.sdr (null-v.sdr) / null-f.sdr (null-f.sdr) ...
Could not open text file 'null-v.sdr'.
Could not open text file 'null-f.sdr'.
Vertex shader failed to compile:
ERROR! Unable to create vertex shader!
  Shader in_error! Disabling GLSL!
Shaders Manager initialized.

I think the -post_process flag should check that there are actual post processing files available and if not, provide a pop-up dialogue saying so, giving the user the option to continue with -post_process disabled, or to exit the exe and put them in place.
TagsNo tags attached.
Attached Files

-Relationships
duplicate of 0002092resolvedtaylor FSO will crash if no post-processing shaders are found when -post_process is enabled. 
+Relationships

-Notes

~0011525

Zacam (administrator)

Last edited: 2010-01-15 16:46

Additionally, from fs2_open.log:
  Compiling special shader -> post-v.sdr / brightpass-f.sdr ...
Could not open text file 'post-v.sdr'.
Could not open text file 'brightpass-f.sdr'.
Vertex shader failed to compile:
(0) : error C0000: syntax error, unexpected $end at token "<EOF>"
(0) : error C0501: type name expected at token "<null atom>"

ERROR! Unable to create vertex shader!
ASSERTION: "image" at gropenglpostprocessing.cpp:46
Int3(): From d:\scp\builds\trunk\code\globalincs\windebug.cpp at line 902

EDIT: Apparently, having post processing options in the mission is not a requirement at all, given that bloom is always "on".

~0011528

Zacam (administrator)

Duplicate of 2092
+Notes

-Issue History
Date Modified Username Field Change
2010-01-15 14:20 Zacam New Issue
2010-01-15 14:20 Zacam Status new => assigned
2010-01-15 14:20 Zacam Assigned To => Hery
2010-01-15 14:22 Zacam Note Added: 0011525
2010-01-15 14:28 Zacam Relationship added duplicate of 0002092
2010-01-15 16:46 Zacam Note Edited: 0011525
2010-01-16 02:57 Zacam Note Added: 0011528
2010-01-16 02:57 Zacam Status assigned => closed
2010-01-16 02:57 Zacam Resolution open => fixed
+Issue History