View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003192 | FSSCP | localization | public | 2017-03-05 08:51 | 2019-10-12 16:59 |
| Reporter | Novachen | Assigned To | m_m | ||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | resolved | Resolution | open | ||
| Product Version | 3.7.4 | ||||
| Summary | 0003192: Freespace look always for the translated strings in the missions, not for the initial default one. | ||||
| Description | If you translate ranks, medals, weapons and/or shipclass names with the help of XSTR-entries in other languages, you have to use the translated names in the missionfile itself to get them to work, because Freespace2 report errors otherwise, that it can not find a specific weapon/ship/medal/rank during the loading of a mission. | ||||
| Steps To Reproduce | Add a XSTR to any medalname in the medals.tbl to transfer it to a tstrings.tbl, where you set unique names for this medal for any other language. Now create a mission with a grant-medal SEXP and load this mission in different languages. | ||||
| Additional Information | In the attachment i include a screenshot of fred2, where you can see the available medals. And the error message that it spawns in the game, if i use a language where this medal have another name. In this case the name is "Dekoriertes Fliegerkreuz" that have to set in the grant-medal SEXP. | ||||
| Tags | No tags attached. | ||||
| related to | 0002919 | resolved | Goober5000 | Tech-add-intel can't handle localization for intel entries |
|
|
|
|
|
Could you create a test mod which reproduces this error based on your reproduction steps? It would make reproducing and fixing this issue much easier. |
|
|
Yes of course. Here is a mod you can extract in the freespace folder. select "MedalTest" in Mods and select the campaign with one mission that gets you "Wings" after you jump out. The german font01.vf for language change is included and activated by default. |
|
|
|
|
|
There was a faulty medaltest-tlc.tbm. Missed the #end :/ Sorry about that. |
|
|
|
|
|
Ok, I can reproduce this issue although it causes an error at mission load instead of failing to grant the medal for me. However, this issue can not be fixed very easily since SEXPs can't use the translated names of anything since they are simply not designed for that. I opened a discussion thread on our GitHub repository so hopefully someone else has an idea how this could be handled: https://github.com/scp-fs2open/fs2open.github.com/issues/1285 |
|
|
This sounds like the same problem I encountered in Mantis 0002919. The tech-add-intel sexp didn't work with translated intel entry names, so the solution was to add tech-add-intel-xstr. The same will have to be done for grant-medal, and indeed any sexp where the lookup key is a translated token. |
|
|
I have submitted a GitHub PR for medal names: https://github.com/scp-fs2open/fs2open.github.com/pull/2105 This should be the last item that needs translating, since m_m took care of display names for weapons and ships. |
|
|
It turns out that GitHub PR 0001736 resolved this for all translation issues: https://github.com/scp-fs2open/fs2open.github.com/pull/1736 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2017-03-05 08:51 | Novachen | New Issue | |
| 2017-03-05 08:51 | Novachen | File Added: Name Error.7z | |
| 2017-03-05 11:50 | m_m | Note Added: 0016875 | |
| 2017-03-05 12:57 | Novachen | File Added: MedalTest.7z | |
| 2017-03-05 12:57 | Novachen | Note Added: 0016877 | |
| 2017-03-05 13:18 | Novachen | File Added: MedalTest-2.7z | |
| 2017-03-05 13:19 | Novachen | Note Added: 0016880 | |
| 2017-03-05 13:23 | Novachen | File Added: MedalTest-3.7z | |
| 2017-03-05 13:40 | m_m | Status | new => confirmed |
| 2017-03-05 13:40 | m_m | Note Added: 0016881 | |
| 2017-06-25 00:12 | Goober5000 | Relationship added | related to 0002919 |
| 2017-06-25 00:13 | Goober5000 | Note Added: 0016901 | |
| 2019-10-12 03:21 | Goober5000 | Assigned To | => Goober5000 |
| 2019-10-12 03:21 | Goober5000 | Status | confirmed => assigned |
| 2019-10-12 03:22 | Goober5000 | Note Added: 0016928 | |
| 2019-10-12 16:59 | Goober5000 | Note Added: 0016929 | |
| 2019-10-12 16:59 | Goober5000 | Assigned To | Goober5000 => m_m |
| 2019-10-12 16:59 | Goober5000 | Status | assigned => resolved |
