View Issue Details

IDProjectCategoryView StatusLast Update
0002919FSSCPtablespublic2017-06-25 00:12
ReporterGoober5000 Assigned ToGoober5000  
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Product Version3.7.1 
Target Version3.7.1 
Summary0002919: Tech-add-intel can't handle localization for intel entries
DescriptionAs reported by Yarn...

---
The name fields in species.tbl currently have XSTR structures. This is a problem waiting to happen because if a future translation modifies the "Shivans" string at all, then if the game loads the mission that unlocks that intel, it will crash with an "intel not found" error (I don't remember exactly what the message is). This happens because the mission expects an intel entry called "Shivans," but if that string is changed by the XSTR functions (e.g., to "Die Shivaner" as in the German version of FS2), then there would no longer be a "Shivans" intel entry, and the game would crash.
---
TagsNo tags attached.

Relationships

related to 0002920 resolvedniffiwan Pilot file code can't handle localization for intel entries 
related to 0003192 resolvedm_m Freespace look always for the translated strings in the missions, not for the initial default one. 

Activities

Goober5000

2013-09-19 05:02

administrator   ~0015276

Fix committed to trunk@9797.

Related Changesets

fs2open: trunk r9797

2013-09-19 01:19

Goober5000


Ported: N/A

Details Diff
add tech-add-intel-xstr, and modify intel_info_lookup to properly translate intel entries (fixes Mantis 0002919) Affected Issues
0002919
mod - /trunk/fs2_open/code/fred2/sexp_tree.cpp Diff File
mod - /trunk/fs2_open/code/menuui/techmenu.cpp Diff File
mod - /trunk/fs2_open/code/menuui/techmenu.h Diff File
mod - /trunk/fs2_open/code/parse/sexp.cpp Diff File
mod - /trunk/fs2_open/code/parse/sexp.h Diff File
mod - /trunk/fs2_open/code/pilotfile/csg.cpp Diff File

fs2open: trunk r9798

2013-09-19 02:37

Goober5000


Ported: N/A

Details Diff
fix tech-add-intel-xstr to actually localize from tstrings.tbl (Mantis 0002919) Affected Issues
0002919
mod - /trunk/fs2_open/code/menuui/techmenu.cpp Diff File
mod - /trunk/fs2_open/code/menuui/techmenu.h Diff File
mod - /trunk/fs2_open/code/parse/sexp.cpp Diff File
mod - /trunk/fs2_open/code/pilotfile/csg.cpp Diff File

Issue History

Date Modified Username Field Change
2013-09-19 05:01 Goober5000 New Issue
2013-09-19 05:01 Goober5000 Status new => assigned
2013-09-19 05:01 Goober5000 Assigned To => Goober5000
2013-09-19 05:02 Goober5000 Changeset attached => fs2open trunk r9797
2013-09-19 05:02 Goober5000 Note Added: 0015276
2013-09-19 05:02 Goober5000 Status assigned => resolved
2013-09-19 05:02 Goober5000 Resolution open => fixed
2013-09-19 06:20 Goober5000 Changeset attached => fs2open trunk r9798
2013-09-19 06:41 Goober5000 Relationship added related to 0002920
2017-06-25 00:12 Goober5000 Relationship added related to 0003192