View Issue Details

IDProjectCategoryView StatusLast Update
0000043FSSCPgameplaypublic2012-01-09 18:06
Reporterkasperl Assigned Totaylor  
PrioritynormalSeveritycrashReproducibilitysometimes
Status resolvedResolutionfixed 
Fixed in Version3.6.9 
Summary0000043: 7< glowpoints crashes FRED and FS3,4
Descriptioni've found in testing, that in fs_open 3.4 there seems to be a limit on the #
of thruster glows on a player flyable ship-capped at 7, while in the normal exe
there doesn't seem to be such a limit, or it is over 8, because the same model
worked in fred and game, but killed fred_open and FS_open with the very un-
informing illegal operation error when i tried to place the offending model. i
went through each chunk and found it is definitly the # of glows in the fuel
chunk. 7 works, 8 doesn't.
to reproduce:
1) add two glow points to the herc2. (complete with radius, position & normal)
2)open fred 3.4 and try to place a herc2 anywhere. it dies. it will work in the
originals though
thanks for listening :)

------- Additional Comment 0000001 From VA 2003-07-14 09:28 -------
Ok, i've just noticed that this limit seems to apply to the number of glow-
points per bank as well. If you exceed 7 glow-points in any one glowbank, it
crashes upon placing the offending ship in fred. Could this limit be bumped
possibly?
It *seems* an easy enough fix. :)
Additional InformationReporter: Vasudan_Ad@hotmail.com (VA)
Assigned To: fs2source@warpcore.org (Edward Gardner)
http://fs2source.warpcore.org/bugzilla/show_bug.cgi?id=58
TagsNo tags attached.

Activities

Goober5000

2004-03-16 03:33

administrator   ~0000470

Assigning to Bobboau.

Bobboau

2004-03-17 04:33

developer   ~0000490

the number of glow points you can have is currently set to 30, it has been for a while now, this bug is so out of date I don't think it can be relied upon

though this has brought my attention back to gloe points again, I realy should probly organise them better, they use a bunch of uggly paralel arrays, I did the origonal code for this before I realy knew what I was doing

Goober5000

2004-03-17 05:20

administrator   ~0000495

Wondering about memory usage: is 30 an ideal number? How much memory does each glowpoint use? Might it be a good idea to lower the number?

Bobboau

2004-03-18 09:06

developer   ~0000506

Last edited: 2004-03-18 09:25

well it's two vectors and a float * 30

what number would you think is better, I beleve this is exactly twice the retail number (this is used in glow points and thruster glows)

I think I'm going to restructure this now

edited on: 03-18-04 04:25

Bobboau

2004-03-22 00:16

developer   ~0000532

seeing as this seems to be based on an old biuld and should be resolved, I'm closeing this

taylor

2006-11-01 17:33

administrator   ~0007057

I just went ahead and made all of this stuff dynamic, since the glow point banks are dynamic now too. My changes should make both glow points and thruster points dyanmic.

Fixered.

Related Changesets

fs2open: fs2_open_3_6_9 r3678

2006-11-01 13:35

taylor


Ported: N/A

Details Diff
make glow_point array for thrusters and glow_point_banks dynamic (a proper fix for old Mantis bug 0000043)
Affected Issues
0000043
mod - /branches/fs2_open_3_6_9/fs2_open/code/model/model.h Diff File
mod - /branches/fs2_open_3_6_9/fs2_open/code/model/modelinterp.cpp Diff File
mod - /branches/fs2_open_3_6_9/fs2_open/code/model/modelread.cpp Diff File
mod - /branches/fs2_open_3_6_9/fs2_open/code/ship/ship.cpp Diff File
mod - /branches/fs2_open_3_6_9/fs2_open/code/ship/shipfx.cpp Diff File

fs2open: trunk r3717

2006-11-06 01:42

taylor


Ported: N/A

Details Diff
make glow_point array for thrusters and glow_point_banks dynamic (a proper fix for old Mantis bug 0000043)
Affected Issues
0000043
mod - /trunk/fs2_open/code/model/model.h Diff File
mod - /trunk/fs2_open/code/model/modelinterp.cpp Diff File
mod - /trunk/fs2_open/code/model/modelread.cpp Diff File
mod - /trunk/fs2_open/code/ship/ship.cpp Diff File
mod - /trunk/fs2_open/code/ship/shipfx.cpp Diff File

Issue History

Date Modified Username Field Change
2004-01-16 10:15 kasperl New Issue
2004-03-16 03:33 Goober5000 Note Added: 0000470
2004-03-16 03:33 Goober5000 Assigned To => Bobboau
2004-03-16 03:33 Goober5000 Status new => assigned
2004-03-17 04:33 Bobboau Note Added: 0000490
2004-03-17 05:20 Goober5000 Note Added: 0000495
2004-03-18 09:06 Bobboau Note Added: 0000506
2004-03-18 09:25 Bobboau Note Edited: 0000506
2004-03-22 00:16 Bobboau Status assigned => closed
2004-03-22 00:16 Bobboau Note Added: 0000532
2006-11-01 17:33 taylor Note Added: 0007057
2006-11-01 17:33 taylor Assigned To Bobboau => taylor
2006-11-01 17:33 taylor Status closed => resolved
2006-11-01 17:33 taylor Resolution open => fixed
2006-11-01 17:33 taylor Fixed in Version => 3.6.9
2012-01-05 22:55 taylor Changeset attached => Import 2012-01-05 17:52:05 fs2_open_3_6_9 r3678
2012-01-05 22:55 taylor Changeset attached => Import 2012-01-05 17:52:05 trunk r3717
2012-01-09 18:06 taylor Changeset attached => fs2open_websvn fs2_open_3_6_9 r3678
2012-01-09 18:06 taylor Changeset attached => fs2open_websvn trunk r3717