View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0003209 | FSSCP | Pilot data | public | 2020-07-13 11:12 | 2020-12-24 09:56 |
Reporter | MatthTheGeek | Assigned To | Goober5000 | ||
Priority | normal | Severity | major | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
OS | Windows | ||||
Product Version | 19.0.0 | ||||
Summary | 0003209: Special characters in ship names will break JSON pilot | ||||
Description | First found in Procyon Insurgency, which has a ship named GTF Erinyes². When killed by the player, the JSON will end up with a scoring entry with no name value, resulting in a JSON crash at game start. Of course this is mostly a modder issue here (don't use freaking special characters when we have "#name" available for ship names), but I feel like debug should at least throw a warning when parsing that ship entry. Right now FSO loads this ship fine (except for the specific JSON issue). | ||||
Tags | No tags attached. | ||||
|
The unprintable character trick has been around ever since retail days. The # symbol in ship names wasn't supported until a few years into FSO's existence. (However the # symbol in ship class names has been supported since FS1.) This is most likely a character encoding issue. |
|
Fixed in this PR: https://github.com/scp-fs2open/fs2open.github.com/pull/2569 |
Date Modified | Username | Field | Change |
---|---|---|---|
2020-07-13 11:12 | MatthTheGeek | New Issue | |
2020-07-13 17:15 | Goober5000 | Note Added: 0017006 | |
2020-07-13 20:22 | Goober5000 | Assigned To | => Goober5000 |
2020-07-13 20:22 | Goober5000 | Status | new => code review |
2020-07-13 20:22 | Goober5000 | Note Added: 0017007 | |
2020-12-24 09:56 | Goober5000 | Status | code review => resolved |
2020-12-24 09:56 | Goober5000 | Resolution | open => fixed |