2020-08-13 03:22 EDT


View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0003209FSSCPPilot datapublic2020-07-13 16:22
ReporterMatthTheGeek 
Assigned ToGoober5000 
PrioritynormalSeveritymajorReproducibilityalways
Statuscode reviewResolutionopen 
PlatformOSWindowsOS Version
Product Version19.0.0 
Target VersionFixed in Version 
Summary0003209: Special characters in ship names will break JSON pilot
DescriptionFirst found in Procyon Insurgency, which has a ship named GTF Erinyes².

When killed by the player, the JSON will end up with a scoring entry with no name value, resulting in a JSON crash at game start.

Of course this is mostly a modder issue here (don't use freaking special characters when we have "#name" available for ship names), but I feel like debug should at least throw a warning when parsing that ship entry. Right now FSO loads this ship fine (except for the specific JSON issue).
TagsNo tags attached.
Attached Files

-Relationships
+Relationships

-Notes

~0017006

Goober5000 (administrator)

The unprintable character trick has been around ever since retail days. The # symbol in ship names wasn't supported until a few years into FSO's existence. (However the # symbol in ship class names has been supported since FS1.)

This is most likely a character encoding issue.

~0017007

Goober5000 (administrator)

Fixed in this PR:
https://github.com/scp-fs2open/fs2open.github.com/pull/2569
+Notes

-Issue History
Date Modified Username Field Change
2020-07-13 07:12 MatthTheGeek New Issue
2020-07-13 13:15 Goober5000 Note Added: 0017006
2020-07-13 16:22 Goober5000 Assigned To => Goober5000
2020-07-13 16:22 Goober5000 Status new => code review
2020-07-13 16:22 Goober5000 Note Added: 0017007
+Issue History