|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0003124||FSSCP||Platform-Engine interaction||public||2014-10-18 12:40||2014-10-18 14:18|
|Product Version||3.7.2 RC4|
|Target Version||Fixed in Version|
|Summary||0003124: -keyboard_layout qwertz should remap the Y and Z keys|
|Description||If I launch FSO with "-keyboard_layout qwertz", all keys are bound correctly except for the Y and Z keys. Changing the language doesn't affect this.|
If the language is set to English, all key labels are according to the QWERTY layout, only the Y and Z keys are labeled according to QWERTZ. If the language is set to German, all key labels are correct (QWERTZ) but the Y and Z key labels are swapped.
I suggest remapping the Y and Z keys for consistency (then the keys' labels would be consistent, too).
|Steps To Reproduce||If I run FSO with "-keyboard_layout qwertz" and in English, the "#" key is displayed as "\" (which is wrong) but it's bound correctly. The "Z" key is displayed correctly but bound to the wrong function in the default keyboard bindings.|
if I run FSO with "-keyboard_layout qwertz" and switch to German, the "#" key is displayed as "#" (which is correct) and it's bound correctly. The "Z" key is displayed as "Y" (which is wrong) and bound to the wrong function.
|Additional Information||The remapping should probably be done in code/io/key.cpp, FillSDLArray().|
It would be nice if the key labels would depend on the keyboard layout and not the selected language. The relevant checks are in code/controlconfig/controlsconfigcommon.cpp, control_config_common_init().
|Tags||No tags attached.|
The attached patch should fix the Y and Z mappings for the QWERTZ layout. It should also fix AZERTY mappings as well as some of the French key labels.
One thing to keep in mind is that the key labels are currently based on scancodes, which are independent of the keyboard layout in use. To make the labels correct for every combination of keyboard layout and language (which, I agree, would be a good thing), the labels would have to be based on the characters that are assigned to the scancodes, which would require some restructuring in controlsconfigcommon.cpp and the use of SDL for all platforms (currently, Windows builds don't use SDL). Thus, such a fix for the labels is probably better implemented in Antipodes 9 rather than current trunk.
|2014-10-18 12:40||ngld||New Issue|
|2014-10-18 14:17||Yarn||File Added: mantis3124.patch|
|2014-10-18 14:18||Yarn||Note Added: 0016340|
|2014-10-18 14:18||Yarn||Assigned To||=> Yarn|
|2014-10-18 14:18||Yarn||Status||new => feedback|