View Issue Details [ Jump to Notes ] [ Related Changesets ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
---|---|---|---|---|---|---|---|---|---|
0003106 | FSSCP | HUD | public | 2014-09-13 02:41 | 2014-09-24 02:37 | ||||
Reporter | Yarn | ||||||||
Assigned To | Yarn | ||||||||
Priority | normal | Severity | minor | Reproducibility | always | ||||
Status | resolved | Resolution | fixed | ||||||
Platform | x64 | OS | Windows 7 | OS Version | |||||
Product Version | 3.7.2 RC4 | ||||||||
Target Version | 3.7.2 | Fixed in Version | 3.7.2 | ||||||
Summary | 0003106: Font parameter in hud_gauges.tbl not parsed correctly [patch included] | ||||||||
Description | Whenever a HUD gauge uses the Font parameter, the value gets assigned to the global variable Hud_font instead of the local variable font_num. This results in the gauge using font index 0 instead of what the Font parameter specifies, along with maybe some other problems. | ||||||||
Additional Information | A fix for this bug is attached. | ||||||||
Tags | No tags attached. | ||||||||
Attached Files |
|
![]() |
|
m_m (developer) 2014-09-13 15:20 |
The patch looks good to me. What are the effects on existing mods? Given that nobody noticed this until now it shouldn't be a big problem. If that is the case I can commit this soon. |
Yarn (developer) 2014-09-13 20:06 |
The only problem that I'm aware of is that, if this patch is committed, Blue Planet 2 would no longer display the match-speed icon in the throttle gauge and the arrows in the weapons gauge because that mod configures those gauges to use font 3 (that is, the fourth font). Fortunately, I did make a patch VP to fix this and a few other things: http://www.hard-light.net/forums/index.php?topic=88351.msg1763237#msg1763237 |
Goober5000 (administrator) 2014-09-23 22:42 |
Nicely spotted, good fix. Committing patch... |
![]() |
|||
fs2open: trunk r11080
Timestamp: 2014-09-23 23:18:25 Author: Goober5000 Ported: N/A [ Details ] [ Diff ] |
Yarn's patch for Mantis 0003106 (Font parameter in hud_gauges.tbl not parsed correctly) | ||
mod - /trunk/fs2_open/code/hud/hudparse.cpp | [ Diff ] [ File ] | ||
![]() |
|||
Date Modified | Username | Field | Change |
---|---|---|---|
2014-09-13 02:41 | Yarn | New Issue | |
2014-09-13 02:41 | Yarn | Status | new => assigned |
2014-09-13 02:41 | Yarn | Assigned To | => Yarn |
2014-09-13 02:41 | Yarn | File Added: mantis3106.patch | |
2014-09-13 02:41 | Yarn | Status | assigned => code review |
2014-09-13 15:20 | m_m | Note Added: 0016279 | |
2014-09-13 20:06 | Yarn | Note Added: 0016280 | |
2014-09-23 22:42 | Goober5000 | Note Added: 0016290 | |
2014-09-23 22:42 | Goober5000 | Status | code review => resolved |
2014-09-23 22:42 | Goober5000 | Resolution | open => fixed |
2014-09-23 22:42 | Goober5000 | Changeset attached | => fs2open trunk r11080 |
2014-09-24 02:37 | Goober5000 | Fixed in Version | => 3.7.2 |