|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0003101||FSSCP||docking||public||2014-08-24 16:21||2014-08-26 00:46|
|Target Version||Fixed in Version||3.7.5|
|Summary||0003101: Support Ship Can't Dock Error|
|Description||FSO throws an error when the support ship is called but the player ship doesn't have a docking point. Causes a crash on Ubuntu according to praseodym:|
Can be fixed mission side, but it doesn't make logical sense to be able to call a support ship if your ship can't receive one. Better way to handle this?
Test Mission Attached. (Should be run with BP)
|Steps To Reproduce||Call a support ship when in the Spacesuit.|
|Tags||No tags attached.|
|Can you attach a screenshot of the error, as well as your fs2_open.log? I'm surprised this causes a problem because FSO should accommodate this already.|
|Additional info, debug throws a repeating warning when the comm menu is brought up. As you can see the standard build throws the error when the support ship has jumped in.|
Last edited: 2014-08-25 01:19
You said it throws an error, but the log has only warnings. I don't see a problem with throwing a warning here...
EDIT: Apparently reading is hard (I blame tiredness). So the constant warnings prevent you from ever trying to call the support ship in the first place? What if you use shift+R?
|Debug keeps the support ship from jumping in. This should probably the target behavior (minus the warning message). Standard build allows the support ship to jump in and trigger the error.|
So yes, I remembered correctly and FSO does check for this. The problem is that for optimization purposes, and because mods should disallow this situation, it only performs the check on debug mode.
A simple fix would be to perform the check in all circumstances, but this would remove the optimization. More thought is needed.
|I've committed an accommodation so that release builds won't crash and debug builds will only display the warning once. But this is really a mod error and mod authors should take care that all their player-flyable ships that fly in missions where support is allowed should have support ship dockpoints.|
fs2open: trunk r11028
Timestamp: 2014-08-26 01:15:49
|Mantis 0003101: check for presence of support dockpoints in all builds, not just release|
|mod - /trunk/fs2_open/code/ship/ship.cpp|
|2014-08-24 16:21||Cyborg17||New Issue|
|2014-08-24 16:21||Cyborg17||Status||new => assigned|
|2014-08-24 16:21||Cyborg17||Assigned To||=> Goober5000|
|2014-08-24 16:21||Cyborg17||File Added: MantisSupportShipTestMission.fs2|
|2014-08-24 21:54||Goober5000||Note Added: 0016252|
|2014-08-24 22:57||Cyborg17||File Added: fs2_open.log|
|2014-08-24 23:03||Cyborg17||File Added: dockerror.png|
|2014-08-24 23:07||Cyborg17||Note Added: 0016253|
|2014-08-25 01:14||MageKing17||Note Added: 0016254|
|2014-08-25 01:19||MageKing17||Note Edited: 0016254||View Revisions|
|2014-08-25 21:52||Cyborg17||Note Added: 0016259|
|2014-08-26 00:27||Goober5000||Note Added: 0016260|
|2014-08-26 00:44||Goober5000||Changeset attached||=> fs2open trunk r11028|
|2014-08-26 00:46||Goober5000||Note Added: 0016261|
|2014-08-26 00:46||Goober5000||Status||assigned => resolved|
|2014-08-26 00:46||Goober5000||Resolution||open => fixed|
|2014-08-26 00:46||Goober5000||Fixed in Version||=> 3.7.5|