View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003088 | FSSCP | user interface | public | 2014-08-08 22:19 | 2014-08-10 03:41 |
| Reporter | Yarn | Assigned To | Yarn | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | x64 | OS | Windows 7 | ||
| Product Version | 3.7.2 | ||||
| Summary | 0003088: Fix for missing German keys in controls config | ||||
| Description | I noticed that two of the key names in the Scan_code_text_german array use hex codes that point to characters that aren't in the German font, resulting in those key names not being displayed at all in the controls config screen if the language is set to German. The attached patch fixes them so that they are displayed correctly. Here is what I changed: "\xE1" (default key for "Geschwindigkeit um 5 Prozent erhöhen" or "Increase Throttle 5 Percent") is supposed to be the letter ß, which doesn't exist in the German font. Normally, if it's encountered in files (internal or external), it's converted to ss, but that doesn't happen with hardcoded strings. Thus, I changed it to "Eszett", the German name of the letter. (If a better name exists, let me know.) "\xAE" (default key for "Radarreichweite einstellen" or "Cycle Radar Range") is supposed to be Ä, but that letter is actually at "\x8E" in the German font, so I corrected the label to that. | ||||
| Steps To Reproduce | To confirm for yourself that the patch is working, you need to change the language to German and install the German font, which you can get here: https://dl.dropboxusercontent.com/u/89353583/FreeSpace/Fonts/German_fs2.zip Once you've done that, go to the controls config screen and check the controls mentioned above. | ||||
| Additional Information | It appears that this bug existed in retail, since the original source code uses the same problematic labels. | ||||
| Tags | No tags attached. | ||||
|
|
mantis3088.patch (1,053 bytes)
Index: code/controlconfig/controlsconfigcommon.cpp
===================================================================
--- code/controlconfig/controlsconfigcommon.cpp (revision 10974)
+++ code/controlconfig/controlsconfigcommon.cpp (working copy)
@@ -197,12 +197,12 @@
char *Scan_code_text_german[] = {
"", "Esc", "1", "2", "3", "4", "5", "6",
- "7", "8", "9", "0", "Akzent '", "\xE1", "R\x81""cktaste", "Tab",
+ "7", "8", "9", "0", "Akzent '", "Eszett", "R\x81""cktaste", "Tab",
"Q", "W", "E", "R", "T", "Z", "U", "I",
"O", "P", "\x9A", "+", "Eingabe", "Strg Links", "A", "S",
"D", "F", "G", "H", "J", "K", "L", "\x99",
- "\xAE", "`", "Shift", "#", "Y", "X", "C", "V",
+ "\x8E", "`", "Shift", "#", "Y", "X", "C", "V",
"B", "N", "M", ",", ".", "-", "Shift", "Num *",
"Alt", "Leertaste", "Hochstell", "F1", "F2", "F3", "F4", "F5",
|
|
|
looks good, I'll commit shortly |
|
|
Fix committed to trunk@10984. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-08-08 22:19 | Yarn | New Issue | |
| 2014-08-08 22:19 | Yarn | File Added: mantis3088.patch | |
| 2014-08-08 22:19 | Yarn | Assigned To | => Yarn |
| 2014-08-08 22:19 | Yarn | Status | new => code review |
| 2014-08-10 03:40 | niffiwan | Note Added: 0016196 | |
| 2014-08-10 03:41 | niffiwan | Changeset attached | => fs2open trunk r10984 |
| 2014-08-10 03:41 | niffiwan | Note Added: 0016197 | |
| 2014-08-10 03:41 | niffiwan | Status | code review => resolved |
| 2014-08-10 03:41 | niffiwan | Resolution | open => fixed |
