View Issue Details

IDProjectCategoryView StatusLast Update
0003053FSSCPSEXPspublic2014-06-09 01:21
ReporterMageKing17 Assigned ToMageKing17  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Product Version3.7.2 RC2 
Summary0003053: Event Snapshot only functions in debug build.
DescriptionDespite the instructions in karajorma's post introducing this feature ( http://www.hard-light.net/forums/index.php?topic=85174.0 ), enabling cheat mode will not allow you to save an event snapshot because the code only checks KEY_DEBUGGING and not KEY_DEBUGGING1 (the former of which only shows up in debug builds).

Attached is a simple patch to make it function as the post implies it should have all along.
TagsNo tags attached.

Activities

MageKing17

2014-05-31 03:48

developer  

keycontrol.cpp.patch (332 bytes)   
Index: code/io/keycontrol.cpp
===================================================================
--- code/io/keycontrol.cpp	(revision 10731)
+++ code/io/keycontrol.cpp	(working copy)
@@ -636,6 +636,7 @@
 
 	switch (k) {
 		case KEY_DEBUGGED + KEY_Q:
+		case KEY_DEBUGGED1 + KEY_Q:
 			Snapshot_all_events = true;
 			break;
 
keycontrol.cpp.patch (332 bytes)   

niffiwan

2014-05-31 07:09

developer   ~0015776

looks good to me - see the similar arrangement for other keys like this.
        case KEY_DEBUGGED + KEY_X:
        case KEY_DEBUGGED1 + KEY_X:

niffiwan

2014-06-02 08:04

developer   ~0015782

Fix committed to trunk@10740.

Related Changesets

fs2open: trunk r10740

2014-06-02 03:20

niffiwan


Ported: N/A

Details Diff
Fix mantis 3053 (From MageKing17)

Check KEY_DEBUGGED1 to allow event.log snapshot to trigger when using
release+cheats
Affected Issues
0003053
mod - /trunk/fs2_open/code/io/keycontrol.cpp Diff File

Issue History

Date Modified Username Field Change
2014-05-31 03:48 MageKing17 New Issue
2014-05-31 03:48 MageKing17 File Added: keycontrol.cpp.patch
2014-05-31 06:38 Echelon9 Status new => code review
2014-05-31 07:09 niffiwan Note Added: 0015776
2014-06-02 08:04 niffiwan Changeset attached => fs2open trunk r10740
2014-06-02 08:04 niffiwan Note Added: 0015782
2014-06-02 08:04 niffiwan Status code review => resolved
2014-06-02 08:04 niffiwan Resolution open => fixed
2014-06-09 01:21 Goober5000 Assigned To => MageKing17