View Issue Details

IDProjectCategoryView StatusLast Update
0003026FSSCPuser interfacepublic2014-05-19 10:17
Reporterwilliam Assigned Toniffiwan  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
PlatformLinux 
Product Version3.7.1 
Summary0003026: CLI does not show -mod option
DescriptionThe command line help does not show the -mod option.
Steps To Reproduce./fs2_open_3.7.1 -h | grep mod
TagsNo tags attached.

Activities

niffiwan

2014-04-12 12:42

developer   ~0015698

Last edited: 2014-04-13 12:03

Looks like a fairly trivial addition to os_validate_parms() / code/cmdline/cmdline.cpp is needed. Note that -mod is not part of exe_params[] which is why it's not currently being displayed.

edit:
remember to check other cmdline params that accept a value; e.g. -fov, -ambient_factor, etc

niffiwan

2014-05-18 09:55

developer   ~0015751

So, it wasn't quite as trivial as I 1st thought :)

Anyway, updated FSO so that the --help option on Linux outputs all non-deprecated flags. I've also added info on the types of arguments expected by various options, and added help data for some flags that were missing it.

Any comments?

https://github.com/niffiwan/fs2open.github.com/commit/a2e7543da38344c15a59d4b8b80485c1fc7c38ab

niffiwan

2014-05-19 10:17

developer   ~0015752

Fix committed to trunk@10706.

Related Changesets

fs2open: trunk r10706

2014-05-19 05:31

niffiwan


Ported: N/A

Details Diff
Fix mantis 3026

Update Linux --help option to show all cmdline options
Added data/checks for expected args to cmdline options
Add extra const-ness per m!m review
Affected Issues
0003026
mod - /trunk/fs2_open/code/cmdline/cmdline.cpp Diff File

Issue History

Date Modified Username Field Change
2014-04-05 06:03 william New Issue
2014-04-12 12:41 niffiwan Assigned To => niffiwan
2014-04-12 12:41 niffiwan Status new => assigned
2014-04-12 12:42 niffiwan Note Added: 0015698
2014-04-13 12:03 niffiwan Note Edited: 0015698
2014-05-18 09:55 niffiwan Note Added: 0015751
2014-05-18 09:55 niffiwan Status assigned => code review
2014-05-19 10:17 niffiwan Changeset attached => fs2open trunk r10706
2014-05-19 10:17 niffiwan Note Added: 0015752
2014-05-19 10:17 niffiwan Status code review => resolved
2014-05-19 10:17 niffiwan Resolution open => fixed