View Issue Details

IDProjectCategoryView StatusLast Update
0003014FSSCPgraphicspublic2016-12-12 01:37
ReporterKobrar Assigned ToDahBlount  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
OSWindows 7 HP 64bit 
Product Version3.7.1 
Summary0003014: Environmental reflections are wrong
DescriptionSo it is a bug originally reported on the forum in thread:
http://www.hard-light.net/forums/index.php?topic=87019.msg1739006#msg1739006
Basically, some of the coordinates of the cubemap seem to be flipped.

Testcase here: https://www.mediafire.com/?s1rcbe6pcoi1o1q
Steps To Reproduce1.Let the engine produce his own cubemap[at least from cube skybox].
2.Watch the reflection on some reflective object.
TagsNo tags attached.

Activities

Goober5000

2014-06-06 00:31

administrator   ~0015803

Am I to understand that this is now fixed?

niffiwan

2014-06-06 00:41

developer   ~0015804

Last edited: 2014-06-06 00:50

Did you mean to assign this one to me? I am an OGL neophyte...

Edit: ok - just some confusion due to me misnaming a commit on github - this one isn't fixed as far as I know.

Goober5000

2014-09-24 06:42

administrator   ~0016295

Last edited: 2014-09-24 06:42

Removing the 3.7.2 tag since I only added that because I thought niffiwan had fixed it. :)

Echelon9

2015-06-26 11:24

developer   ~0016759

I'll have a go looking at this one.

DahBlount

2015-11-22 22:59

administrator   ~0016791

Pull request to fix this is now available.
https://github.com/scp-fs2open/fs2open.github.com/pull/466

niffiwan

2015-12-06 06:56

developer   ~0016796

This is fixed now?

Also - can haz DahBlount 'developer' status?

MageKing17

2015-12-06 09:53

developer   ~0016797

The final PR that should have fixed this: https://github.com/scp-fs2open/fs2open.github.com/pull/468

Until DahBlount gets dev status, I've unassigned this from Echelon9 and I'm marking it fixed.

Kobrar

2015-12-07 21:58

reporter   ~0016798

As seen here: https://www.youtube.com/watch?v=OO4cxEh-kqk
There are still some issues

DahBlount

2015-12-13 00:05

administrator   ~0016800

Looking further into this, turns out the inverse matrix4 function wasn't even required. Removing the function call in gropengltnl.cpp gives proper results simply with the changes to the texture_mat setup in gropengltnl.cpp and freespace.cpp as well as an additional change in the main vertex shader to normalize the eye position.

MageKing17

2015-12-15 14:23

developer   ~0016802

This should finally be fixed for real now: https://github.com/scp-fs2open/fs2open.github.com/pull/499

Issue History

Date Modified Username Field Change
2014-03-05 20:54 Kobrar New Issue
2014-06-06 00:31 Goober5000 Note Added: 0015803
2014-06-06 00:31 Goober5000 Assigned To => niffiwan
2014-06-06 00:31 Goober5000 Status new => code review
2014-06-06 00:31 Goober5000 Target Version => 3.7.2
2014-06-06 00:41 niffiwan Note Added: 0015804
2014-06-06 00:50 niffiwan Note Edited: 0015804
2014-06-06 00:50 niffiwan Assigned To niffiwan =>
2014-06-06 00:50 niffiwan Status code review => new
2014-09-24 03:16 niffiwan Description Updated
2014-09-24 06:42 Goober5000 Note Added: 0016295
2014-09-24 06:42 Goober5000 Target Version 3.7.2 =>
2014-09-24 06:42 Goober5000 Note Edited: 0016295
2015-06-26 11:24 Echelon9 Note Added: 0016759
2015-06-26 11:24 Echelon9 Assigned To => Echelon9
2015-06-26 11:24 Echelon9 Status new => assigned
2015-11-22 22:59 DahBlount Note Added: 0016791
2015-12-06 06:56 niffiwan Note Added: 0016796
2015-12-06 09:53 MageKing17 Note Added: 0016797
2015-12-06 09:53 MageKing17 Assigned To Echelon9 =>
2015-12-06 09:53 MageKing17 Status assigned => resolved
2015-12-06 09:53 MageKing17 Resolution open => fixed
2015-12-07 21:58 Kobrar Note Added: 0016798
2015-12-07 21:58 Kobrar Status resolved => feedback
2015-12-07 21:58 Kobrar Resolution fixed => reopened
2015-12-13 00:05 DahBlount Note Added: 0016800
2015-12-15 14:23 MageKing17 Note Added: 0016802
2015-12-15 14:23 MageKing17 Status feedback => resolved
2015-12-15 14:23 MageKing17 Resolution reopened => fixed
2016-12-12 01:37 Goober5000 Assigned To => DahBlount