| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0003014 | FSSCP | graphics | public | 2014-03-05 15:54 | 2016-12-11 20:37 | ||||
| Reporter | Kobrar | ||||||||
| Assigned To | DahBlount | ||||||||
| Priority | normal | Severity | minor | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Platform | OS | Windows 7 HP 64bit | OS Version | ||||||
| Product Version | 3.7.1 | ||||||||
| Target Version | Fixed in Version | ||||||||
| Summary | 0003014: Environmental reflections are wrong | ||||||||
| Description | So it is a bug originally reported on the forum in thread: http://www.hard-light.net/forums/index.php?topic=87019.msg1739006#msg1739006 Basically, some of the coordinates of the cubemap seem to be flipped. Testcase here: https://www.mediafire.com/?s1rcbe6pcoi1o1q | ||||||||
| Steps To Reproduce | 1.Let the engine produce his own cubemap[at least from cube skybox]. 2.Watch the reflection on some reflective object. | ||||||||
| Tags | No tags attached. | ||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Goober5000 (administrator) 2014-06-05 20:31 |
Am I to understand that this is now fixed? |
|
niffiwan (developer) 2014-06-05 20:41 Last edited: 2014-06-05 20:50 |
Did you mean to assign this one to me? I am an OGL neophyte... Edit: ok - just some confusion due to me misnaming a commit on github - this one isn't fixed as far as I know. |
|
Goober5000 (administrator) 2014-09-24 02:42 Last edited: 2014-09-24 02:42 |
Removing the 3.7.2 tag since I only added that because I thought niffiwan had fixed it. :) |
|
Echelon9 (developer) 2015-06-26 07:24 |
I'll have a go looking at this one. |
|
DahBlount (developer) 2015-11-22 17:59 |
Pull request to fix this is now available. https://github.com/scp-fs2open/fs2open.github.com/pull/466 |
|
niffiwan (developer) 2015-12-06 01:56 |
This is fixed now? Also - can haz DahBlount 'developer' status? |
|
MageKing17 (developer) 2015-12-06 04:53 |
The final PR that should have fixed this: https://github.com/scp-fs2open/fs2open.github.com/pull/468 Until DahBlount gets dev status, I've unassigned this from Echelon9 and I'm marking it fixed. |
|
Kobrar (reporter) 2015-12-07 16:58 |
As seen here: https://www.youtube.com/watch?v=OO4cxEh-kqk There are still some issues |
|
DahBlount (developer) 2015-12-12 19:05 |
Looking further into this, turns out the inverse matrix4 function wasn't even required. Removing the function call in gropengltnl.cpp gives proper results simply with the changes to the texture_mat setup in gropengltnl.cpp and freespace.cpp as well as an additional change in the main vertex shader to normalize the eye position. |
|
MageKing17 (developer) 2015-12-15 09:23 |
This should finally be fixed for real now: https://github.com/scp-fs2open/fs2open.github.com/pull/499 |
| Notes |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-03-05 15:54 | Kobrar | New Issue | |
| 2014-06-05 20:31 | Goober5000 | Note Added: 0015803 | |
| 2014-06-05 20:31 | Goober5000 | Assigned To | => niffiwan |
| 2014-06-05 20:31 | Goober5000 | Status | new => code review |
| 2014-06-05 20:31 | Goober5000 | Target Version | => 3.7.2 |
| 2014-06-05 20:41 | niffiwan | Note Added: 0015804 | |
| 2014-06-05 20:50 | niffiwan | Note Edited: 0015804 | View Revisions |
| 2014-06-05 20:50 | niffiwan | Assigned To | niffiwan => |
| 2014-06-05 20:50 | niffiwan | Status | code review => new |
| 2014-09-23 23:16 | niffiwan | Description Updated | View Revisions |
| 2014-09-24 02:42 | Goober5000 | Note Added: 0016295 | |
| 2014-09-24 02:42 | Goober5000 | Target Version | 3.7.2 => |
| 2014-09-24 02:42 | Goober5000 | Note Edited: 0016295 | View Revisions |
| 2015-06-26 07:24 | Echelon9 | Note Added: 0016759 | |
| 2015-06-26 07:24 | Echelon9 | Assigned To | => Echelon9 |
| 2015-06-26 07:24 | Echelon9 | Status | new => assigned |
| 2015-11-22 17:59 | DahBlount | Note Added: 0016791 | |
| 2015-12-06 01:56 | niffiwan | Note Added: 0016796 | |
| 2015-12-06 04:53 | MageKing17 | Note Added: 0016797 | |
| 2015-12-06 04:53 | MageKing17 | Assigned To | Echelon9 => |
| 2015-12-06 04:53 | MageKing17 | Status | assigned => resolved |
| 2015-12-06 04:53 | MageKing17 | Resolution | open => fixed |
| 2015-12-07 16:58 | Kobrar | Note Added: 0016798 | |
| 2015-12-07 16:58 | Kobrar | Status | resolved => feedback |
| 2015-12-07 16:58 | Kobrar | Resolution | fixed => reopened |
| 2015-12-12 19:05 | DahBlount | Note Added: 0016800 | |
| 2015-12-15 09:23 | MageKing17 | Note Added: 0016802 | |
| 2015-12-15 09:23 | MageKing17 | Status | feedback => resolved |
| 2015-12-15 09:23 | MageKing17 | Resolution | reopened => fixed |
| 2016-12-11 20:37 | Goober5000 | Assigned To | => DahBlount |
| Issue History |