2017-05-27 18:02 EDT


View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0003006FSSCPFREDpublic2017-01-01 18:09
ReporterGeneralBattuta 
Assigned To 
PrioritylowSeverityminorReproducibilitysometimes
StatusconfirmedResolutionopen 
PlatformPCOSWindowsOS VersionWindows 7 64 bit
Product Version3.7.1 
Target VersionFixed in Version 
Summary0003006: FRED crashes when left open and idle for long periods of time.
DescriptionBy Kara's request -

FRED locks up and stops responding when left idle for long periods of time. This may be tied to OS sleep/hibernation behavior, but it's not clear. While a bunch of people have confirmed encountering this bug and some think it's tied to leaving the events window open, others don't get encounter it at all.

I don't think this issue is a major priority. It's only a serious concern when the FREDder has to leave the computer without saving and can't return for a long time (a pretty rare use case unless, well, you are being dragged away, which is not a bad problem to have but which can really set your missions back!).
Steps To ReproduceWe're working to narrow this down. I'm gonna try leaving FRED on overnight WITHOUT the events window open to see if that alters the outcome.
TagsNo tags attached.
Attached Files

-Relationships
+Relationships

-Notes

~0015621

Echelon9 (developer)

Could be a memory leak of some form.

~0015695

Goober5000 (administrator)

Has there been any progress on this?

~0016841

Goober5000 (administrator)

Attached a screenshot from Brian See, reported in this thread:
http://www.hard-light.net/forums/index.php?topic=92943.0

This makes things more interesting. Just spitballing here - I wonder if the Event Editor is updating some sort of log, tally, or other vector-based structure, and leaving the window open for a long time causes the index to exceed INT_MAX.

~0016842

Axem (reporter)

I managed to reproduce something sorta related. The same error message as Bryan See anyway. I added a bunch of new messages and events in the event editor, let it sit for like 3 hours and when I hit the okay button, I got that error message.

~0016843

Axem (reporter)

(Should note I attached a picture of the debugger trying to trace it down, its something messages related)

~0016844

Axem (reporter)

Okay, after trying again, this happens all the time with Debug FRED. No idling required. It'll happen all the time if you add a message and then click OK in the event editor.

It may not be the same bug, but it is a bug.

~0016845

MageKing17 (developer)

Well, I've opened a PR for at least the issue Axem reported (since I could actually reproduce it): https://github.com/scp-fs2open/fs2open.github.com/pull/1123

~0016846

Goober5000 (administrator)

I was going to look into this today but I see MageKing17 already beat me to it, with the correct identification and solution. :yes:

That doesn't fix the root cause of the idling bug, though, since OnOk only runs when you click Ok.

While looking into this I found another issue, for which I've opened a PR here:
https://github.com/scp-fs2open/fs2open.github.com/pull/1124

~0016847

MageKing17 (developer)

I wouldn't rule out PR 0001123 fixing the idling bug; given that it was writing past the end of the vector, we were in nasal demon territory. The undefined behavior could very well have meant that, if messages were added and ok was clicked at least once, FRED could've been left in a "ticking time bomb" state that made a future crash inevitable. We won't know for sure until/unless the idling crash happens again in the future.
+Notes

-Issue History
Date Modified Username Field Change
2014-02-06 21:12 GeneralBattuta New Issue
2014-02-09 08:33 Echelon9 Note Added: 0015621
2014-03-31 11:57 Goober5000 Note Added: 0015695
2016-12-29 23:54 Goober5000 Status new => confirmed
2016-12-29 23:55 Goober5000 File Added: vector subscript.png
2016-12-29 23:59 Goober5000 Note Added: 0016841
2016-12-31 15:39 Axem File Added: Clipboard01.png
2016-12-31 15:39 Axem Note Added: 0016842
2016-12-31 15:39 Axem Note Added: 0016843
2016-12-31 15:45 Axem Note Added: 0016844
2017-01-01 00:42 MageKing17 Note Added: 0016845
2017-01-01 17:49 Goober5000 Note Added: 0016846
2017-01-01 18:09 MageKing17 Note Added: 0016847
+Issue History