View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0003005 | FSSCP | design flaw | public | 2014-02-05 07:44 | 2014-06-14 03:25 |
| Reporter | Black Wolf | Assigned To | niffiwan | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 3.7.0 | ||||
| Summary | 0003005: End-Mission and End-Campaign sexps can still trigger after player death | ||||
| Description | Basically what it says above - if you die, and then hang around to watch the mission continue to play out, events may occur that trigger one of the above sexps, dumping the player either to the debriefing screen or the main menu. While there are circumstances where this behaviour may be useful, it should be off by default and require a mission flag or sexp to turn it on. | ||||
| Tags | No tags attached. | ||||
|
|
For end-mission does setting the 1st parameter to false give the correct behaviour? [quote] End Mission even if the player is dead (optional; defaults to true) [/quote] If that works correctly then something similar could be added to end-campaign. |
|
|
It should work correctly. It certainly did when I added the feature. Now I remember adding it, I also remember why I did it that way round. It was to keep the SEXP working the same way it did before I fiddled with it. |
|
|
I know there are more than a few missions out there now that end a mission on a player's death with that sexp. So altering the default would probably break those missions. |
|
|
|
|
|
|
|
|
I've created a test campaign and a patch. https://github.com/niffiwan/fs2open.github.com/commit/b2076958ef8dedd393b3b02e20a61b708d8e5e52 I'll put up a build... soon (tm) edit: here it is. http://www.mediafire.com/download/6ehjc4dkr1fhq6b/fs2_open_3_7_1_SSE2_mantis3005.7z |
|
|
and another one for review ;) |
|
|
thanks to MageKing17 & Zacam for the IRC review of this patch |
|
|
Fix committed to trunk@10804. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-02-05 07:44 | Black Wolf | New Issue | |
| 2014-02-17 10:50 | niffiwan | Note Added: 0015624 | |
| 2014-02-21 12:40 | karajorma | Note Added: 0015628 | |
| 2014-02-22 15:36 | Axem | Note Added: 0015629 | |
| 2014-02-22 15:37 | Axem | Note Edited: 0015629 | |
| 2014-03-17 10:16 | niffiwan | Assigned To | => niffiwan |
| 2014-03-17 10:16 | niffiwan | Status | new => assigned |
| 2014-03-17 10:20 | niffiwan | File Added: endc_t.fc2 | |
| 2014-03-17 10:20 | niffiwan | File Added: endcampaign1.fs2 | |
| 2014-03-17 10:24 | niffiwan | Note Added: 0015668 | |
| 2014-03-17 11:56 | niffiwan | Note Edited: 0015668 | |
| 2014-03-17 11:57 | niffiwan | Note Edited: 0015668 | |
| 2014-03-17 11:57 | niffiwan | Status | assigned => feedback |
| 2014-05-15 08:39 | niffiwan | Note Added: 0015749 | |
| 2014-05-15 08:39 | niffiwan | Status | feedback => code review |
| 2014-06-14 03:25 | niffiwan | Note Added: 0015857 | |
| 2014-06-14 03:25 | niffiwan | Changeset attached | => fs2open trunk r10804 |
| 2014-06-14 03:25 | niffiwan | Note Added: 0015858 | |
| 2014-06-14 03:25 | niffiwan | Status | code review => resolved |
| 2014-06-14 03:25 | niffiwan | Resolution | open => fixed |
