|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0002999||FSSCP||SEXPs||public||2014-01-11 23:53||2014-07-21 21:01|
|Priority||normal||Severity||minor||Reproducibility||have not tried|
|Target Version||3.7.2||Fixed in Version||3.7.2|
|Summary||0002999: has-docked-delay and has-undocked-delay do not detect support ship docking|
|Description||Contains a better explanation and pastebinned test mission:|
|Steps To Reproduce||Use when-argument to try to detect a support ship docking via has-docked-delay or has-undocked-delay. Events are given in the forum post.|
|Additional Information||From IRC:|
<Karajorma> The issue is that support ship docking isn't written to the mission log
<Karajorma> Since it's never written there, the SEXP can't find any proof that the ships ever docked
<Karajorma> So the SEXP failed
<Karajorma> If you could mantis the issue,, I'd like to ask for Goober's opinion before I fix it.
|Tags||No tags attached.|
My explanation is here:
Though now I've noticed a new complication in the undock code.
I've uploaded a test build here:
Please check it out and see if it behaves the way you'd expect. In particular, see if there's an undock entry added if the player ship moves too fast and causes rearm to abort.
Darth Geek (reporter)
Sorry for the delay. I tested it in several conditions -
Aborting rearm via c-6 before the dock sound plays but after the support ship is in the dockpoint's path does not trigger either has-docked or has-undocked.
Aborting rearm by hitting afterburners after the dock sound plays but before the "rearming complete" message triggers has-docked, but not has-undocked. IMO this is correct but some FREDders may differ.
has-undocked is triggered as soon as the "rearming complete" message plays.
|Well, now I'm thinking that maybe the mission log should be updated in the "break off" case as well. I've asked Shivan Hunter to comment.|
I've uploaded a patch that should add docking and undocking mission logs to the appropriate places. Please also check the "support ship broken off" case.
I'm still wondering why support ships were never logged in the first place, but I haven't thought of any situation where adding the log entry would do any harm.
Darth Geek (reporter)
|Events appear to work in every case now except when a rearm is aborted (e.g. by hitting afterburners), which does not trigger has-undocked-delay.|
|Bleh. I didn't think that part was necessary but maybe it is. Patch modified.|
|Only one stylistic thing I think should be changed here; You're commenting out code in the last part of the patch, and I believe that those lines should be outright removed instead.|
|I talked with Darth Geek over IRC and the patch satisfies all use cases we could think of, so I'll commit it with The E's suggested tweak.|
fs2open: trunk r10930
Timestamp: 2014-07-21 21:26:16
|Mantis 0002999 - add docking log entries for support ships|
|mod - /trunk/fs2_open/code/ai/aicode.cpp|
|2014-01-11 23:53||Darth Geek||New Issue|
|2014-01-26 14:14||Goober5000||Assigned To||=> Goober5000|
|2014-01-26 14:14||Goober5000||Status||new => assigned|
|2014-01-26 14:38||Goober5000||Note Added: 0015580|
|2014-02-03 23:06||Darth Geek||Note Added: 0015588|
|2014-05-01 23:45||Goober5000||Note Added: 0015720|
|2014-06-29 19:13||Goober5000||Target Version||=> 3.7.2|
|2014-07-06 23:53||Goober5000||File Added: Mantis2999-aicode.cpp.patch|
|2014-07-06 23:58||Goober5000||File Deleted: Mantis2999-aicode.cpp.patch|
|2014-07-06 23:58||Goober5000||File Added: Mantis2999-aicode.cpp.patch|
|2014-07-06 23:59||Goober5000||Note Added: 0016030|
|2014-07-06 23:59||Goober5000||Status||assigned => code review|
|2014-07-16 23:52||Darth Geek||Note Added: 0016083|
|2014-07-17 23:00||Goober5000||File Deleted: Mantis2999-aicode.cpp.patch|
|2014-07-17 23:01||Goober5000||File Added: Mantis2999-aicode.cpp.patch|
|2014-07-17 23:02||Goober5000||Note Added: 0016093|
|2014-07-20 14:08||The_E||Note Added: 0016101|
|2014-07-21 21:00||Goober5000||Note Added: 0016114|
|2014-07-21 21:01||Goober5000||Changeset attached||=> fs2open trunk r10930|
|2014-07-21 21:01||Goober5000||Status||code review => resolved|
|2014-07-21 21:01||Goober5000||Resolution||open => fixed|
|2014-07-21 21:01||Goober5000||Fixed in Version||=> 3.7.2|