View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002944 | FSSCP | SEXPs | public | 2013-10-27 13:12 | 2013-10-28 01:46 |
| Reporter | Axem | Assigned To | Goober5000 | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Summary | 0002944: Fade-In sexps not using the color that was faded-out with | ||||
| Description | When the fade-in sexp is used, we always fade from black instead of the color we faded out with, making it kind of odd when fading in from white! Highly suspecting Goober's latest commit for differently coloured fades broke something. Nightly Rev 9826 is fine but then 9835 is broken. It affects both the "legacy" way of doing it and the new RGB way of doing it. Test mission attached. First fade is a 0ms fade to white then a 5000 ms fade in. Second fade is a 4000ms fade to white, then a 5000ms fade in. | ||||
| Tags | No tags attached. | ||||
|
|
|
|
|
Actually, looking at the new sexp I see we have RGB controls for fade-in, but we still need something to account for if those are missing because there are missions that were made before the commit which won't look right because FreeSpace thinks they should now be black instead of the last color used. |
|
|
"we always fade from black instead of the color we faded out with" -- if no arguments are supplied, the default fade color is black, as it has always been. Though, taking a look at the legacy sexp help... ----- { OP_CUTSCENES_FADE_IN, "fade-in\r\n" "\tFades in. " "Takes 0 or 1 arguments...\r\n" "\t1:\tTime to fade in (in milliseconds)\r\n" }, { OP_CUTSCENES_FADE_OUT, "fade-out\r\n" "\tFades out. " "Takes 0 to 2 arguments...\r\n" "\t1:\tTime to fade in (in milliseconds)\r\n" "\t2:\tColor to fade to - 1 for white, 2 for red, default is black\r\n" }, ----- Looks like no fade colors were ever able to be specified for fade-in. Are you saying that the game somehow remembered the last color that was used for fade-out? Because I see how that could have happened in the code, but it's a bug rather than a feature. Whoever originally added color to fade-out should have done the same thing for fade-in. |
|
|
Fixed and confirmed by Axem. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-10-27 13:12 | Axem | New Issue | |
| 2013-10-27 13:12 | Axem | File Added: fade.fs2 | |
| 2013-10-27 13:15 | Axem | Note Added: 0015358 | |
| 2013-10-28 00:24 | Zacam | Assigned To | => Goober5000 |
| 2013-10-28 00:24 | Zacam | Status | new => assigned |
| 2013-10-28 01:11 | Goober5000 | Note Added: 0015361 | |
| 2013-10-28 01:36 | Goober5000 | Changeset attached | => fs2open trunk r9984 |
| 2013-10-28 01:46 | Goober5000 | Note Added: 0015363 | |
| 2013-10-28 01:46 | Goober5000 | Status | assigned => resolved |
| 2013-10-28 01:46 | Goober5000 | Resolution | open => fixed |
