View Issue Details

IDProjectCategoryView StatusLast Update
0002942FSSCPlocalizationpublic2020-05-06 05:11
ReporterGoober5000 Assigned ToGoober5000  
PriorityhighSeveritymajorReproducibilitysometimes
Status resolvedResolutionfixed 
Target Version3.8 
Summary0002942: XSTR indexes can cause string overflows in mods
DescriptionActually the problem isn't so much string overflows, it's different strings, period. See this thread for a full description of the problem:
http://www.hard-light.net/forums/index.php?topic=85041.msg1716600#msg1716600

A feature should be added to lcl_ext_localize so that it returns a special value if the "default language" localized string is a different size from the untranslated string. The mission listing code should check this flag and not add missions to the list whose titles differ in this way.
TagsNo tags attached.

Activities

MageKing17

2016-03-23 10:03

developer   ~0016818

Bumping target.

Goober5000

2020-04-28 04:39

administrator   ~0016985

Github PR:
https://github.com/scp-fs2open/fs2open.github.com/pull/2343

Goober5000

2020-05-06 05:11

administrator   ~0016992

PR merged.

Issue History

Date Modified Username Field Change
2013-10-26 04:41 Goober5000 New Issue
2013-10-26 04:41 Goober5000 Assigned To => Goober5000
2013-10-26 04:41 Goober5000 Status new => assigned
2015-04-16 04:23 Goober5000 Target Version 3.7.2 => 3.7.4
2016-03-23 10:03 MageKing17 Note Added: 0016818
2016-03-23 10:03 MageKing17 Target Version 3.7.4 => 3.8
2020-04-28 04:39 Goober5000 Note Added: 0016985
2020-04-28 05:22 Goober5000 Status assigned => code review
2020-05-06 05:11 Goober5000 Status code review => resolved
2020-05-06 05:11 Goober5000 Resolution open => fixed
2020-05-06 05:11 Goober5000 Note Added: 0016992