| View Issue Details [ Jump to Notes ] [ Related Changesets ] | [ Issue History ] [ Print ] | ||||||||
| ID | Project | Category | View Status | Date Submitted | Last Update | ||||
|---|---|---|---|---|---|---|---|---|---|
| 0002936 | FSSCP | tables | public | 2013-10-14 23:15 | 2013-10-25 19:17 | ||||
| Reporter | Yarn | ||||||||
| Assigned To | Goober5000 | ||||||||
| Priority | normal | Severity | crash | Reproducibility | always | ||||
| Status | resolved | Resolution | fixed | ||||||
| Platform | x64 | OS | Windows 7 | OS Version | |||||
| Product Version | 3.7.1 | ||||||||
| Target Version | 3.7.2 | Fixed in Version | 3.7.2 | ||||||
| Summary | 0002936: Version comment and block comment delimiter on same line causes crash | ||||||||
| Description | Any instance of a line consisting of a version comment followed by a block comment delimiter (e.g., ;;FSO 3.7.0;; /*) causes FSO to crash. Lines like this are necessary for Mjn.mixael's medals to be added to the FreeSpace Port. | ||||||||
| Steps To Reproduce | Simply add the following lines to any table file, preferably before the end marker: ;;FSO 3.5.0;; /* ;;FSO 3.5.0;; */ Have the game parse the table, and voila! Crash. | ||||||||
| Additional Information | Here's an example of the error that this produces: medals.tbl(line 16): Error: Missing required token: [$Num mods:]. Found [;;FSO 3.7.1;; ] instead. ntdll.dll! ZwWaitForSingleObject + 21 bytes kernel32.dll! WaitForSingleObjectEx + 67 bytes kernel32.dll! WaitForSingleObject + 18 bytes fs2_open_3_7_1_SSE2-DEBUG.exe! SCP_DumpStack + 354 bytes fs2_open_3_7_1_SSE2-DEBUG.exe! Error + 229 bytes fs2_open_3_7_1_SSE2-DEBUG.exe! error_display + 369 bytes fs2_open_3_7_1_SSE2-DEBUG.exe! required_string + 106 bytes fs2_open_3_7_1_SSE2-DEBUG.exe! parse_medal_tbl + 1809 bytes fs2_open_3_7_1_SSE2-DEBUG.exe! game_init + 1498 bytes fs2_open_3_7_1_SSE2-DEBUG.exe! game_main + 519 bytes fs2_open_3_7_1_SSE2-DEBUG.exe! WinMain + 328 bytes fs2_open_3_7_1_SSE2-DEBUG.exe! __tmainCRTStartup + 283 bytes fs2_open_3_7_1_SSE2-DEBUG.exe! WinMainCRTStartup + 13 bytes kernel32.dll! BaseThreadInitThunk + 18 bytes ntdll.dll! RtlInitializeExceptionChain + 99 bytes ntdll.dll! RtlInitializeExceptionChain + 54 bytes | ||||||||
| Tags | No tags attached. | ||||||||
| Attached Files |
| ||||||||
 Relationships |
|
 Relationships |
| Notes |
|
|
Yarn (developer) 2013-10-25 00:41 |
If I'm not mistaken, this was fixed in r9945. |
|
Goober5000 (administrator) 2013-10-25 19:17 |
Indeed it was. I forgot to resolve it. |
| Notes |
| Related Changesets |
|||
|
fs2open: trunk r9945
Timestamp: 2013-10-15 19:51:48 Author: Goober5000 Ported: N/A [ Details ] [ Diff ] |
fix handling of multi-line comments, and add !* and *! as a possible option | ||
| mod - /trunk/fs2_open/code/parse/parselo.cpp | [ Diff ] [ File ] | ||
| Related Changesets |
| Issue History |
|||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-10-14 23:15 | Yarn | New Issue | |
| 2013-10-15 09:30 | Goober5000 | Assigned To | => Goober5000 |
| 2013-10-15 09:30 | Goober5000 | Status | new => assigned |
| 2013-10-25 00:41 | Yarn | Note Added: 0015346 | |
| 2013-10-25 19:17 | Goober5000 | Changeset attached | => fs2open trunk r9945 |
| 2013-10-25 19:17 | Goober5000 | Note Added: 0015348 | |
| 2013-10-25 19:17 | Goober5000 | Status | assigned => resolved |
| 2013-10-25 19:17 | Goober5000 | Resolution | open => fixed |
| 2013-10-25 19:17 | Goober5000 | Fixed in Version | => 3.7.2 |
| 2013-10-25 19:17 | Goober5000 | Target Version | => 3.7.2 |
| Issue History |