View Issue Details

IDProjectCategoryView StatusLast Update
0002926wxFREDpublic2013-09-28 23:37
ReporterMjnMixael Assigned Toz64555  
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
PlatformPCOSWindowsOS VersionWin7
Summary0002926: Assert "m_proportion==0" when opening Mission Specs
DescriptionPretty much exactly that.. Assert "m_proportion==0" when you open the Mission Specs editor. You can close the assert and continue, though.
Steps To ReproduceOpen Mission Specs editor.
Additional Information..\..\src\common\sizer.cpp(381): assert "m_proportion==0" failed in wxSizerItem::InformFirstDirection(): Shaped item, non-zero proportion in wxSizerItem::InformFirstDirection()
TagsNo tags attached.

Relationships

related to 0002925 resolvedz64555 Assert "Assert failure" when opening certain editors 

Activities

z64555

2013-09-28 22:35

developer  

mantis_2926.patch (6,251 bytes)   
Index: wxFRED_base.cpp
===================================================================
--- wxFRED_base.cpp	(revision 9829)
+++ wxFRED_base.cpp	(working copy)
@@ -3250,7 +3250,7 @@
 	bSizer71 = new wxBoxSizer( wxVERTICAL );
 	
 	wxFlexGridSizer* fgSizer10;
-	fgSizer10 = new wxFlexGridSizer( 2, 3, 0, 0 );
+	fgSizer10 = new wxFlexGridSizer( 0, 3, 0, 0 );
 	fgSizer10->AddGrowableCol( 0 );
 	fgSizer10->AddGrowableCol( 1 );
 	fgSizer10->AddGrowableCol( 2 );
@@ -3368,7 +3368,7 @@
 	sbSizer212 = new wxStaticBoxSizer( new wxStaticBox( this, wxID_ANY, wxT("Multiplayer") ), wxVERTICAL );
 	
 	wxFlexGridSizer* fgSizer5;
-	fgSizer5 = new wxFlexGridSizer( 2, 2, 0, 0 );
+	fgSizer5 = new wxFlexGridSizer( 0, 2, 0, 0 );
 	fgSizer5->AddGrowableCol( 1 );
 	fgSizer5->SetFlexibleDirection( wxBOTH );
 	fgSizer5->SetNonFlexibleGrowMode( wxFLEX_GROWMODE_SPECIFIED );
@@ -3401,7 +3401,7 @@
 	sbSizer17 = new wxStaticBoxSizer( new wxStaticBox( this, wxID_ANY, wxT("Squadron Reassignment") ), wxVERTICAL );
 	
 	wxFlexGridSizer* fgSizer3;
-	fgSizer3 = new wxFlexGridSizer( 2, 2, 0, 0 );
+	fgSizer3 = new wxFlexGridSizer( 0, 2, 0, 0 );
 	fgSizer3->AddGrowableCol( 1 );
 	fgSizer3->SetFlexibleDirection( wxBOTH );
 	fgSizer3->SetNonFlexibleGrowMode( wxFLEX_GROWMODE_SPECIFIED );
@@ -3415,7 +3415,7 @@
 	fgSizer3->Add( txtSquadronName, 0, wxALL|wxEXPAND, 3 );
 	
 	btnSquadronLogo = new wxButton( this, wxID_ANY, wxT("Logo"), wxDefaultPosition, wxDefaultSize, wxBU_EXACTFIT );
-	fgSizer3->Add( btnSquadronLogo, 1, wxALIGN_LEFT|wxALL|wxEXPAND|wxSHAPED, 3 );
+	fgSizer3->Add( btnSquadronLogo, 1, wxALIGN_LEFT|wxALL|wxEXPAND, 3 );
 	
 	txtSquadronLogo = new wxTextCtrl( this, wxID_ANY, wxEmptyString, wxDefaultPosition, wxDefaultSize, 0 );
 	txtSquadronLogo->SetMaxLength( 0 ); 
@@ -3545,7 +3545,7 @@
 	sbSizer211 = new wxStaticBoxSizer( new wxStaticBox( this, wxID_ANY, wxT("Built-in Command Messages") ), wxVERTICAL );
 	
 	wxFlexGridSizer* fgSizer7;
-	fgSizer7 = new wxFlexGridSizer( 2, 2, 0, 0 );
+	fgSizer7 = new wxFlexGridSizer( 0, 2, 0, 0 );
 	fgSizer7->AddGrowableCol( 1 );
 	fgSizer7->SetFlexibleDirection( wxBOTH );
 	fgSizer7->SetNonFlexibleGrowMode( wxFLEX_GROWMODE_SPECIFIED );
@@ -3576,7 +3576,7 @@
 	sbSizer221 = new wxStaticBoxSizer( new wxStaticBox( this, wxID_ANY, wxT("Music and Sound") ), wxVERTICAL );
 	
 	wxFlexGridSizer* fgSizer8;
-	fgSizer8 = new wxFlexGridSizer( 2, 2, 0, 0 );
+	fgSizer8 = new wxFlexGridSizer( 0, 2, 0, 0 );
 	fgSizer8->AddGrowableCol( 1 );
 	fgSizer8->SetFlexibleDirection( wxBOTH );
 	fgSizer8->SetNonFlexibleGrowMode( wxFLEX_GROWMODE_SPECIFIED );
@@ -3627,7 +3627,7 @@
 	sbSizer231 = new wxStaticBoxSizer( new wxStaticBox( this, wxID_ANY, wxT("AI Options") ), wxHORIZONTAL );
 	
 	wxFlexGridSizer* fgSizer9;
-	fgSizer9 = new wxFlexGridSizer( 2, 2, 0, 0 );
+	fgSizer9 = new wxFlexGridSizer( 0, 2, 0, 0 );
 	fgSizer9->AddGrowableCol( 1 );
 	fgSizer9->SetFlexibleDirection( wxBOTH );
 	fgSizer9->SetNonFlexibleGrowMode( wxFLEX_GROWMODE_SPECIFIED );
@@ -3651,7 +3651,7 @@
 	sbSizer7 = new wxStaticBoxSizer( new wxStaticBox( this, wxID_ANY, wxT("Loading Screen") ), wxVERTICAL );
 	
 	wxFlexGridSizer* fgSizer4;
-	fgSizer4 = new wxFlexGridSizer( 2, 2, 0, 0 );
+	fgSizer4 = new wxFlexGridSizer( 0, 2, 0, 0 );
 	fgSizer4->AddGrowableCol( 1 );
 	fgSizer4->SetFlexibleDirection( wxBOTH );
 	fgSizer4->SetNonFlexibleGrowMode( wxFLEX_GROWMODE_SPECIFIED );
Index: wxFRED_base.xrc
===================================================================
--- wxFRED_base.xrc	(revision 9829)
+++ wxFRED_base.xrc	(working copy)
@@ -5634,7 +5634,7 @@
 				<flag>wxEXPAND</flag>
 				<border>5</border>
 				<object class="wxFlexGridSizer">
-					<rows>2</rows>
+					<rows>0</rows>
 					<cols>3</cols>
 					<vgap>0</vgap>
 					<hgap>0</hgap>
@@ -5848,7 +5848,7 @@
 										<flag>wxSHAPED</flag>
 										<border>0</border>
 										<object class="wxFlexGridSizer">
-											<rows>2</rows>
+											<rows>0</rows>
 											<cols>2</cols>
 											<vgap>0</vgap>
 											<hgap>0</hgap>
@@ -5912,7 +5912,7 @@
 										<flag>wxEXPAND</flag>
 										<border>0</border>
 										<object class="wxFlexGridSizer">
-											<rows>2</rows>
+											<rows>0</rows>
 											<cols>2</cols>
 											<vgap>0</vgap>
 											<hgap>0</hgap>
@@ -5939,7 +5939,7 @@
 											</object>
 											<object class="sizeritem">
 												<option>1</option>
-												<flag>wxALIGN_LEFT|wxALL|wxEXPAND|wxSHAPED</flag>
+												<flag>wxALIGN_LEFT|wxALL|wxEXPAND</flag>
 												<border>3</border>
 												<object class="wxButton" name="btnSquadronLogo">
 													<style>wxBU_EXACTFIT</style>
@@ -6175,7 +6175,7 @@
 										<flag>wxEXPAND</flag>
 										<border>5</border>
 										<object class="wxFlexGridSizer">
-											<rows>2</rows>
+											<rows>0</rows>
 											<cols>2</cols>
 											<vgap>0</vgap>
 											<hgap>0</hgap>
@@ -6233,7 +6233,7 @@
 										<flag>wxEXPAND</flag>
 										<border>5</border>
 										<object class="wxFlexGridSizer">
-											<rows>2</rows>
+											<rows>0</rows>
 											<cols>2</cols>
 											<vgap>0</vgap>
 											<hgap>0</hgap>
@@ -6343,7 +6343,7 @@
 										<flag>wxEXPAND</flag>
 										<border>5</border>
 										<object class="wxFlexGridSizer">
-											<rows>2</rows>
+											<rows>0</rows>
 											<cols>2</cols>
 											<vgap>0</vgap>
 											<hgap>0</hgap>
@@ -6383,7 +6383,7 @@
 										<flag>wxEXPAND</flag>
 										<border>0</border>
 										<object class="wxFlexGridSizer">
-											<rows>2</rows>
+											<rows>0</rows>
 											<cols>2</cols>
 											<vgap>0</vgap>
 											<hgap>0</hgap>
@@ -7654,7 +7654,7 @@
 											<object class="wxBitmapButton" name="btnPlayFailure">
 												<style>wxBU_AUTODRAW|wxBU_EXACTFIT</style>
 												<size>23,23</size>
-												<bitmap>C:\Code\FreespaceOpen\fs2_open\code\wxfred2\res\play.xpm</bitmap>
+												<bitmap>..\res\play.xpm</bitmap>
 												<default>0</default>
 											</object>
 										</object>
mantis_2926.patch (6,251 bytes)   

z64555

2013-09-28 22:37

developer   ~0015297

Patch added. Issue was due to an oversight in wxFormBuilder. It has a tendency to declare wxFlexGridSizers as having 2 rows and 2 columns, but allowing you to add as many rows and columns in editor without an error.

MjnMixael

2013-09-28 23:18

manager   ~0015299

Tested and it works.

z64555

2013-09-28 23:33

developer   ~0015302

Fix committed to trunk@9855.

Issue History

Date Modified Username Field Change
2013-09-28 21:53 MjnMixael New Issue
2013-09-28 21:53 MjnMixael Status new => assigned
2013-09-28 21:53 MjnMixael Assigned To => z64555
2013-09-28 22:35 z64555 File Added: mantis_2926.patch
2013-09-28 22:37 z64555 Note Added: 0015297
2013-09-28 22:37 z64555 Status assigned => code review
2013-09-28 22:49 z64555 Relationship added related to 0002925
2013-09-28 23:18 MjnMixael Note Added: 0015299
2013-09-28 23:33 z64555 Note Added: 0015302
2013-09-28 23:37 z64555 Status code review => resolved
2013-09-28 23:37 z64555 Resolution open => fixed