2019-10-19 12:09 EDT
All Projects | FSSCP: wxFRED

  

View Issue Details [ Jump to Notes ] [ Issue History ] [ Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0002902FSSCPHUDpublic2013-07-12 23:022016-03-20 17:14
Reporterkopachris 
Assigned To 
PrioritylowSeveritytweakReproducibilityhave not tried
StatusnewResolutionopen 
Product Version 
Target VersionFixed in Version 
Summary0002902: Player engine loop uses forward velocity for volume
DescriptionIn hud.cpp, update_throttle_sound() uses forward velocity to determine what volume the engine loop sound should play at in most cases. Now that we have the ability to use semi-Newtonian physics (as in e.g. Diaspora), we should always use forward thrust to determine engine volume. Otherwise, we end up with no engine volume even when the engine should be working at full thrust.
Additional InformationOrigin: http://www.hard-light.net/forums/index.php?topic=85028.msg1699748

I went ahead and made the change and have attached the patch.
TagsNo tags attached.
Attached Files
  • patch file icon fs2_use_thrust_for_snd.patch (918 bytes) 2013-07-12 23:02 - 
    Index: hud.cpp
===================================================================
--- hud.cpp	(revision 9729)
+++ hud.cpp	(working copy)
@@ -1886,15 +1886,9 @@
 	if ( timestamp_elapsed(throttle_sound_check_id) ) {
 
 		throttle_sound_check_id = timestamp(THROTTLE_SOUND_CHECK_INTERVAL);
-	
-		if ( object_get_gliding(Player_obj) ) {	// Backslash
-			percent_throttle = Player_obj->phys_info.forward_thrust;
-		} else if ( Ships[Player_obj->instance].current_max_speed == 0 ) {
-			percent_throttle = Player_obj->phys_info.fspeed / Ship_info[Ships[Player_obj->instance].ship_info_index].max_speed;
-		} else {
-			percent_throttle = Player_obj->phys_info.fspeed / Ships[Player_obj->instance].current_max_speed;
-		}
 
+		percent_throttle = Player_obj->phys_info.forward_thrust;
+
 		if ( percent_throttle != last_percent_throttle || Player_engine_snd_loop == -1 ) {
 
 			if ( percent_throttle < ZERO_PERCENT ) {
    patch file icon fs2_use_thrust_for_snd.patch (918 bytes) 2013-07-12 23:02 +

-Relationships
+Relationships

-Notes
There are no notes attached to this issue.
+Notes

-Issue History
Date Modified Username Field Change
2013-07-12 23:02 kopachris New Issue
2013-07-12 23:02 kopachris File Added: fs2_use_thrust_for_snd.patch
+Issue History