View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002893 | FSSCP | FRED | public | 2013-06-16 21:36 | 2013-06-23 08:44 |
| Reporter | FelixJim | Assigned To | Goober5000 | ||
| Priority | low | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 3.7.0 RC2 | ||||
| Summary | 0002893: Use of " and ; characters can corrupt mission files | ||||
| Description | The use of the " and ; characters in sexps at best cause the generation of extra (sometimes nonsense) arguments, and at worst cause the mission file to become unopenable by FRED; text editing is required to remove the offending characters before mission file is usable again. | ||||
| Steps To Reproduce | Create a show-subtitle-text sexp with the first argument '"' or ';'. Save mission file, observe how an extra argument has been inserted after the first. Create a script-eval sexp with the argument '"' or ';'. Save mission file, observe error, attempt to load mission file. Observe that this is impossible. | ||||
| Additional Information | I realise this has been around since retail and people have been surviving with it all this time, but I don't believe a simple slip should be able to render a mission file to become corrupted to the point you need to break out a text editor to fix it. | ||||
| Tags | No tags attached. | ||||
|
|
There are $quote and $semicolon tokens that will allow you to use these characters in sexps. There are functions to convert invalid characters to tokens automatically for briefings and debriefings, but supposedly this doesn't extend to sexps (and it would be worth checking if they extend to messages). I'll take a look. |
|
|
Fix committed to trunk@9698. |
|
|
Messages were already handled, but I fixed the sexp tokens. This should work for any sexp tree in any FRED UI dialog. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-06-16 21:36 | FelixJim | New Issue | |
| 2013-06-19 02:20 | Goober5000 | Note Added: 0015131 | |
| 2013-06-19 02:20 | Goober5000 | Assigned To | => Goober5000 |
| 2013-06-19 02:20 | Goober5000 | Status | new => assigned |
| 2013-06-23 08:43 | Goober5000 | Changeset attached | => fs2open trunk r9698 |
| 2013-06-23 08:43 | Goober5000 | Note Added: 0015143 | |
| 2013-06-23 08:43 | Goober5000 | Status | assigned => resolved |
| 2013-06-23 08:43 | Goober5000 | Resolution | open => fixed |
| 2013-06-23 08:44 | Goober5000 | Note Added: 0015144 |
