View Issue Details

IDProjectCategoryView StatusLast Update
0002849FSSCPuser interfacepublic2013-12-02 00:57
ReporterYarn Assigned ToYarn  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Platformx64OSWindows 7 
Product Version3.6.19 
Fixed in Version3.6.19 
Summary0002849: +Flags: does not select main halls [patch]
DescriptionThe patch that I submitted with 0002786 inadvertently prevented +Flags: from selecting main halls. The attached patch should fix this.
TagsNo tags attached.

Activities

Yarn

2013-04-23 00:24

developer  

mantis2849.patch (668 bytes)   
Index: code/mission/missioncampaign.cpp
===================================================================
--- code/mission/missioncampaign.cpp	(revision 9646)
+++ code/mission/missioncampaign.cpp	(working copy)
@@ -536,6 +536,7 @@
 			if (optional_string("+Flags:"))
 				stuff_int(&cm->flags);
 
+			cm->main_hall = "0";
 			// deal with previous campaign versions
 			if (cm->flags & CMISSION_FLAG_BASTION) {
 				cm->main_hall = "1";
@@ -543,7 +544,6 @@
 
 			// Goober5000 - new main hall stuff!
 			// Updated by CommanderDJ
-			cm->main_hall = "0";
 			if (optional_string("+Main Hall:")) {
 				stuff_string(temp, F_RAW, 32);
 				cm->main_hall = temp;
mantis2849.patch (668 bytes)   

FUBAR-BDHR

2013-04-27 06:43

developer   ~0014964

Fix committed to trunk@9650.

niffiwan

2013-12-02 00:57

developer   ~0015483

Crediting Yarn

Related Changesets

fs2open: trunk r9650

2013-04-27 03:35

FUBAR-BDHR


Ported: N/A

Details Diff
From Yarn fix for Mantis 2849 +Flags: does not select main halls Affected Issues
0002849
mod - /trunk/fs2_open/code/mission/missioncampaign.cpp Diff File

Issue History

Date Modified Username Field Change
2013-04-23 00:23 Yarn New Issue
2013-04-23 00:24 Yarn File Added: mantis2849.patch
2013-04-27 06:35 Echelon9 Status new => code review
2013-04-27 06:43 FUBAR-BDHR Changeset attached => fs2open trunk r9650
2013-04-27 06:43 FUBAR-BDHR Note Added: 0014964
2013-04-27 06:43 FUBAR-BDHR Status code review => resolved
2013-04-27 06:43 FUBAR-BDHR Resolution open => fixed
2013-12-02 00:57 niffiwan Assigned To => Yarn
2013-12-02 00:57 niffiwan Note Added: 0015483
2013-12-02 00:57 niffiwan Status resolved => feedback
2013-12-02 00:57 niffiwan Resolution fixed => reopened
2013-12-02 00:57 niffiwan Status feedback => resolved
2013-12-02 00:57 niffiwan Fixed in Version => 3.6.19
2013-12-02 00:57 niffiwan Resolution reopened => fixed