|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0002790||FSSCP||launcher||public||2013-02-07 19:28||2014-07-02 12:09|
|Target Version||3.7.2||Fixed in Version|
|Summary||0002790: Easy flags (flag sets for launcher) don't reflect current state of flags|
|Description||For example, flag set "all features on" doesn't include recent features like soft particles. I don't have the expertise to know what belongs under "high memory features".|
|Additional Information||Would like to see this fixed in next release (3.7?), since it should be pretty easy.|
|Tags||No tags attached.|
|Chief1983 can probably compile a list of the features and make sure the easy-flags list is up to date.|
Well, the reference for all command line options is always at http://www.hard-light.net/wiki/index.php/Command-Line_Reference
The launcher should of course always provide an up to date output of available flags as well, in case any are missing from the Wiki.
Also, that wiki page desperately needs an update since many flags behavior was toggled, with new flag names like -nospec, -noglow, etc.
I don't really feel any better qualified than the next person to decide if one feature or another belongs in a particular memory set as I'm not really knowledgeable about the implementation details of any new FSO features, so I'll be unassigning this from me, thanks.
|Ok fine maybe I will do this after all.|
Last edited: 2014-06-30 17:42
Ok, I've attached a patch that cleans up the ordering a bit, and toggles the memory and all options features on a bunch of the flags to make a bit more sense. Some flags' behaviors were toggled without adjusting their behavior with regards to the Easy options, these should all be addressed now. I haven't tested it but wanted to get this out in case I run out of time here before I head home. Also, I made a series of updates to the Command Line Reference on the wiki to correspond with some things I saw, please take a look at http://www.hard-light.net/wiki/index.php?title=Command-Line_Reference&action=history as well to see my changes.
One strange thing I noticed is that -no_fps_capping was not documented or in the Launcher checklist, yet it seems to be set up to function in the code, so I've added it to both.
Edit: Uploaded a new version just now that fixes a missing comma. Seems to compile and work now.
Ah, very good. :)
MjnMixael, can you test this to see if the flag lists reasonably make sense now?
The organization looks good.
'All Features On' doesn't include the various HUD and game-play features. Is there a reason for that? (scanning lines, target info, 3D models for selection, etc.) Would those same ones be used in 'High Memory Usage Features'?
I know some of them can be left to personal preference. (And I still really think many of those should be moved the game_settings and out of the commandline...) I'm thinking that new users would expect some of those. Maybe?
Last edited: 2014-07-01 09:43
The options in the HUD and Gameplay sections are much older, and since they were never added to the Easy flags in the past, I didn't see a reason to do it now. Most of the flag changes I've made are to flags that have been added or modified in the last few years, since the last time anyone apparently paid much attention to these. And yes, I also do believe they're more of a preference thing too. I probably should have left 3d shockwaves off with the All Options On since it's a highly debated 'improvement' too, but I think most of the other features that get turned on are universally agreed to be enhancements.
Actually 3d shockwaves isn't one I changed, so I've just left its behavior alone. I don't want to open a can of worms by messing with that particular one.
|Sounds good to me then.|
|Fix committed to trunk@10869.|
fs2open: trunk r10869
Timestamp: 2014-07-02 12:30:30
|Fix Mantis 0002790, Easy options should be just that again.|
|mod - /trunk/fs2_open/code/cmdline/cmdline.cpp|
|2013-02-07 19:28||jg18||New Issue|
|2014-06-29 23:20||Goober5000||Note Added: 0015952|
|2014-06-29 23:20||Goober5000||Assigned To||=> chief1983|
|2014-06-29 23:20||Goober5000||Status||new => assigned|
|2014-06-30 10:20||chief1983||Note Added: 0015966|
|2014-06-30 10:20||chief1983||Assigned To||chief1983 =>|
|2014-06-30 15:17||chief1983||Assigned To||=> chief1983|
|2014-06-30 15:17||chief1983||Note Added: 0015974|
|2014-06-30 17:12||chief1983||File Added: cmdline_cleanup.diff|
|2014-06-30 17:14||chief1983||Note Added: 0015976|
|2014-06-30 17:16||chief1983||Status||assigned => code review|
|2014-06-30 17:16||chief1983||Target Version||=> 3.7.2|
|2014-06-30 17:36||chief1983||File Deleted: cmdline_cleanup.diff|
|2014-06-30 17:42||chief1983||File Added: cmdline_cleanup.diff|
|2014-06-30 17:42||chief1983||Note Edited: 0015976||View Revisions|
|2014-06-30 22:07||Goober5000||Note Added: 0015989|
|2014-06-30 22:07||Goober5000||Assigned To||chief1983 => MjnMixael|
|2014-06-30 23:44||MjnMixael||Note Added: 0015995|
|2014-07-01 09:43||chief1983||Note Added: 0016001|
|2014-07-01 09:43||chief1983||Note Edited: 0016001||View Revisions|
|2014-07-01 12:53||chief1983||File Deleted: cmdline_cleanup.diff|
|2014-07-01 12:54||chief1983||File Added: cmdline_cleanup.diff|
|2014-07-02 00:23||MjnMixael||Note Added: 0016010|
|2014-07-02 11:52||chief1983||Assigned To||MjnMixael => chief1983|
|2014-07-02 11:52||chief1983||Status||code review => assigned|
|2014-07-02 12:09||chief1983||Changeset attached||=> fs2open trunk r10869|
|2014-07-02 12:09||chief1983||Note Added: 0016011|
|2014-07-02 12:09||chief1983||Status||assigned => resolved|
|2014-07-02 12:09||chief1983||Resolution||open => fixed|