All Projects FSSCP  wxFRED

View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0002773FSSCPFRED graphicspublic2013-01-08 08:012014-06-14 11:48
ReporterFUBAR-BDHR Assigned ToCommanderDJ  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Summary0002773: Models turn black when full nebula enabled in FRED
DescriptionTurning on full nebula in FRED causes all ships (or at least capital ships) to be either black or very dark. If you are very close (around 500m) an area in what appears to be a sphere will render normal textures but anything outside of that is still black Attaching screenshot.

Note this only appears to happen after you save the mission. Toggling full nebula on and off after the first save will show the results immediately. This might be a separate issue but I'm not sure.
Steps To ReproduceCreate a mission, drop in a couple of cap ships, turn on full nebula, save mission.
Additional Information3.6.15 r9490 so basically 3.6.16Rc1
TagsNo tags attached.

Activities

FUBAR-BDHR

2013-01-08 08:01

developer  

fullneb_fred.jpg (190,647 bytes)   
fullneb_fred.jpg (190,647 bytes)   

FUBAR-BDHR

2013-01-08 08:03

developer  

2773.fs2 (15,393 bytes)

FUBAR-BDHR

2013-01-12 23:01

developer   ~0014641

This seems to be an issue with -no_htl rendering. In neb.cpp neb2_post_level_init() at line 345 sets Neb2_render_mode = NEB2_RENDER_POF which uses the old spherec.pof file. Tried removing the Fred_running from the if statment so it would use NEB2_RENDER_POF which was slightly better. It resulted in a larger area where the models rendered correctly but they blued (I had the nebula set to nbackblue1) out then turned dark the farther you moved away. Reverted that and change the NEB2_RENDER_POF to NEB2_RENDER_LAME which is actually useable although probably not the best solution.

CommanderDJ

2013-02-17 14:17

developer   ~0014718

Even though I've been noticing this for ages, it never occurred to me to report it. :/

Anyway, patch attached. Plz to be testing.

FUBAR-BDHR

2013-02-18 03:03

developer   ~0014719

Just tried this and it results in something that looks like a full shine on the ship. Attaching screenshots with and without nebula enabled.

FUBAR-BDHR

2013-02-18 03:06

developer  

2773_neb_on.jpg (326,732 bytes)

FUBAR-BDHR

2013-02-18 03:06

developer  

2773_neb_off.jpg (310,615 bytes)

CommanderDJ

2013-02-18 14:40

developer   ~0014721

I'm having trouble reproducing your results, my ships look exactly the same regardless of whether a full nebula is enabled or not. Are the steps the same? (Ie what you've put down in "Steps to Reproduce"?)

FUBAR-BDHR

2013-02-18 19:27

developer   ~0014722

Yea same steps. The rendering doesn't actually change (at least the first time) until you save the mission.

CommanderDJ

2013-02-20 05:05

developer   ~0014726

Okay, I can't reproduce this at all. I'll try and refer another coder here to see if they can.

CommanderDJ

2014-06-09 08:08

developer  

2773.patch (868 bytes)    
Index: code/nebula/neb.cpp
===================================================================
--- code/nebula/neb.cpp	(revision 10788)
+++ code/nebula/neb.cpp	(working copy)
@@ -334,6 +334,13 @@
 		return;
 	}
 
+	// Skip actual rendering if we're in FRED.
+	if(Fred_running)
+	{
+		Neb2_render_mode = NEB2_RENDER_NONE;
+		return;
+	}
+
 	// if the mission is not a fullneb mission, skip
 	if ( !((The_mission.flags & MISSION_FLAG_FULLNEB) || Nebula_sexp_used) ) {
 		Neb2_render_mode = NEB2_RENDER_NONE;
@@ -341,7 +348,7 @@
 		return;
 	}
 
-	if ( (Cmdline_nohtl || Fred_running) && (The_mission.flags & MISSION_FLAG_FULLNEB) ) {
+	if ( (Cmdline_nohtl) && (The_mission.flags & MISSION_FLAG_FULLNEB) ) {
 		// by default we'll use pof rendering
 		Neb2_render_mode = NEB2_RENDER_POF;
 		stars_set_background_model(BACKGROUND_MODEL_FILENAME, Neb2_texture_name);
2773.patch (868 bytes)   

CommanderDJ

2014-06-09 08:09

developer   ~0015824

Patch updated to be compatible with latest trunk. As there hasn't been any activity on this for a long time, if there are no objections in the next couple days I'll commit the patch to trunk, since it does fix the issue.

CommanderDJ

2014-06-14 11:48

developer   ~0015870

Fix committed to trunk@10819.

Related Changesets

fs2open: trunk r10819

2014-06-14 08:06

CommanderDJ


Ported: N/A

Details Diff		 Fix Mantis 2773: Models turn black when full nebula enabled in FRED. Affected Issues
0002773
mod - /trunk/fs2_open/code/nebula/neb.cpp Diff File

Issue History

Date Modified Username Field Change
2013-01-08 08:01 FUBAR-BDHR New Issue
2013-01-08 08:01 FUBAR-BDHR File Added: fullneb_fred.jpg
2013-01-08 08:03 FUBAR-BDHR File Added: 2773.fs2
2013-01-12 23:01 FUBAR-BDHR Note Added: 0014641
2013-02-17 14:16 CommanderDJ File Added: 2773.patch
2013-02-17 14:17 CommanderDJ Note Added: 0014718
2013-02-17 14:17 CommanderDJ Assigned To => CommanderDJ
2013-02-17 14:17 CommanderDJ Status new => assigned
2013-02-18 00:23 CommanderDJ Status assigned => code review
2013-02-18 03:03 FUBAR-BDHR Note Added: 0014719
2013-02-18 03:06 FUBAR-BDHR File Added: 2773_neb_on.jpg
2013-02-18 03:06 FUBAR-BDHR File Added: 2773_neb_off.jpg
2013-02-18 14:40 CommanderDJ Note Added: 0014721
2013-02-18 14:40 CommanderDJ Status code review => assigned
2013-02-18 19:27 FUBAR-BDHR Note Added: 0014722
2013-02-20 05:05 CommanderDJ Note Added: 0014726
2014-06-09 08:07 CommanderDJ File Deleted: 2773.patch
2014-06-09 08:08 CommanderDJ File Added: 2773.patch
2014-06-09 08:09 CommanderDJ Note Added: 0015824
2014-06-09 08:10 CommanderDJ Status assigned => code review
2014-06-09 08:11 CommanderDJ Product Version 3.6.15 => 3.7.3
2014-06-14 11:48 CommanderDJ Changeset attached => fs2open trunk r10819
2014-06-14 11:48 CommanderDJ Note Added: 0015870
2014-06-14 11:48 CommanderDJ Status code review => resolved
2014-06-14 11:48 CommanderDJ Resolution open => fixed