|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0002699||FSSCP||Build system||public||2012-08-19 05:31||2012-08-21 06:19|
|Target Version||3.7.2||Fixed in Version||3.7.2|
|Summary||0002699: Replace deprecated hash_map on systems that support std::tr1::unordered_map|
|Description||As reported by ni1s on IRC:|
ni1s: phew, go_even_faster introduces quite the slew of new warnings on linux
[7:26pm] Echelon9: what are the most common one's?
[7:26pm] Echelon9: i.e. unused variables etc
[7:26pm] ni1s: the deprecated hash_map warning probably
[7:27pm] ni1s: /usr/lib/gcc/i686-pc-linux-gnu/4.6.3/include/g++-v4/backward/backward_warning.h:33:2: varning: #warning This file includes at least one deprecated or antiquated header which may be removed without further notice at a future date. Please use a non-deprecated interface with equivalent functionality instead. For a listing of replacement headers and interfaces, consult the file backward_warning.h. To disable this warning use -Wno-deprecated. [-Wcpp]
[7:29pm] Echelon9: what has hash_map been deprecated in favour of? something in Cx11?
[7:29pm] ni1s: std::tr1::unordered_map
[7:29pm] The_E: why would you deprecate hash_map at all?
[7:29pm] The_E: It's STL
[7:31pm] Echelon9: and if us utilise -Wno-deprecated to mask that warning, what is the next most common?
[7:31pm] Echelon9: (i'm trying to get a sense of materiality for the next most common additional warning)
[7:33pm] ni1s: patch for hash_map be here(with some refactoring) -> <see attached>
|Tags||No tags attached.|
|Committed in r9124, following code review on IRC with ni1s|
|I think there's a new compiler flag we need to add when using std::tr1::unordered_map, otherwise some versions of GCC won't compile (that's why I didn't suggest this change earlier). I'll investigate further and get back to you.|
Sorry - got confused with the use of:
The first is the one that needs a compile flag (CXXFLAGS=-std=c++0x), the second does not.
|2012-08-19 05:31||Echelon9||New Issue|
|2012-08-19 05:31||Echelon9||Status||new => assigned|
|2012-08-19 05:31||Echelon9||Assigned To||=> chief1983|
|2012-08-19 05:32||Echelon9||File Added: 41012.patch|
|2012-08-19 05:33||Echelon9||Status||assigned => code review|
|2012-08-19 09:41||ni1s||File Added: hash_map.svn.patch|
|2012-08-19 10:11||Echelon9||Note Added: 0013925|
|2012-08-19 10:11||Echelon9||Status||code review => resolved|
|2012-08-19 10:11||Echelon9||Resolution||open => fixed|
|2012-08-19 10:11||Echelon9||Assigned To||chief1983 => Echelon9|
|2012-08-19 18:21||niffiwan||Note Added: 0013926|
|2012-08-19 18:21||niffiwan||Status||resolved => feedback|
|2012-08-19 18:21||niffiwan||Resolution||fixed => reopened|
|2012-08-19 18:21||niffiwan||Status||feedback => code review|
|2012-08-21 06:19||niffiwan||Note Added: 0013929|
|2012-08-21 06:19||niffiwan||Status||code review => resolved|
|2012-08-21 06:19||niffiwan||Fixed in Version||=> 3.7.2|
|2012-08-21 06:19||niffiwan||Resolution||reopened => fixed|