View Issue Details [ Jump to Notes ] [ Related Changesets ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
---|---|---|---|---|---|---|---|---|---|
0002637 | FSSCP | speech | public | 2012-04-13 00:19 | 2012-11-19 19:37 | ||||
Reporter | gereedy | ||||||||
Assigned To | Goober5000 | ||||||||
Priority | low | Severity | minor | Reproducibility | always | ||||
Status | resolved | Resolution | fixed | ||||||
Product Version | |||||||||
Target Version | 3.7.2 | Fixed in Version | 3.7.2 | ||||||
Summary | 0002637: Briefing advances before synthesized speech finishes | ||||||||
Description | If synthesized speech is enabled briefing screens can advanced before the speech is finished. The attached patch corrects the issue. | ||||||||
Tags | No tags attached. | ||||||||
Attached Files |
|
![]() |
||||||
|
![]() |
|
iss_mneur (developer) 2012-05-19 23:46 Last edited: 2012-05-19 23:48 |
Damn, should really use the right browser tab.... This should wait until we have 3.6.14 out. |
Goober5000 (administrator) 2012-05-21 04:05 |
That patch doesn't really fix the issue; there are several other things that need to be handled in parallel. Also, you only changed the command briefing code, whereas the regular briefing code needed to be changed as well. But your patch did inspire me to fix the bug, so there's that. :) Fixed in revision 8811. |
Goober5000 (administrator) 2012-05-21 04:06 |
Addendum: this fix probably won't be applied to 3.6.14. This is because there are some differences in the briefing between 3.6.14 and trunk, namely a conversion to SCP_string. |
Goober5000 (administrator) 2012-05-21 04:23 |
Marking as resolved, derp. It has already been tested with both voiced and text-to-speech command briefings and briefings. |
![]() |
|||
fs2open: trunk r8811
Timestamp: 2012-05-21 04:05:18 Author: Goober5000 Ported: N/A [ Details ] [ Diff ] |
time the briefing stages appropriately for text-to-speech (Mantis 0002637) also, make the briefing speech timing, which is badly written, a little bit more like the command briefing, which is a bit better written |
||
mod - /trunk/fs2_open/code/missionui/redalert.cpp | [ Diff ] [ File ] | ||
mod - /trunk/fs2_open/code/missionui/missioncmdbrief.cpp | [ Diff ] [ File ] | ||
mod - /trunk/fs2_open/code/missionui/missionbrief.cpp | [ Diff ] [ File ] | ||
mod - /trunk/fs2_open/code/mission/missionbriefcommon.h | [ Diff ] [ File ] | ||
mod - /trunk/fs2_open/code/mission/missionbriefcommon.cpp | [ Diff ] [ File ] | ||
![]() |
|||
Date Modified | Username | Field | Change |
---|---|---|---|
2012-04-13 00:19 | gereedy | New Issue | |
2012-04-13 00:19 | gereedy | File Added: briefspeech.patch | |
2012-05-19 23:45 | iss_mneur | Priority | normal => low |
2012-05-19 23:45 | iss_mneur | Status | new => code review |
2012-05-19 23:45 | iss_mneur | Target Version | => 3.7.2 |
2012-05-19 23:45 | iss_mneur | Description Updated | View Revisions |
2012-05-19 23:46 | iss_mneur | Note Added: 0013569 | |
2012-05-19 23:46 | iss_mneur | Description Updated | View Revisions |
2012-05-19 23:48 | iss_mneur | Note Edited: 0013569 | View Revisions |
2012-05-21 04:03 | Goober5000 | Changeset attached | => fs2open trunk r8811 |
2012-05-21 04:05 | Goober5000 | Note Added: 0013592 | |
2012-05-21 04:05 | Goober5000 | Assigned To | => Goober5000 |
2012-05-21 04:05 | Goober5000 | Resolution | open => fixed |
2012-05-21 04:05 | Goober5000 | Fixed in Version | => 3.7.2 |
2012-05-21 04:06 | Goober5000 | Note Added: 0013593 | |
2012-05-21 04:23 | Goober5000 | Note Added: 0013594 | |
2012-05-21 04:23 | Goober5000 | Status | code review => resolved |
2012-11-19 19:37 | Goober5000 | Relationship added | related to 0001199 |