View Issue Details

IDProjectCategoryView StatusLast Update
0002607FSSCPFREDpublic2012-03-08 04:06
ReporterZacam Assigned ToCommanderDJ  
PriorityhighSeveritycrashReproducibilityalways
Status resolvedResolutionfixed 
Product Version3.6.13 
Summary0002607: Revision 8515 breaks -mod param passing to Fred2Open
DescriptionWhen launching via wxLauncher or a command Shortcut to load a "-mod <something>", Fred complains that it is unable to find "C:\Games\FreeSpace2\<something>".

(The <something> in this case being a proper Mod Folder name of any kind)
TagsNo tags attached.

Activities

iss_mneur

2012-02-19 21:29

developer   ~0013333

Based on my debugging of the issue it looks like the problem is MFC processes the commandline before FRED gets to it so MFC ignores the -mod and assumes that the text that follows must be a relative file path.

wxLauncher no longer passes the -mod line on the commandline when it starts FRED, but all released versions will continue to (so that they can continue to support FRED 3.6.10). wxLauncher 0.9.0 will not support 3.6.10 and will rely exclusively on cmdline_fso.cfg.

CommanderDJ

2012-02-20 00:55

developer   ~0013335

Just adding a note here for future reference. FRED's commandline parsing is done in fred_init() which is called only by CFREDView::OnCreate(). MFC's commandline parsing is what is used by rev 8515 to open the appropriate mission, and is done in CFREDApp::InitInstance(). I am as yet unsure of how to proceed, but will keep wroking at it. However, given that this is a high priority bug, if anyone else wants to take a stab at it they're more than welcome.

CommanderDJ

2012-03-04 12:55

developer   ~0013382

Hey guys,
I admit I haven't done any work on this - RL has kicked in and has prevented me from doing any SCP work, and it looks like that's going to continue in the immediate future. It seems to me that this isn't something we should just leave unfixed, so perhaps the best solution for now would be to simply revert 8515 until I or someone else can implement the feature without this problem?

Goober5000

2012-03-05 01:47

administrator   ~0013388

Reverting 8515 sounds like the best fix.

CommanderDJ

2012-03-06 13:33

developer   ~0013404

It's settled then. I don't have the necessary privileges, so I'll just leave it up to whoever decides to do it. If it's not done automatically I'll resolve the ticket once I see that 8515's been reverted.

Goober5000

2012-03-08 04:06

administrator   ~0013408

Resolving since CommanderDJ appears to be AFK. :p

Related Changesets

fs2open: trunk r8593

2012-03-06 21:50

Goober5000


Ported: N/A

Details Diff
revert 8515 per Mantis 0002607 Affected Issues
0002607
mod - /trunk/fs2_open/code/fred2/fred.cpp Diff File

Issue History

Date Modified Username Field Change
2012-02-19 05:07 Zacam New Issue
2012-02-19 05:07 Zacam Status new => assigned
2012-02-19 05:07 Zacam Assigned To => CommanderDJ
2012-02-19 21:29 iss_mneur Note Added: 0013333
2012-02-19 21:29 iss_mneur Reproducibility have not tried => always
2012-02-20 00:55 CommanderDJ Note Added: 0013335
2012-03-04 12:55 CommanderDJ Note Added: 0013382
2012-03-05 01:47 Goober5000 Note Added: 0013388
2012-03-06 13:33 CommanderDJ Note Added: 0013404
2012-03-07 02:49 Goober5000 Changeset attached => fs2open trunk r8593
2012-03-08 04:06 Goober5000 Note Added: 0013408
2012-03-08 04:06 Goober5000 Status assigned => resolved
2012-03-08 04:06 Goober5000 Resolution open => fixed