View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002596 | FSSCP | launcher | public | 2012-02-04 02:21 | 2012-11-26 05:33 |
| Reporter | Yarn | Assigned To | |||
| Priority | normal | Severity | text | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | x64 | OS | Windows 7 | ||
| Summary | 0002596: SampleRate registry value replaces "Enable EFX" if present | ||||
| Description | In the the Audio section, there is a check box labeled "Enable EFX." If a number is entered in the Sample Rate field, that number will replace the check box's label until the SampleRate registry key is deleted. | ||||
| Steps To Reproduce | 1. Open the Audio/Joystick tab in the launcher. 2. Enter a number into the Sample Rate field (e.g., 44100). (If you don't see it, make sure you have the most recent FSO build selected.) 3. Click OK to close the launcher and save your changes. 4. Open the launcher again and go back to the Audio/Joystick tab. 5. The number that you entered earlier will now be where the "Enable EFX" label should be. | ||||
| Additional Information | This happens with FSO Launcher 5.5g. | ||||
| Tags | No tags attached. | ||||
|
|
The problem is in line 442 in Launcher_5_5\TabSound.cpp. The coder wrote GetDlgItem(IDC_EFX)->SetWindowText(local_port_text); but presumably meant to write GetDlgItem(IDC_SAMPLE_RATE)->SetWindowText(local_port_text); Attached is a patch that makes the change. |
|
|
mantis_2596.patch (561 bytes)
Index: TabSound.cpp
===================================================================
--- TabSound.cpp (revision 8842)
+++ TabSound.cpp (working copy)
@@ -439,7 +439,7 @@
if ( reg_get_dword(snd_reg_path, "SampleRate", &sample_rate) == true ) {
sprintf(local_port_text, "%d", sample_rate);
- GetDlgItem(IDC_EFX)->SetWindowText(local_port_text);
+ GetDlgItem(IDC_SAMPLE_RATE)->SetWindowText(local_port_text);
}
} else if ( Settings::is_openal_build() ) {
reg_get_sz(Settings::reg_path, "SoundDeviceOAL", local_port_text, 256);
|
|
|
This looks like a simple fix - could a windows coder test & commit the patch from jg18? Alternatively, if wxlauncher is ready to replace the old launcher and we're going to stop supporting it, should we close this? |
|
|
This is not only simple, it's trivial. Fix committed in 9377. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-02-04 02:21 | Yarn | New Issue | |
| 2012-06-01 04:58 | jg18 | Note Added: 0013623 | |
| 2012-06-01 04:59 | jg18 | Note Edited: 0013623 | |
| 2012-06-01 05:00 | jg18 | File Added: mantis_2596.patch | |
| 2012-11-25 08:19 | niffiwan | Note Added: 0014181 | |
| 2012-11-25 08:19 | niffiwan | Assigned To | => niffiwan |
| 2012-11-25 08:19 | niffiwan | Status | new => code review |
| 2012-11-25 08:19 | niffiwan | Assigned To | niffiwan => |
| 2012-11-26 05:33 | Goober5000 | Note Added: 0014188 | |
| 2012-11-26 05:33 | Goober5000 | Status | code review => resolved |
| 2012-11-26 05:33 | Goober5000 | Resolution | open => fixed |
