View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002541 | FSSCP | gameplay | public | 2011-11-13 07:19 | 2011-11-20 02:50 |
| Reporter | Goober5000 | Assigned To | Echelon9 | ||
| Priority | high | Severity | crash | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 3.6.14 RC1 | ||||
| Target Version | 3.6.14 | Fixed in Version | 3.6.14 RC1 | ||
| Summary | 0002541: hide-jumpnode no longer works | ||||
| Description | Another bug caused by the jump_nodes refactoring... | ||||
| Tags | No tags attached. | ||||
|
|
Possibly resolved as of r8012. Please check. |
|
|
hide-jumpnode works unless it is currently being targetted by the player.. at which point FSO commits suicide. I've added a log from a crash and the mission I used to test the jump node sexps. |
|
2011-11-19 18:50
|
|
|
|
MjnMixael: Please try the attached patch. |
|
2011-11-19 19:20
|
Untarget jumpnode if targeted when hiding.patch (483 bytes)
Index: code/jumpnode/jumpnode.cpp
===================================================================
--- code/jumpnode/jumpnode.cpp (revision 8017)
+++ code/jumpnode/jumpnode.cpp (working copy)
@@ -151,9 +151,16 @@
void jump_node::show(bool enabled)
{
if(enabled)
+ {
m_flags&=~JN_HIDE;
+ }
else
+ {
+ // Untarget this node if it is already targeted
+ if ( Player_ai->target_objnum == m_objnum )
+ Player_ai->target_objnum = -1;
m_flags|=JN_HIDE;
+ }
}
/**
|
|
|
The patch seems to solve the issue here. |
|
|
Okay, committed as 8027 in trunk. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-11-13 07:19 | Goober5000 | New Issue | |
| 2011-11-13 07:19 | Goober5000 | Status | new => assigned |
| 2011-11-13 07:19 | Goober5000 | Assigned To | => Echelon9 |
| 2011-11-13 07:20 | Goober5000 | Relationship added | related to 0002528 |
| 2011-11-13 09:17 | Zacam | Target Version | => 3.6.14 |
| 2011-11-19 06:21 | Echelon9 | Note Added: 0012975 | |
| 2011-11-19 06:21 | Echelon9 | Status | assigned => feedback |
| 2011-11-19 18:50 | MjnMixael | Note Added: 0012978 | |
| 2011-11-19 18:50 | MjnMixael | File Added: jumpnodestuffs.zip | |
| 2011-11-19 19:19 | iss_mneur | Note Added: 0012980 | |
| 2011-11-19 19:19 | iss_mneur | Priority | normal => high |
| 2011-11-19 19:19 | iss_mneur | Severity | minor => crash |
| 2011-11-19 19:19 | iss_mneur | Reproducibility | have not tried => always |
| 2011-11-19 19:19 | iss_mneur | Status | feedback => confirmed |
| 2011-11-19 19:19 | iss_mneur | Product Version | => 3.6.14 RC1 |
| 2011-11-19 19:20 | iss_mneur | File Added: Untarget jumpnode if targeted when hiding.patch | |
| 2011-11-19 19:20 | iss_mneur | Note Edited: 0012980 | |
| 2011-11-19 19:38 | MjnMixael | Note Added: 0012981 | |
| 2011-11-19 23:17 | iss_mneur | Note Added: 0012982 | |
| 2011-11-19 23:17 | iss_mneur | Status | confirmed => feedback |
| 2011-11-19 23:17 | iss_mneur | Resolution | open => fixed |
| 2011-11-20 02:50 | Echelon9 | Status | feedback => resolved |
| 2011-11-20 02:50 | Echelon9 | Fixed in Version | => 3.6.14 RC1 |
