View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
---|---|---|---|---|---|---|---|---|---|
0002385 | FSSCP | tables | public | 2011-01-24 00:00 | 2011-02-04 12:19 | ||||
Reporter | FUBAR-BDHR | ||||||||
Assigned To | The_E | ||||||||
Priority | normal | Severity | feature | Reproducibility | always | ||||
Status | resolved | Resolution | fixed | ||||||
Product Version | 3.6.13 | ||||||||
Target Version | Fixed in Version | 3.6.13 | |||||||
Summary | 0002385: Animation code should be using subobject names not numbers | ||||||||
Description | This is kind of a feature and a bug so putting it here. The issue with using subobject numbers for the animation code is that they change. Something as simple as opening an older versions of a model in a newer version of pcs2 can result in different subobject numbers. Max constantly rearranges them. Even saving and reopening a model will often result in different subobject numbers on export. Of course we would need to keep the existing subobject number option for backward compatibility. Adding a +sub_name option would probably be the best. It would also allow for better error checking in the future as a deleted object would no longer be found. | ||||||||
Tags | No tags attached. | ||||||||
Attached Files |
|
![]() |
|
The_E (administrator) 2011-01-24 12:05 |
Proposed patch is attached. Adds "+sub_name" to the animation code, to be placed after or instead of "+sub_type". |
FUBAR-BDHR (developer) 2011-01-25 00:18 Last edited: 2011-01-25 01:02 |
Doesn't seem to work. I changed 5 turret doors to use +sub_name and while they do trigger to open they never stop rotating and never close. Left the rest on +sub_type and they still work. Found and fixed one bug. Line 71 in that patch should be if (!stricmp(sip->subsystems[i].subobj_name, subobj_name)) Even with that it seems that sip->subsystems[i].subobj_num is not defined yet as every single one has a value of 0xcccccccc |
The_E (administrator) 2011-01-25 13:04 |
Yeah, I was sort of afraid of that. Second patch uploaded, this one moves the fixing of animation references into ship_set, during mission load (which is where model data is mated with tbl data. Didn't want to slow down the init process by having to load the model during startup....) |
FUBAR-BDHR (developer) 2011-01-25 18:50 |
Looks good. |
The_E (administrator) 2011-02-04 12:19 |
Committed to trunk in revision 7000 |
![]() |
|||
Date Modified | Username | Field | Change |
---|---|---|---|
2011-01-24 00:00 | FUBAR-BDHR | New Issue | |
2011-01-24 12:04 | The_E | File Added: 2385.patch | |
2011-01-24 12:05 | The_E | Note Added: 0012611 | |
2011-01-25 00:18 | FUBAR-BDHR | Note Added: 0012612 | |
2011-01-25 01:02 | FUBAR-BDHR | Note Edited: 0012612 | |
2011-01-25 13:04 | The_E | Note Added: 0012613 | |
2011-01-25 13:11 | The_E | File Added: 2385-2.patch | |
2011-01-25 13:11 | The_E | Status | new => assigned |
2011-01-25 13:11 | The_E | Assigned To | => The_E |
2011-01-25 18:50 | FUBAR-BDHR | Note Added: 0012614 | |
2011-02-04 12:19 | The_E | Note Added: 0012623 | |
2011-02-04 12:19 | The_E | Status | assigned => resolved |
2011-02-04 12:19 | The_E | Fixed in Version | => 3.6.13 |
2011-02-04 12:19 | The_E | Resolution | open => fixed |