View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
---|---|---|---|---|---|---|---|---|---|
0002372 | FSSCP | tables | public | 2011-01-07 12:18 | 2012-11-19 10:25 | ||||
Reporter | Fury | ||||||||
Assigned To | The_E | ||||||||
Priority | normal | Severity | minor | Reproducibility | always | ||||
Status | resolved | Resolution | fixed | ||||||
Product Version | Antipodes 8 | ||||||||
Target Version | Fixed in Version | 3.6.13 | |||||||
Summary | 0002372: +Description broken in ships.tbl | ||||||||
Description | No idea if it has ever worked, but it's broken now. Example: $Name: GTF Myrmidon +nocreate +Description: XSTR(" insert bunch of text here ", -1 ) $end_multi_text Produces exactly jack squat on ship's loadout display. | ||||||||
Tags | No tags attached. | ||||||||
Attached Files |
|
![]() |
|
The_E (administrator) 2011-01-23 16:19 |
Fixed in revision 6969 |
FUBAR-BDHR (developer) 2011-01-29 18:45 |
Well this fix breaks multiplayer and the description is not like broke correctly resulting in a possible second assert for MAX_NUM_SHIP_DESC_LINES being exceeded. This one happens in both single and multi. Example: +Description: XSTR("test description", -1) $end_multi_text results in: test descr iption +Description: XSTR("A much longer test description of this ship to see what happens", -1) $end_multi_text results in the assert. I'll attach a diff that seems to work around the first multi problem. |
chief1983 (administrator) 2012-01-27 17:10 |
Apparently this patch was committed in 7002. Is there anything still broken mentioned in this ticket? |
Zacam (administrator) 2012-01-28 01:47 |
Tested with the above snippets. No Assert reached. The second +Description entry did lead to a bit of a text area over draw in the interface though: http://img713.imageshack.us/img713/7347/descriptiontest.png Additionally, when setting up for the second +Description test, I accidentally forgot to include the "$end_multi_text" which did not result in any pop-up warnings, but did lead to this easily missed entry in the log: "Error. Too much text (28553 chars, 4096 allowed) before $end_multi_text" Build test: Antipodes 8370 build. |
chief1983 (administrator) 2012-10-31 16:30 |
Closing then if no other complaints. |
Goober5000 (administrator) 2012-11-19 10:25 |
Resolving as it was apparently fixed by The E, twice. |
![]() |
|||
Date Modified | Username | Field | Change |
---|---|---|---|
2011-01-07 12:18 | Fury | New Issue | |
2011-01-23 16:19 | The_E | Note Added: 0012610 | |
2011-01-23 16:20 | The_E | Status | new => resolved |
2011-01-23 16:20 | The_E | Fixed in Version | => 3.6.13 |
2011-01-23 16:20 | The_E | Resolution | open => fixed |
2011-01-23 16:20 | The_E | Assigned To | => The_E |
2011-01-29 18:45 | FUBAR-BDHR | Note Added: 0012617 | |
2011-01-29 18:45 | FUBAR-BDHR | Status | resolved => feedback |
2011-01-29 18:45 | FUBAR-BDHR | Resolution | fixed => reopened |
2011-01-29 18:50 | FUBAR-BDHR | File Added: mantis_2372.patch | |
2012-01-27 17:10 | chief1983 | Note Added: 0013170 | |
2012-01-28 01:47 | Zacam | Note Added: 0013174 | |
2012-10-27 07:24 | The_E | Assigned To | The_E => |
2012-10-31 16:30 | chief1983 | Note Added: 0014008 | |
2012-11-19 10:25 | Goober5000 | Note Added: 0014077 | |
2012-11-19 10:25 | Goober5000 | Assigned To | => The_E |
2012-11-19 10:25 | Goober5000 | Status | feedback => resolved |
2012-11-19 10:25 | Goober5000 | Resolution | reopened => fixed |