View Issue Details

IDProjectCategoryView StatusLast Update
0002309FSSCPtablespublic2012-12-17 08:24
ReporterEsarai Assigned ToWanderer  
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Product Version3.6.13 
Summary0002309: $Corkscrew +Fire Delay fires too rapidly, and $Detonation Radius causes premature detonation when near friendly ships.
DescriptionI have a missile that's designed to use $Corkscrew so that it can be a swarm weapon that doesn't twist randomly. For some odd reason, when fired from a ship with multi-firepoint single-part launchers with modeled launch tubes, the +Fire Delay is way to short. Despite being defined as 3000 ms in the table, it appears to be around 300 ms or shorter. Then, on missiles designed this way that also have $Detonation Radius applied, they detonate inside the launch tubes, resulting in the annihilation of the launching ship. Whenever I remove $Detonation Radius, the missiles launch, but still have the absurdly short swarm delay.
Additional InformationI am using fs2_open_3_6_13d_INF_SSE-20100908_r6450.exe, with the 3.6.12 mediaVPs. The launcher flags I'm using are: -spec -glow -normal -img2dds -orbradar -rearm_timer -ballistic_gauge -ship_choice_3d -weapon_choice_3d -snd_preload -fps.

Removing flags and the mvps does not help.

Here's link to the log: http://pastebin.com/v6iqsp6r

Here's the quasi-modpack so you can see what's happening: http://www.mediafire.com/?w52tt3d1joas18k
TagsNo tags attached.

Activities

Wanderer

2010-09-25 20:33

developer   ~0012360

The download seems to have been deleted. Is it possible to re upload the data?

Esarai

2010-12-11 22:02

reporter   ~0012545

Last edited: 2010-12-12 03:42

Ooops sorry. Here's a link to the model file:
http://www.mediafire.com/?rdl31t6a752ujgm
And here's a table with some of the problematic entries:
http://www.mediafire.com/?0uixj9z7bra5nb0

I wanted to test the $Detonation Radius alone, so I didn't set the $Corkscrew back on. Now, when $Detonation Radius is set, the missiles just won't fire.

Esarai

2010-12-12 03:09

reporter   ~0012546

Last edited: 2010-12-12 05:24

And a test mission, a weapons table with missiles set to display the whole bug, and a ship table set to use those missiles:
Weapons: http://www.mediafire.com/?cbcbvo0vmqpdsl4
Ship: http://www.mediafire.com/?ctpde6t6k10d96d
Mission: http://www.mediafire.com/?pyq9a9c6cuhep5j

The_E

2010-12-12 06:28

administrator   ~0012547

Okay, the issue seems to be that the code for corkscrew missiles doesn't seem to work properly for corkscrewers fired from turrets.

Let me explain. In order to fire a corkscrew missile, the code has to go through cscrew_maybe_fire_missile() from corkscrew.cpp. In order to pass the tests found there, ship::num_corkscrew_to_fire has to be > 0. This variable is being set only in ship_fire_secondary(), which IIRC is never called for a secondary fired from a turret. (In addition, cscrew_maybe_fire_missile() assumes that the weapon will be fired from a secondary bank, not a turret, and will bail prematurely)

Wanderer

2011-04-23 12:18

developer   ~0012664

Ok. I committed fix for the odd delay of the turret launched corkscrew missiles in r7144

Wanderer

2011-04-23 14:11

developer   ~0012665

You can either use the minimum range setting to prevent turrets from firing at too close distance or then use free flight time to make sure missiles get far enough from the turret before exploding.

Wanderer

2011-12-04 08:21

developer   ~0012989

Is this still an issue?

Goober5000

2012-12-17 08:24

administrator   ~0014501

This was a pretty mediocre test mission, in that it took 5 minutes for anything to happen and 7:41 until I actually saw missiles launching out of the launch tubes. :doubt:

Nevertheless, it appears that the two problems described in the ticket are no longer present. So I'm calling this fixed per Wanderer's commit.

Issue History

Date Modified Username Field Change
2010-09-12 18:45 Esarai New Issue
2010-09-25 20:33 Wanderer Note Added: 0012360
2010-09-25 20:33 Wanderer Status new => assigned
2010-09-25 20:33 Wanderer Assigned To => Wanderer
2010-12-11 22:02 Esarai Note Added: 0012545
2010-12-11 22:04 Esarai Note Edited: 0012545
2010-12-12 03:09 Esarai Note Added: 0012546
2010-12-12 03:42 Esarai Note Edited: 0012545
2010-12-12 05:23 Esarai Note Edited: 0012546
2010-12-12 05:24 Esarai Note Edited: 0012546
2010-12-12 06:28 The_E Note Added: 0012547
2011-04-23 12:18 Wanderer Note Added: 0012664
2011-04-23 14:11 Wanderer Note Added: 0012665
2011-04-24 16:00 Wanderer Status assigned => feedback
2011-12-04 08:21 Wanderer Note Added: 0012989
2012-12-17 08:24 Goober5000 Note Added: 0014501
2012-12-17 08:24 Goober5000 Status feedback => resolved
2012-12-17 08:24 Goober5000 Resolution open => fixed