View Issue Details

IDProjectCategoryView StatusLast Update
0002222FSSCPmodelspublic2012-12-22 21:28
ReporterFUBAR-BDHR Assigned ToValathil  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionnot fixable 
Product Version3.6.12 RC2 
Summary0002222: Large ships collide without ever touching
DescriptionThis seems to have started somewhere between r5099 and r5149. Ships are now colliding and pushing each other without ever colliding. Sometimes even over 100 meters away from each other. You can even fly between the colliding ships, see the collision effect and here the sound as well.
Additional InformationTested with builds off of r5149 and a current trunk build with no modifications (r6198). First noticed in TBP where a passenger liners rotation was pushing a Nova down on it's Z axis while it was sitting still. Found in a Diaspora mission and just confirmed using retail data. Retail mission attached. Apparently this was not present in r5099 (didn't test myself but was told the bug did not happen with that build)
TagsNo tags attached.

Activities

2010-06-10 00:43

 

0collision.fs2 (6,061 bytes)

FUBAR-BDHR

2010-06-10 06:37

developer   ~0012055

OK seems I was lied to about it not existing in 6099. This goes back until at least 3.6.10 RC3. I do not remember it happening during Zathras development as the test mission I initially saw it on was specifically for testing ship engines. Pretty sure I would have seen a ship right in front of me moving down instead of forward. Unfortunately I no longer have that version of that mission. It's possible they were hitting and it just wasn't moving down.

2010-06-10 08:53

 

0collision2.fs2 (6,031 bytes)

Wanderer

2010-06-10 13:20

developer   ~0012056

I tried to follow this from the code side but couldn't really figure out what exactly was the problem. I sorta traced the problem into 'fvi_polyedge_sphereline' function in math/fvi.cpp in vertex check section.

Goober5000

2010-06-13 08:36

administrator   ~0012064

Are you able to narrow it down between revisions? That would probably be easier than narrowing it down code-wise.

Valathil

2012-12-13 23:04

developer   ~0014439

Both test missions have huge capital ships close together. THIS SHOULD NOT HAPPEN IN THIS ENGINE. The collision code isn't equipped to handle collisions of two things of similar size. The effects of that are magnified the bigger the two ships are so you don't see much problems with fighters but two capital ships this close is a big nono. I'm in favor of closing this, this issue would require a complete rewrite of the collision code. Why the "bug" emerged at a specific revision? Probably somebody fixed a real bug and that caused the proper behavior to show.

Goober5000

2012-12-14 16:46

administrator   ~0014456

There is one situation where two ships are that close: kamikaze. In FS1, in sm2-05, the Mauler (an Aten) collides with the Galatea (an Orion). And in FS2, in sm1-10, it is possible for the Colossus's beams to miss frequently enough for the Repulse to collide with it.

Valathil

2012-12-14 17:48

developer   ~0014458

Those are head on collisions which is a completely different matter cause collisions are pretty accurate in the engine when the bow of the smaller ship is on the sphere boundary of the collision bubble. What im talking about is close formation flight like in the test mission. If you had two borg spheres flying this close together the collisions would be perfect but cylindrical ships are a different thing and faulty collisions are to expected cause the engine is just not written to handle that.

Valathil

2012-12-22 21:28

developer   ~0014563

Without any objections it seems. Closing this bug as not fixable at least without a complete rewrite of the collision code.

Issue History

Date Modified Username Field Change
2010-06-10 00:43 FUBAR-BDHR New Issue
2010-06-10 00:43 FUBAR-BDHR File Added: 0collision.fs2
2010-06-10 06:37 FUBAR-BDHR Note Added: 0012055
2010-06-10 08:53 FUBAR-BDHR File Added: 0collision2.fs2
2010-06-10 13:20 Wanderer Note Added: 0012056
2010-06-13 08:36 Goober5000 Note Added: 0012064
2012-12-13 23:04 Valathil Note Added: 0014439
2012-12-14 16:46 Goober5000 Note Added: 0014456
2012-12-14 17:48 Valathil Note Added: 0014458
2012-12-22 21:28 Valathil Note Added: 0014563
2012-12-22 21:28 Valathil Status new => closed
2012-12-22 21:28 Valathil Assigned To => Valathil
2012-12-22 21:28 Valathil Resolution open => not fixable