View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||
ID | Project | Category | View Status | Date Submitted | Last Update | ||||
---|---|---|---|---|---|---|---|---|---|
0002004 | FSSCP | HUD | public | 2009-10-12 20:26 | 2012-04-03 09:15 | ||||
Reporter | FUBAR-BDHR | ||||||||
Assigned To | Echelon9 | ||||||||
Priority | low | Severity | minor | Reproducibility | always | ||||
Status | resolved | Resolution | fixed | ||||||
Product Version | 3.6.11 | ||||||||
Target Version | Fixed in Version | 3.6.14 | |||||||
Summary | 0002004: Training message buffer overrun can happen when using non forward view | ||||||||
Description | Basically the mission uses a repeating training message to display a distance. Works fine as long as you are looking forward. If you look say up the messages will cash and eventually the buffer (holds 40) will overload and assert. I believe I ran into a similar error with regular messages being used to display variables. Pretty sure that one was fixed. Training_message_queue_count is 40. Here's the call stack: fs2_open_3_6_11d.exe!debug_int3(char * file=0x00ddbcf4, int line=897) Line 760 C++ fs2_open_3_6_11d.exe!WinAssert(char * text=0x00e1b7c8, char * filename=0x00e1b5f6, int linenum=819) Line 897 + 0x13 bytes C++ > fs2_open_3_6_11d.exe!message_training_queue(char * text=0x069ef8c0, int timestamp=1, int length=-1) Line 819 + 0x21 bytes C++ fs2_open_3_6_11d.exe!sexp_send_training_message(int node=414) Line 11862 + 0x23 bytes C++ fs2_open_3_6_11d.exe!eval_sexp(int cur_node=413, int referenced_node=-1) Line 17063 + 0x9 bytes C++ fs2_open_3_6_11d.exe!eval_when(int n=412, int use_arguments=0) Line 7003 + 0xb bytes C++ fs2_open_3_6_11d.exe!eval_sexp(int cur_node=408, int referenced_node=-1) Line 16404 + 0x16 bytes C++ fs2_open_3_6_11d.exe!mission_process_event(int event=13) Line 913 + 0xb bytes C++ fs2_open_3_6_11d.exe!mission_eval_goals() Line 1062 + 0x9 bytes C++ fs2_open_3_6_11d.exe!game_simulation_frame() Line 4269 C++ fs2_open_3_6_11d.exe!game_frame(int paused=0) Line 4686 C++ fs2_open_3_6_11d.exe!game_do_frame() Line 5114 + 0x7 bytes C++ fs2_open_3_6_11d.exe!game_do_state(int state=2) Line 6885 C++ fs2_open_3_6_11d.exe!gameseq_process_events() Line 405 + 0x14 bytes C++ fs2_open_3_6_11d.exe!game_main(char * cmdline=0x00152326) Line 7446 + 0x5 bytes C++ fs2_open_3_6_11d.exe!WinMain(HINSTANCE__ * hInst=0x00400000, HINSTANCE__ * hPrev=0x00000000, char * szCmdLine=0x00152326, int nCmdShow=10) Line 7522 + 0x9 bytes C++ fs2_open_3_6_11d.exe!__tmainCRTStartup() Line 263 + 0x2c bytes C fs2_open_3_6_11d.exe!WinMainCRTStartup() Line 182 C kernel32.dll!7c817077() [Frames below may be incorrect and/or missing, no symbols loaded for kernel32.dll] fs2_open_3_6_11d.exe!game_show_framerate() Line 2451 + 0xe bytes C++ | ||||||||
Additional Information | 3.6.11 r5618. Should be easy to reproduce in FS2. Just to an ever-time with a training message and switch to a different view. | ||||||||
Tags | No tags attached. | ||||||||
Attached Files |
|
![]() |
|
FUBAR-BDHR (developer) 2009-10-12 20:51 |
5426 was the commit where the standard messages were made dynamic to fix the similar problem with those. |
Echelon9 (developer) 2010-01-02 06:17 |
Patch provided; peer code review in progress before I commit this to SVN. |
Echelon9 (developer) 2010-01-02 08:33 |
Committed in revision 5761. |
Echelon9 (developer) 2010-01-16 23:12 |
Fix will require further testing & modification to be stable enough to commit to trunk |
The_E (administrator) 2012-01-22 08:42 |
Is this still current? I thought it was fixed already? |
Echelon9 (developer) 2012-01-22 14:45 |
The original fix was backed out of trunk due to related problems. But then recently I've been unable to trigger the bug anymore, which is odd. I'm leaving open for an abundance of caution |
![]() |
|||
Date Modified | Username | Field | Change |
---|---|---|---|
2009-10-12 20:26 | FUBAR-BDHR | New Issue | |
2009-10-12 20:51 | FUBAR-BDHR | Note Added: 0011211 | |
2010-01-02 05:45 | Echelon9 | Status | new => assigned |
2010-01-02 05:45 | Echelon9 | Assigned To | => Echelon9 |
2010-01-02 06:17 | Echelon9 | File Added: dynamics_training_message_queue2.patch | |
2010-01-02 06:17 | Echelon9 | Note Added: 0011481 | |
2010-01-02 06:17 | Echelon9 | Status | assigned => feedback |
2010-01-02 08:33 | Echelon9 | Note Added: 0011482 | |
2010-01-02 08:33 | Echelon9 | Status | feedback => resolved |
2010-01-02 08:33 | Echelon9 | Fixed in Version | => 3.6.11 |
2010-01-02 08:33 | Echelon9 | Resolution | open => fixed |
2010-01-16 23:12 | Echelon9 | Note Added: 0011529 | |
2010-01-16 23:12 | Echelon9 | Status | resolved => feedback |
2010-01-16 23:12 | Echelon9 | Resolution | fixed => reopened |
2010-12-10 23:31 | The_E | Category | gameplay => HUD |
2012-01-22 07:21 | Echelon9 | Priority | normal => low |
2012-01-22 07:21 | Echelon9 | Fixed in Version | 3.6.11 => 3.6.14 |
2012-01-22 08:42 | The_E | Note Added: 0013111 | |
2012-01-22 14:45 | Echelon9 | Note Added: 0013112 | |
2012-04-03 09:15 | Echelon9 | Status | feedback => resolved |
2012-04-03 09:15 | Echelon9 | Resolution | reopened => fixed |