0001863: Ships with arrival cue true and delay don't arrive on standalone - Source Code Project Mantis

All Projects FSSCP wxFRED

ID	Project	Category	View Status	Date Submitted	Last Update

0001863	FSSCP	multiplayer	public	2009-01-06 00:14	2013-05-31 08:11

Reporter	FUBAR-BDHR	Assigned To	karajorma
Priority	normal	Severity	minor	Reproducibility	always
Status	resolved	Resolution	fixed
Product Version	3.6.9

Summary	0001863: Ships with arrival cue true and delay don't arrive on standalone
Description	Another one of those retail bugs. If you play RI (M-04b.fs2) on a standalone the caps do not show up. The first one's arrival is set to true with a delay of 34 seconds. I've never seen this in any other mission but then again how many multiplayer missions use arrival true with a delay for the cue?
Additional Information	3.6.10 r5032 but it's been there since retail. Screenshot shows the log of the second wave of fighters arriving well past the arrival time of the caps but no caps.
Tags	No tags attached.

2009-01-06 00:14	screen0035.jpg (33,494 bytes) screen0035.jpg (33,494 bytes)

Galemp 2009-03-07 09:00 reporter ~0010718	This happens in FSPort, too. Mission stmm-04, On the Run, has the same problems. This was verified in testing.

karajorma 2009-03-10 12:10 administrator ~0010727	In tests I found that a ship set to arrive with a 10 second delay was arriving somewhere around 33 seconds after the mission started. It could be that the ships in the other missions would eventually arrive too but by that time everyone has already jumped out. I can't see any immediate reason why this is occurring. The delay does appear to be parsed correctly but by the time it is used it has been changed. Trying to breakpoint the change left me stuck in disassembly so I suspect that it isn't a deliberate change.

karajorma 2013-04-30 05:22 administrator	Mantis_1863.patch (474 bytes) Index: code/freespace2/freespace.cpp =================================================================== --- code/freespace2/freespace.cpp (revision 9660) +++ code/freespace2/freespace.cpp (working copy) @@ -982,9 +982,7 @@ batch_reset(); // Initialize the game subsystems - if(!Is_standalone){ - game_reset_time(); // resets time, and resets saved time too - } + game_reset_time(); // resets time, and resets saved time too Multi_ping_timestamp = -1; Mantis_1863.patch (474 bytes)

karajorma 2013-04-30 05:25 administrator ~0014988	This patch fixes the issue for me. Turns out that the issue was simply that the timer wasn't being reset for the standalone on mission init. What's bugging me is that I can't figure out why Volition didn't want the server timer reset (Especially since they reset it a little later when starting the mission anyway).

FUBAR-BDHR 2013-04-30 15:11 developer ~0015001	Wonder if that could be the cause of 1815 as well?

karajorma 2013-05-01 18:22 administrator ~0015015	Hmmmmm. If the initial order involves any kind of timestamp, yes it's quite probably the cause. The ship wouldn't do anything until the timestamp expires.

karajorma 2013-05-31 08:11 administrator ~0015100	Fix committed to trunk@9683.

Date Modified	Username	Field	Change
2009-01-06 00:14	FUBAR-BDHR	New Issue
2009-01-06 00:14	FUBAR-BDHR	File Added: screen0035.jpg
2009-03-07 09:00	Galemp	Note Added: 0010718
2009-03-08 00:33	chief1983	Summary	Capital ships don't arrive in RI on a standalone => Ships with arrival cue true and delay don't arrive on standalone
2009-03-10 12:10	karajorma	Note Added: 0010727
2012-12-30 15:49	karajorma	Assigned To	=> karajorma
2012-12-30 15:49	karajorma	Status	new => assigned
2013-04-30 05:22	karajorma	File Added: Mantis_1863.patch
2013-04-30 05:25	karajorma	Note Added: 0014988
2013-04-30 10:46	Echelon9	Status	assigned => code review
2013-04-30 15:11	FUBAR-BDHR	Note Added: 0015001
2013-05-01 18:22	karajorma	Note Added: 0015015
2013-05-02 06:01	karajorma	Relationship added	related to 0001815
2013-05-31 08:11	karajorma	Changeset attached	=> fs2open trunk r9683
2013-05-31 08:11	karajorma	Note Added: 0015100
2013-05-31 08:11	karajorma	Status	code review => resolved
2013-05-31 08:11	karajorma	Resolution	open => fixed