View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0001826 | FSSCP | multiplayer | public | 2008-11-20 21:27 | 2020-11-01 15:10 |
Reporter | FUBAR-BDHR | Assigned To | FSCyborg | ||
Priority | low | Severity | text | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Product Version | 3.6.9 | ||||
Summary | 0001826: Switching to campaign mode doesn't update mission description | ||||
Description | If you switch to campaign mode and there is a non coop mission selected the description will not update to the coop missions in the campaign. | ||||
Additional Information | 3.6.10 11/09 build. Screenshot coming soon. | ||||
Tags | No tags attached. | ||||
2008-11-20 23:11
|
|
|
Was in a bit of a hurry when I posted (hosting) and forgot to mention the host side updates find so it's a client side only thing. |
|
I've started looking at this issue, and I would like to see if I can try to solve it since it's sufficiently minor and would be a good project for me as I continue to try to understand the code and C++ better. Problem still occurs in the most recent nightly. I'm able to test it on one computer by forcing different ports on multiple instances of the launcher for the same build. |
|
Update on my progress: This feature was never implemented into the engine, probably because it was not that useful a feature, and (I think) requires a new function or edits to an existing function. The logic for requesting the description is in place, but the function was not written in because the function is only able to send information on the current mission. I'm still game for trying it for now. I might jump on IRC for assistance. |
|
I think I got it! I have the description field updating for campaign files. Only the host's exe needs to be updated as well, actually. The only issues might be with how I accomplished it. The Netgame_Info class has two new entries which aren't carried by the function which used to send the whole class. One of the entries is an int, acting as a boolean, which will tell you if the host is trying to select campaign or non-campaign games. So, a *little* disorganized, but I added good comments. You guys may want me to rearrange it to be a little cleaner. Like with a new class or something. And now I'm in the odd position of not knowing how to post a patch file to share the proposed fix with. Would anyone be able to send me in the right direction? Should I just get on Github and try from there or should I try posting a patch here? |
|
Pull request has been added to GIT. :) |
|
File was too large to upload directly. So I have a mediafire link: http://www.mediafire.com/download/xncrt05fvgmlfkd/fs2_open_3_7_3_AVXMANTIS1826CANDIDATE.7z |
|
A github link would be nice to have. :p Searching git yields four PRs, all closed: https://github.com/scp-fs2open/fs2open.github.com/pull/122 https://github.com/scp-fs2open/fs2open.github.com/pull/189 https://github.com/scp-fs2open/fs2open.github.com/pull/190 https://github.com/scp-fs2open/fs2open.github.com/pull/191 Has there been any progress on a new PR? |
|
Just in case anyone is wondering, I am finally going to get this out the door. I am starting to rework this PR tonight: https://github.com/scp-fs2open/fs2open.github.com/pull/2109 . I just need to adjust for Taylor's feedback, but I'll have to submit it to his packet fixes branch so that we don't have to create another multi bump. |
|
Taylor and I finally tag-teamed this. Fix is in a pr that is pretty close to being merged. |
Date Modified | Username | Field | Change |
---|---|---|---|
2008-11-20 21:27 | FUBAR-BDHR | New Issue | |
2008-11-20 23:11 | FUBAR-BDHR | File Added: campaign.jpg | |
2008-11-20 23:27 | FUBAR-BDHR | Note Added: 0010244 | |
2012-01-22 07:03 | Echelon9 | Priority | normal => low |
2012-01-22 07:03 | Echelon9 | Summary | Switching to campaing mode doesn't update mission description => Switching to campaign mode doesn't update mission description |
2015-05-09 17:31 | Cyborg17 | Note Added: 0016700 | |
2015-05-09 17:32 | Cyborg17 | Note Edited: 0016700 | |
2015-05-15 17:58 | Cyborg17 | Note Added: 0016705 | |
2015-05-20 07:16 | Cyborg17 | Note Added: 0016712 | |
2015-05-21 00:26 | Cyborg17 | Note Added: 0016714 | |
2015-06-01 02:28 | Cyborg17 | Note Added: 0016745 | |
2015-12-19 23:04 | Goober5000 | Note Added: 0016804 | |
2015-12-19 23:05 | Goober5000 | Note Edited: 0016804 | |
2020-07-18 04:42 | FSCyborg | Note Added: 0017008 | |
2020-07-18 04:43 | FSCyborg | Status | new => code review |
2020-07-24 19:14 | FSCyborg | Assigned To | => FSCyborg |
2020-11-01 15:10 | FSCyborg | Status | code review => closed |
2020-11-01 15:10 | FSCyborg | Resolution | open => fixed |
2020-11-01 15:10 | FSCyborg | Note Added: 0017027 |