|View Issue Details|
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0001681||FSSCP||FRED||public||2008-05-01 07:41||2012-07-01 21:09|
|Target Version||Fixed in Version|
|Summary||0001681: Restrict arrival paths doesn't work when multiple ships selected|
|Description||I just went through setting arrival locations and restricting arrival paths for 66 ships. I selected 6 at a time and set the arrival locations and restricted the paths. Going back through to set arrival cues I looked and while the locations were updated the restrictions were not. Event ships that originally had path restrictions had them turned off after the editing.|
|Additional Information||TBP version of FRED 3.6.9 dated 3/30/08. Probably something similar to report http://scp.indiegames.us/mantis/view.php?id=1634|
|Tags||No tags attached.|
The problem here is that the dialog takes no account whatsoever of multiple selections. In fact it's actually doing this at one stage
dlg.m_path_mask = &Ships[marked_ship].arrival_path_mask;
And the value of marked_ship is -1.
Fixing that bug by disabling restricted paths when using multi_edit is easy. Fixing the actual problem would require a rather heavy rewrite of the entire dialog (especially if you wanted to support tri-state switches for when you had a group of ships selected which had different selected paths).
I don't know what Goober wants to do about this but that nasty out of bounds error really should be corrected immediately.
Considering that most of the time multiple ships are not going to share the same paths, I restricted the dialog to only open for editing single ships.
Fixed in revision 8812.
fs2open: trunk r8812
Timestamp: 2012-05-22 02:43:38
|restrict multi-editing for Mantis 0001681|
|mod - /trunk/fs2_open/code/fred2/shipeditordlg.cpp|
fs2open: fs2_open_3_6_14 r8944
Timestamp: 2012-07-01 21:10:30
|Backport: Trunk r8812; restrict multi-editing for Mantis 0001681|
|mod - /branches/fs2_open_3_6_14/code/fred2/shipeditordlg.cpp|
|2008-05-01 07:41||FUBAR-BDHR||New Issue|
|2008-05-09 03:18||Goober5000||Status||new => assigned|
|2008-05-09 03:18||Goober5000||Assigned To||=> Goober5000|
|2009-04-24 13:37||karajorma||Note Added: 0010840|
|2012-05-22 02:41||Goober5000||Changeset attached||=> fs2open trunk r8812|
|2012-05-22 02:43||Goober5000||Note Added: 0013603|
|2012-05-22 02:43||Goober5000||Status||assigned => resolved|
|2012-05-22 02:43||Goober5000||Resolution||open => fixed|
|2012-07-01 21:09||Zacam||Changeset attached||=> fs2open fs2_open_3_6_14 r8944|