View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001679 | FSSCP | graphics | public | 2008-04-29 22:05 | 2008-07-30 21:44 |
| Reporter | ARSPR | Assigned To | phreak | ||
| Priority | normal | Severity | major | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Platform | DELL Dimension 9200 | OS | Windows Vista | OS Version | Ultimate 32-bit |
| Product Version | 3.6.9 | ||||
| Summary | 0001679: Game runs at 1024 x 768 despite the selected resolution in Launcher | ||||
| Description | The Summary is the problem. (Vista 32-bit + 8800 GTX + ForceWare 175.12) | ||||
| Steps To Reproduce | In order to see it, if you have a LCD monitor: + Disable drivers resolution scale + Disable LCD built-in resolution scale Or you can be fooled by your own system ;-) | ||||
| Tags | No tags attached. | ||||
|
|
Ooops, I nearly forgot: 20080403 SVN build compiled by Taylor doesn't suffer the issue. |
|
|
A fast test with SVN 4618 from Chief: It suffers the issue :( |
|
|
Chief builds seem defective. Other people builds don't suffer this issue. Example: + 2008-05-23. Karajorma's build, ( http://www.hard-light.net/forums/index.php/topic,53978.0.html ), works fine + 2008-05-25. Chief's build, ( http://www.hard-light.net/forums/index.php/topic,54018.0.html ), only runs at 1024x768. + 2008-05-25. WMC's build, ( http://www.hard-light.net/forums/index.php/topic,54045.0.html ), works fine again. So, although I'm no expert, it seems a compiling issue rather than a code one. |
|
|
I'll have to say, I don't suffer the issue with my builds. They run in the resolution I tell them to, as far as I can tell. I'm compiling with VS 2008 Pro, running my builds on Windows XP 32bit, with a GeForce 8800 GTS 512, and the 172.xx drivers. I'm going to upgrade to the newer 175.xx soon though. I'll see if that changes my experience. Has anyone else noticed this behavior with my builds? |
|
|
Yup, upgraded to the 175.16 drivers, still no issue for me. So, I'm not sure where this is stemming from exactly. I have a feeling it's beyond anything I can take care of on my own, but if another coder experienced with VS 2008 Pro would like to help me, that'd probably be useful. |
|
|
Ok, SeanP did some more testing for me. Not only is it failing to obey the resolution, it's also ignoring other registry settings. When going to multiplayer, it complains that the preference of LAN vs Dial-Up, etc, hasn't been chosen yet. So, it appears that my builds for some reason will not read the registry on Vista. I'm looking into this more now, but if this made any light bulbs go off for anyone, please let me know. |
|
|
Apparently on SeanP's setup, running the launcher in Admin mode, applying the configuration, and then running the game worked. After that the launcher could be run with normal privileges and the settings were maintained, although I'm not sure if they can be changed after that. I have no idea why this only seems to be an issue with my builds, and as soon as I have Vista installed I'll be doing my own checking on this. |
|
|
After further research, the Launcher will need to write to HKEY_CURRENT_USER instead of HKEY_LOCAL_MACHINE in order to be able to save the settings in the registry when running on non-Administrator accounts using Windows Vista. The game will also need to be changed to read from HKEY_CURRENT_USER as well. |
|
|
In that case it just needs to be changed to use the ini file instead of the registry. |
|
|
@phreak: I don't know anything about coding so maybe this comment is nonsense, but I don't understand what Launcher has to do with this bug. In the way Launcher works right now, *ALL* the builds work fine but chief ones. So, whereever Launcher is saving the data, only chief build can't access them. Then I suppose the problem is in chief builds not in any other place (although there could be other masked side bugs). |
|
|
It's because chief compiles with Vista, and if you're compiling on Vista it inserts the User Access Control module that causes this to happen. Also, the launcher would need to save the INI file to C:\Documents and Settings\Username\My Games\Freespace2 Open\ because non-admins will not be able to write to any other folder than that one. |
|
|
Actually it was compiled on XP, and I'm just as confused as to how it seems only my builds are affected. From what I can tell, the explanations make sense, but then it almost sounds like that implies there is a bug in _everyone_ else's builds that allows them to pull these registry settings from the ether, as they shouldn't be able to read from HKEY_LOCAL_MACHINE. But that can't be, can it? |
|
|
or it may be a Visual Studio 2008 thing. Are we the only two people using it? |
|
|
Could be. I noticed it has a UAC option in the build config, it's been enabled for me. I might try disabling it and seeing if that changes anything. I don't think a lot of people have upgraded yet though, so we may be the only ones right now, and I guess I'd be the only one putting out VS2008 builds based on those settings. |
|
|
I've just briefly tested latest build from Chief (http://www.hard-light.net/forums/index.php/topic,55190.0.html) and the problem seem gone. Good hunt on UAC!!! I think you can close this issue. |
|
|
Well, disabling UAC is a temporary fix. Longterm would be modifying where FS stores its keys, from LOCAL_MACHINE to CURRENT_USER, or even better, no more registry at all. However I do think that UAC should be disabled in the 2008 project file for the time being until this problem can be completely rectified. As that change hasn't been committed, I'd hesitate to close this until the project file is updated in SVN. |
|
|
Are you able to commit your project file or do I need to commit it? |
|
|
I don't have commit access, so probably better if you did it. |
|
|
ok, committed. You will need to see if I did it right. I think the settings are set in the freespace2 and fred2 projects, properties->linker->manifest. |
|
|
It seems to be taken care of in Release-SSE2, but not for Debug, Release, or Release-SSE. It's essentially in 8 places now I think, with the addition of those profiles. 4 build types * 2 projects. I'm attaching a patch, which I think takes care of all the necessary options, should have done this in the first place I guess. Although I'd have forgotten the SSE builds then as I don't use them right now. The patch also renames the output executables for the VS2008 project to 3.6.10, as they probably should be now. If you don't think so, go ahead and rip those out of the patch before you apply it. |
|
2008-07-28 21:27
|
VS2008_UAC_EXE_Fix.patch (6,602 bytes)
Index: Fred2.vcproj =================================================================== --- Fred2.vcproj (revision 4723) +++ Fred2.vcproj (working copy) @@ -83,10 +83,11 @@ <Tool Name="VCLinkerTool" AdditionalDependencies="DxErr8.lib d3d8.lib d3dx8.lib kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib wsock32.lib winmm.lib vfw32.lib msacm32.lib comctl32.lib openal32.lib ogg_static.lib vorbis_static.lib vorbisfile_static.lib theora_static.lib code.lib" - OutputFile="$(OutDir)\fred2_open_3_6_9d.exe" + OutputFile="$(OutDir)\fred2_open_3_6_10d.exe" LinkIncremental="2" SuppressStartupBanner="true" AdditionalLibraryDirectories="$(ConfigurationName),../../oggvorbis/lib,../../dx8sdk/lib,../../openal/libs/win32,../../openal/libs/win64" + EnableUAC="false" IgnoreDefaultLibraryNames="libc.lib,libcd.lib,libcmt.lib,libci.lib" GenerateDebugInformation="true" ProgramDatabaseFile="$(TargetDir)$(TargetName).pdb" @@ -196,10 +197,11 @@ <Tool Name="VCLinkerTool" AdditionalDependencies="DxErr8.lib d3d8.lib d3dx8.lib wsock32.lib winmm.lib msacm32.lib vfw32.lib comctl32.lib openal32.lib ogg_static.lib vorbis_static.lib vorbisfile_static.lib theora_static.lib code.lib" - OutputFile="$(OutDir)\fred2_open_3_6_9r.exe" + OutputFile="$(OutDir)\fred2_open_3_6_10r.exe" LinkIncremental="1" SuppressStartupBanner="true" AdditionalLibraryDirectories="$(ConfigurationName),../../oggvorbis/lib,../../dx8sdk/lib,../../openal/libs/win32,../../openal/libs/win64" + EnableUAC="false" IgnoreDefaultLibraryNames="libc.lib,libcd.lib,libci.lib" ProgramDatabaseFile="$(TargetDir)$(TargetName).pdb" GenerateMapFile="true" @@ -309,10 +311,11 @@ <Tool Name="VCLinkerTool" AdditionalDependencies="DxErr8.lib d3d8.lib d3dx8.lib wsock32.lib winmm.lib msacm32.lib vfw32.lib comctl32.lib openal32.lib ogg_static.lib vorbis_static.lib vorbisfile_static.lib theora_static.lib code.lib" - OutputFile="$(OutDir)\fred2_open_3_6_9r_sse.exe" + OutputFile="$(OutDir)\fred2_open_3_6_10r_sse.exe" LinkIncremental="1" SuppressStartupBanner="true" AdditionalLibraryDirectories="$(ConfigurationName),../../oggvorbis/lib,../../dx8sdk/lib,../../openal/libs/win32,../../openal/libs/win64" + EnableUAC="false" IgnoreDefaultLibraryNames="libc.lib,libcd.lib,libci.lib" ProgramDatabaseFile="$(TargetDir)$(TargetName).pdb" GenerateMapFile="true" @@ -422,7 +425,7 @@ <Tool Name="VCLinkerTool" AdditionalDependencies="DxErr8.lib d3d8.lib d3dx8.lib wsock32.lib winmm.lib msacm32.lib vfw32.lib comctl32.lib openal32.lib ogg_static.lib vorbis_static.lib vorbisfile_static.lib theora_static.lib code.lib" - OutputFile="$(OutDir)\fred2_open_3_6_9r_sse2.exe" + OutputFile="$(OutDir)\fred2_open_3_6_10r_sse2.exe" LinkIncremental="1" SuppressStartupBanner="true" AdditionalLibraryDirectories="$(ConfigurationName),../../oggvorbis/lib,../../dx8sdk/lib,../../openal/libs/win32,../../openal/libs/win64" Index: Freespace2.vcproj =================================================================== --- Freespace2.vcproj (revision 4723) +++ Freespace2.vcproj (working copy) @@ -86,10 +86,11 @@ UseLibraryDependencyInputs="false" AdditionalDependencies="code.lib liblua_d.lib libjpeg_d.lib d3d8.lib d3dx8.lib DxErr8.lib odbc32.lib odbccp32.lib wsock32.lib winmm.lib vfw32.lib msacm32.lib comctl32.lib openal32.lib ogg_static.lib vorbis_static.lib vorbisfile_static.lib theora_static.lib ole32.lib advapi32.lib gdi32.lib user32.lib" ShowProgress="0" - OutputFile="$(OutDir)\fs2_open_3_6_9d.exe" + OutputFile="$(OutDir)\fs2_open_3_6_10d.exe" LinkIncremental="2" SuppressStartupBanner="true" AdditionalLibraryDirectories="$(ConfigurationName),../../oggvorbis/lib,../../dx8sdk/lib,../../openal/libs/win32,../../openal/libs/win64" + EnableUAC="false" IgnoreDefaultLibraryNames="libc.lib,libcd.lib,libcmt.lib,libci.lib" GenerateDebugInformation="true" ProgramDatabaseFile="$(TargetDir)$(TargetName).pdb" @@ -198,10 +199,11 @@ <Tool Name="VCLinkerTool" AdditionalDependencies="Dxerr8.lib d3d8.lib d3dx8.lib odbc32.lib odbccp32.lib wsock32.lib winmm.lib vfw32.lib msacm32.lib comctl32.lib openal32.lib ogg_static.lib vorbis_static.lib vorbisfile_static.lib theora_static.lib" - OutputFile="$(OutDir)\fs2_open_3_6_9r.exe" + OutputFile="$(OutDir)\fs2_open_3_6_10r.exe" LinkIncremental="1" SuppressStartupBanner="true" AdditionalLibraryDirectories="$(ConfigurationName),../../oggvorbis/lib,../../dx8sdk/lib,../../openal/libs/win32,../../openal/libs/win64" + EnableUAC="false" IgnoreDefaultLibraryNames="libc.lib,libcd.lib,libci.lib" GenerateDebugInformation="true" ProgramDatabaseFile="$(TargetDir)$(TargetName).pdb" @@ -313,10 +315,11 @@ <Tool Name="VCLinkerTool" AdditionalDependencies="Dxerr8.lib d3d8.lib d3dx8.lib odbc32.lib odbccp32.lib wsock32.lib winmm.lib vfw32.lib msacm32.lib comctl32.lib openal32.lib ogg_static.lib vorbis_static.lib vorbisfile_static.lib theora_static.lib" - OutputFile="$(OutDir)\fs2_open_3_6_9r_sse.exe" + OutputFile="$(OutDir)\fs2_open_3_6_10r_sse.exe" LinkIncremental="1" SuppressStartupBanner="true" AdditionalLibraryDirectories="$(ConfigurationName),../../oggvorbis/lib,../../dx8sdk/lib,../../openal/libs/win32,../../openal/libs/win64" + EnableUAC="false" IgnoreDefaultLibraryNames="libc.lib,libcd.lib,libci.lib" GenerateDebugInformation="true" ProgramDatabaseFile="$(TargetDir)$(TargetName).pdb" @@ -428,12 +431,11 @@ <Tool Name="VCLinkerTool" AdditionalDependencies="Dxerr8.lib d3d8.lib d3dx8.lib odbc32.lib odbccp32.lib wsock32.lib winmm.lib vfw32.lib msacm32.lib comctl32.lib openal32.lib ogg_static.lib vorbis_static.lib vorbisfile_static.lib theora_static.lib" - OutputFile="$(OutDir)\fs2_open_3_6_9r_sse2.exe" + OutputFile="$(OutDir)\fs2_open_3_6_10r_sse2.exe" LinkIncremental="1" SuppressStartupBanner="true" AdditionalLibraryDirectories="$(ConfigurationName),../../oggvorbis/lib,../../dx8sdk/lib,../../openal/libs/win32,../../openal/libs/win64" EnableUAC="false" - UACUIAccess="false" IgnoreDefaultLibraryNames="libc.lib,libcd.lib,libci.lib" GenerateDebugInformation="true" ProgramDatabaseFile="$(TargetDir)$(TargetName).pdb" |
|
|
Whoops, I knew it seemed too easy. Fixed again, i think. |
|
|
Can you let me know if the fix is ok so I can close this. (finally :)) |
|
|
Looked good this time, I guess you didn't want the update to the filenames though. Also, unrelated, the build doesn't default to building FRED with one of the configurations, I have that fixed in my personal project. I think it's debug, maybe release though. But this particular issue is fixed. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2008-04-29 22:05 | ARSPR | New Issue | |
| 2008-04-29 22:10 | ARSPR | Note Added: 0009269 | |
| 2008-05-07 18:45 | ARSPR | Note Added: 0009306 | |
| 2008-05-26 17:20 | ARSPR | Note Added: 0009348 | |
| 2008-05-26 20:22 | chief1983 | Note Added: 0009349 | |
| 2008-05-27 04:41 | chief1983 | Note Added: 0009350 | |
| 2008-05-30 04:12 | chief1983 | Note Added: 0009357 | |
| 2008-05-30 04:22 | chief1983 | Note Added: 0009358 | |
| 2008-06-20 03:37 | phreak | Note Added: 0009400 | |
| 2008-06-20 03:38 | phreak | Note Edited: 0009400 | |
| 2008-06-20 06:54 | taylor | Note Added: 0009401 | |
| 2008-06-20 08:55 | ARSPR | Note Added: 0009403 | |
| 2008-06-20 11:39 | phreak | Note Added: 0009405 | |
| 2008-06-20 14:24 | chief1983 | Note Added: 0009406 | |
| 2008-06-20 20:06 | phreak | Note Added: 0009411 | |
| 2008-06-20 21:46 | chief1983 | Note Added: 0009412 | |
| 2008-07-27 17:50 | ARSPR | Note Added: 0009510 | |
| 2008-07-27 20:19 | chief1983 | Note Added: 0009511 | |
| 2008-07-27 21:49 | phreak | Note Added: 0009512 | |
| 2008-07-28 01:32 | chief1983 | Note Added: 0009513 | |
| 2008-07-28 02:51 | phreak | Note Added: 0009514 | |
| 2008-07-28 02:51 | phreak | Status | new => assigned |
| 2008-07-28 02:51 | phreak | Assigned To | => phreak |
| 2008-07-28 21:26 | chief1983 | Note Added: 0009515 | |
| 2008-07-28 21:27 | chief1983 | File Added: VS2008_UAC_EXE_Fix.patch | |
| 2008-07-28 22:13 | phreak | Note Added: 0009516 | |
| 2008-07-30 03:47 | phreak | Note Added: 0009520 | |
| 2008-07-30 05:40 | chief1983 | Note Added: 0009521 | |
| 2008-07-30 21:44 | phreak | Status | assigned => resolved |
| 2008-07-30 21:44 | phreak | Resolution | open => fixed |
