0001488: swff_lib.cpp doesn't compile using newest Windows SDK and disregarding old SDK files.

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001488

FSSCP

---------

public

2007-09-02 16:34

2008-02-08 07:32

Reporter

KeldorKatarn

Assigned To

Backslash

Priority

normal

Severity

major

Reproducibility

always

Status

resolved

Resolution

fixed

Product Version

3.6.9

Target Version

Fixed in Version

3.6.10

Summary

0001488: swff_lib.cpp doesn't compile using newest Windows SDK and disregarding old SDK files.

Description

Visual Studio 2005 complains about non-constant case expressions in this file in the lines 2464-2469 and 2472-2476.
I am not using the include paths of the SDK that comes with VS 2005 but instead use the newest windows SDK. I suspect several HRESULT checks made in those expressions are probably deprecated and the lines should therefore be removed. Commenting out those lines seems to make the project compile without problems.

(This file seems to be generally very old and partly deprecated)

Additional Information

Here are the problematic lines in code:

case VFX_ERR_FILE_NOT_FOUND: strcpy(pszCodeString, "VFX_ERR_FILE_NOT_FOUND" ); break;
case VFX_ERR_FILE_CANNOT_OPEN: strcpy(pszCodeString, "VFX_ERR_FILE_CANNOT_OPEN" ); break;
case VFX_ERR_FILE_CANNOT_CLOSE: strcpy(pszCodeString, "VFX_ERR_FILE_CANNOT_CLOSE" ); break;
case VFX_ERR_FILE_CANNOT_READ: strcpy(pszCodeString, "VFX_ERR_FILE_CANNOT_READ" ); break;
case VFX_ERR_FILE_CANNOT_WRITE: strcpy(pszCodeString, "VFX_ERR_FILE_CANNOT_WRITE" ); break;
case VFX_ERR_FILE_CANNOT_SEEK: strcpy(pszCodeString, "VFX_ERR_FILE_CANNOT_SEEK" ); break;
case VFX_ERR_FILE_ACCESS_DENIED: strcpy(pszCodeString, "VFX_ERR_FILE_ACCESS_DENIED" ); break;
case VFX_ERR_FILE_SHARING_VIOLATION: strcpy(pszCodeString, "VFX_ERR_FILE_SHARING_VIOLATION" ); break;
case VFX_ERR_FILE_NETWORK_ERROR: strcpy(pszCodeString, "VFX_ERR_FILE_NETWORK_ERROR" ); break;
case VFX_ERR_FILE_TOO_MANY_OPEN_FILES: strcpy(pszCodeString, "VFX_ERR_FILE_TOO_MANY_OPEN_FILES" ); break;
case VFX_ERR_FILE_INVALID: strcpy(pszCodeString, "VFX_ERR_FILE_INVALID" ); break;

Tags

No tags attached.

Attached Files

swff_lib_cpp_fix_diff.txt (3,200 bytes) 2008-01-09 08:21

Index: swff_lib.cpp
===================================================================
RCS file: /home/fs2source/cvsroot/fs2_open/code/io/swff_lib.cpp,v
retrieving revision 2.9
diff -u -r2.9 swff_lib.cpp
--- swff_lib.cpp	26 Jan 2006 03:23:29 -0000	2.9
+++ swff_lib.cpp	9 Jan 2008 08:00:02 -0000
@@ -2461,19 +2461,19 @@
 		case SFERR_DRIVER_ERROR: strcpy(pszCodeString, "SFERR_DRIVER_ERROR" ); break;
 		case SFERR_NON_FF_DEVICE: strcpy(pszCodeString, "SFERR_NON_FF_DEVICE" ); break;
 		case SFERR_INVALID_HAL_OBJECT: strcpy(pszCodeString, "SFERR_INVALID_HAL_OBJECT" ); break;
-		case VFX_ERR_FILE_NOT_FOUND: strcpy(pszCodeString, "VFX_ERR_FILE_NOT_FOUND" ); break;
-		case VFX_ERR_FILE_CANNOT_OPEN: strcpy(pszCodeString, "VFX_ERR_FILE_CANNOT_OPEN" ); break;
-		case VFX_ERR_FILE_CANNOT_CLOSE: strcpy(pszCodeString, "VFX_ERR_FILE_CANNOT_CLOSE" ); break;
-		case VFX_ERR_FILE_CANNOT_READ: strcpy(pszCodeString, "VFX_ERR_FILE_CANNOT_READ" ); break;
-		case VFX_ERR_FILE_CANNOT_WRITE: strcpy(pszCodeString, "VFX_ERR_FILE_CANNOT_WRITE" ); break;
-		case VFX_ERR_FILE_CANNOT_SEEK: strcpy(pszCodeString, "VFX_ERR_FILE_CANNOT_SEEK" ); break;
+//		case VFX_ERR_FILE_NOT_FOUND: strcpy(pszCodeString, "VFX_ERR_FILE_NOT_FOUND" ); break;
+//		case VFX_ERR_FILE_CANNOT_OPEN: strcpy(pszCodeString, "VFX_ERR_FILE_CANNOT_OPEN" ); break;
+//		case VFX_ERR_FILE_CANNOT_CLOSE: strcpy(pszCodeString, "VFX_ERR_FILE_CANNOT_CLOSE" ); break;
+//		case VFX_ERR_FILE_CANNOT_READ: strcpy(pszCodeString, "VFX_ERR_FILE_CANNOT_READ" ); break;
+//		case VFX_ERR_FILE_CANNOT_WRITE: strcpy(pszCodeString, "VFX_ERR_FILE_CANNOT_WRITE" ); break;
+//		case VFX_ERR_FILE_CANNOT_SEEK: strcpy(pszCodeString, "VFX_ERR_FILE_CANNOT_SEEK" ); break;
 		case VFX_ERR_FILE_UNKNOWN_ERROR: strcpy(pszCodeString, "VFX_ERR_FILE_UNKNOWN_ERROR" ); break;
 		case VFX_ERR_FILE_BAD_FORMAT: strcpy(pszCodeString, "VFX_ERR_FILE_BAD_FORMAT" ); break;
-		case VFX_ERR_FILE_ACCESS_DENIED: strcpy(pszCodeString, "VFX_ERR_FILE_ACCESS_DENIED" ); break;
-		case VFX_ERR_FILE_SHARING_VIOLATION: strcpy(pszCodeString, "VFX_ERR_FILE_SHARING_VIOLATION" ); break;
-		case VFX_ERR_FILE_NETWORK_ERROR: strcpy(pszCodeString, "VFX_ERR_FILE_NETWORK_ERROR" ); break;
-		case VFX_ERR_FILE_TOO_MANY_OPEN_FILES: strcpy(pszCodeString, "VFX_ERR_FILE_TOO_MANY_OPEN_FILES" ); break;
-		case VFX_ERR_FILE_INVALID: strcpy(pszCodeString, "VFX_ERR_FILE_INVALID" ); break;
+//		case VFX_ERR_FILE_ACCESS_DENIED: strcpy(pszCodeString, "VFX_ERR_FILE_ACCESS_DENIED" ); break;
+//		case VFX_ERR_FILE_SHARING_VIOLATION: strcpy(pszCodeString, "VFX_ERR_FILE_SHARING_VIOLATION" ); break;
+//		case VFX_ERR_FILE_NETWORK_ERROR: strcpy(pszCodeString, "VFX_ERR_FILE_NETWORK_ERROR" ); break;
+//		case VFX_ERR_FILE_TOO_MANY_OPEN_FILES: strcpy(pszCodeString, "VFX_ERR_FILE_TOO_MANY_OPEN_FILES" ); break;
+//		case VFX_ERR_FILE_INVALID: strcpy(pszCodeString, "VFX_ERR_FILE_INVALID" ); break;
 		case VFX_ERR_FILE_END_OF_FILE: strcpy(pszCodeString, "VFX_ERR_FILE_END_OF_FILE" ); break;
 		case SWDEV_ERR_INVALID_ID : strcpy(pszCodeString, "SWDEV_ERR_INVALID_ID" ); break;
 		case SWDEV_ERR_INVALID_PARAM : strcpy(pszCodeString, "SWDEV_ERR_INVALID_PARAM" ); break;

swff_lib_cpp_fix_diff.txt (3,200 bytes) 2008-01-09 08:21

Relationships

Relationships

Notes
~0008483 ni1s (reporter) 2007-09-04 11:54	Isn't Force Feedback broken anyway?

~0008782 KeldorKatarn (reporter) 2008-01-05 18:46	Bump

~0008801 KeldorKatarn (reporter) 2008-01-09 08:21	Quick-fix attacked as diff file.

~0008851 Backslash (developer) 2008-02-08 07:32	Fixed. (Force feedback works on mine at least...)

Notes

Date Modified	Username	Field	Change
Issue History
2007-09-02 16:34	KeldorKatarn	New Issue
2007-09-04 11:54	ni1s	Note Added: 0008483
2008-01-05 18:46	KeldorKatarn	Note Added: 0008782
2008-01-09 08:21	KeldorKatarn	File Added: swff_lib_cpp_fix_diff.txt
2008-01-09 08:21	KeldorKatarn	Note Added: 0008801
2008-02-08 07:32	Backslash	Status	new => resolved
2008-02-08 07:32	Backslash	Fixed in Version	=> 3.6.10
2008-02-08 07:32	Backslash	Resolution	open => fixed
2008-02-08 07:32	Backslash	Assigned To	=> Backslash
2008-02-08 07:32	Backslash	Note Added: 0008851

Issue History