View Issue Details

IDProjectCategoryView StatusLast Update
0001006FSSCPFREDpublic2012-01-09 18:06
ReporterARSPR Assigned Totaylor  
PrioritynormalSeverityblockReproducibilityalways
Status resolvedResolutionfixed 
PlatformP4 2.8 HT - 1.5GB - 7800GSOSWindows XPOS VersionSP2
Product Version3.6.9 
Summary0001006: Selected event gets sticked after right-clicking
DescriptionIn Mission Event Editor, when you right click over an item to bring the contextual menu, if you select any action inside it or if you press Esc to close it, this item keeps marked even when you click over any other item.
Steps To ReproduceExample: I've used again Derelict "Playing Possum" Dl4-05.fs (you can find it in mantis 1004)

+ I've rigth-clicked over "Repair System" (the very first event).

+ Select "Edit data" or just press Esc.

+ Then left-click over any other event, for example the next one "Undock" which is chained to it.

+ You can see how even when "Undock" is the selected item (example: the Chained Tick is marked), "Repair System" keeps resalted. I upload a screenshot.
TagsNo tags attached.

Activities

2006-07-22 14:21

 

Event_Editor_Bug.jpg (21,453 bytes)   
Event_Editor_Bug.jpg (21,453 bytes)   

redmenace

2006-07-22 18:51

manager   ~0006285

Do you know when this was introduced?

ARSPR

2006-07-22 19:10

reporter   ~0006291

No I am a new FRED user.

(And I'm running on a 56Kb Internet connection because my ADSL is out. So I won't be able to download CVS versions to pinpoint it for a while).

Goober5000

2006-07-22 22:42

administrator   ~0006298

This has been around since retail. It's just one of FRED's many idiosyncracies.

redmenace

2006-07-22 23:17

manager   ~0006301

I am assigning this as a future feature.

Kazan

2006-08-01 13:08

developer   ~0006382

ignore as this will probably be fixed by wxFRED (is that even still being worked on?)

taylor

2006-09-13 07:15

administrator   ~0006617

Ok, found the reason for this, but I'm not quite sure why it's there in the first place so I don't want to remove it without someone agreeing with me. In sexp_tree.cpp, the right_clicked() function, there is a SelectDropItem() call. There is no call to let go of said item however, which is why it can't move on to something else.

Now, I don't know MFC worth a crap, but looking over the code I can't find a single reason for that call to be there. Simply commenting that line out makes the tree work as expected (though I didn't really give it that good of a test).

Anyone know if it's safe to get rid of that call in order to fix this bug?


(SelectDropItem() is the call to do mouse drag-and-drop. Drag-and-drop is already handled by specific functions for that purpose however and this call in particular doesn't appear to have affiliation with the actual drap-and-drop functionality.)

Goober5000

2006-09-13 12:14

administrator   ~0006618

Perhaps :V: meant to allow users to drag events around?

I say just remove it.

taylor

2006-09-13 16:12

administrator   ~0006619

Yeah, but you can't drap-and-drop while the context menu is there anyway. Events (parents, not the individual sexps) are already drag-and-drop, though this right-click issue might interfere with that working properly.

I'll just go ahead and remove it and we'll see if anyone has problems.

taylor

2006-09-13 16:15

administrator   ~0006620

Fixered.

Related Changesets

fs2open: fs2_open_3_6_9 r3563

2006-09-13 13:30

taylor


Ported: N/A

Details Diff
fix for Mantis bug 0001006
Affected Issues
0001006
mod - /branches/fs2_open_3_6_9/fs2_open/code/fred2/sexp_tree.cpp Diff File
mod - /trunk/fs2_open/code/fred2/sexp_tree.cpp Diff File

Issue History

Date Modified Username Field Change
2006-07-22 14:21 ARSPR New Issue
2006-07-22 14:21 ARSPR File Added: Event_Editor_Bug.jpg
2006-07-22 18:51 redmenace Note Added: 0006285
2006-07-22 19:10 ARSPR Note Added: 0006291
2006-07-22 22:42 Goober5000 Note Added: 0006298
2006-07-22 23:17 redmenace Note Added: 0006301
2006-07-22 23:17 redmenace Assigned To => FSO 4
2006-07-22 23:17 redmenace Severity minor => block
2006-07-22 23:17 redmenace Status new => assigned
2006-08-01 13:08 Kazan Note Added: 0006382
2006-09-13 07:15 taylor Note Added: 0006617
2006-09-13 09:09 taylor Assigned To FSO 4 => taylor
2006-09-13 12:14 Goober5000 Note Added: 0006618
2006-09-13 16:12 taylor Note Added: 0006619
2006-09-13 16:15 taylor Status assigned => resolved
2006-09-13 16:15 taylor Resolution open => fixed
2006-09-13 16:15 taylor Note Added: 0006620
2012-01-05 22:55 taylor Changeset attached => Import 2012-01-05 17:52:05 fs2_open_3_6_9 r3563
2012-01-09 18:06 taylor Changeset attached => fs2open_websvn fs2_open_3_6_9 r3563