View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002783 | FSSCP | multiplayer | public | 2013-01-30 07:19 | 2013-01-30 07:39 |
| Reporter | Goober5000 | Assigned To | Goober5000 | ||
| Priority | normal | Severity | crash | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Summary | 0002783: Multiplayer respawn code can't keep its ship classes straight | ||||
| Description | Copied from 0002326... For some reason, client parse objects already have the correct ship class of the ship they're respawning into. That seems to be causing trouble with change_ship_type, although upon reflection it really shouldn't. Nevertheless, skipping the ship class change seems to fix it. (Strangely, server parse objects retain their parsed ship class as expected.) EDIT: For posterity, the problem in change_ship_type is most likely due to the parse object's ship_class being assigned to the new class, while its ship_max_hull_strength (and ship_max_shield_strength, and who knows what else) stayed at the original, parsed values. | ||||
| Tags | No tags attached. | ||||
|
|
And thanks to a variable breakpoint, the culprit appears to be line 714 in multiutil.cpp. Guessing this is an old bug from way back when multiplayer was first being developed. EDIT: Net_players[net_player].p_info.p_objp->ship_class = ship_class; // be sure this gets set so respawns work |
|
|
Fix committed to trunk@9516. |
|
|
For reference, I confirmed this fix by locally reverting the fix for 0002326 and then confirming that the crash no longer occurred. |
|
fs2open: trunk r9515 2013-01-30 01:56 Ported: N/A Details Diff |
this ought to fix Mantis 0002326 |
Affected Issues 0002326, 0002783 |
|
| mod - /trunk/fs2_open/code/ship/ship.cpp | Diff File | ||
|
fs2open: trunk r9516 2013-01-30 03:08 Ported: N/A Details Diff |
no, silly Volition programmer, that's handled elsewhere (fix Mantis 0002783) |
Affected Issues 0002783 |
|
| mod - /trunk/fs2_open/code/network/multiutil.cpp | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2013-01-30 07:19 | Goober5000 | New Issue | |
| 2013-01-30 07:19 | Goober5000 | Status | new => assigned |
| 2013-01-30 07:19 | Goober5000 | Assigned To | => Goober5000 |
| 2013-01-30 07:19 | Goober5000 | Relationship added | related to 0002326 |
| 2013-01-30 07:20 | Goober5000 | Note Added: 0014672 | |
| 2013-01-30 07:20 | Goober5000 | Note Edited: 0014672 | |
| 2013-01-30 07:23 | Goober5000 | Changeset attached | => fs2open trunk r9515 |
| 2013-01-30 07:32 | Goober5000 | Changeset attached | => fs2open trunk r9516 |
| 2013-01-30 07:32 | Goober5000 | Note Added: 0014673 | |
| 2013-01-30 07:32 | Goober5000 | Status | assigned => resolved |
| 2013-01-30 07:32 | Goober5000 | Resolution | open => fixed |
| 2013-01-30 07:39 | Goober5000 | Note Added: 0014674 |
