2021-03-06 23:45 EST


View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0002895FSSCPBuild systempublic2020-04-13 15:19
ReporterFirewave 
Assigned Tochief1983 
PrioritynormalSeverityminorReproducibilityN/A
StatusresolvedResolutionfixed 
Product Version3.7.0 RC2 
Target VersionFixed in Version 
Summary0002895: clang compiler warnings
DescriptionThese are the remaining clang 3.3 compiler warning with 3.7.0 RC2 after applying the patch submitted in issue 2894:

cfile/cfilesystem.cpp: In function ‘void cf_search_root_pack(int)’:
cfile/cfilesystem.cpp:673:45: warning: ignoring return value of ‘size_t fread(void*, size_t, size_t, FILE*)’, declared with attribute warn_unused_result [-Wunused-result]
cfile/cfilesystem.cpp:693:41: warning: ignoring return value of ‘size_t fread(void*, size_t, size_t, FILE*)’, declared with attribute warn_unused_result [-Wunused-result]
cmdline/cmdline.cpp: In function ‘void os_init_cmdline(char*)’:
cmdline/cmdline.cpp:785:24: warning: ignoring return value of ‘char* fgets(char*, int, FILE*)’, declared with attribute warn_unused_result [-Wunused-result]
cmdline/cmdline.cpp:823:24: warning: ignoring return value of ‘char* fgets(char*, int, FILE*)’, declared with attribute warn_unused_result [-Wunused-result]
globalincs/version.cpp: In function ‘int version_compare(char*, int*, int*, int*, int*, int*, int*)’:
globalincs/version.cpp:59:36: warning: ignoring return value of ‘char* fgets(char*, int, FILE*)’, declared with attribute warn_unused_result [-Wunused-result]
graphics/gropengldraw.cpp: In function ‘void opengl_scene_texture_shutdown()’:
graphics/gropengldraw.cpp:2370:26: warning: the address of ‘Distortion_texture’ will always evaluate as ‘true’ [-Waddress]
graphics/gropengltnl.cpp: In function ‘void gr_opengl_render_stream_buffer(int, int, int)’:
graphics/gropengltnl.cpp:1323:6: warning: variable ‘zbuff’ set but not used [-Wunused-but-set-variable]
hud/hud.cpp: In member function ‘virtual void HudGaugeTextWarnings::render(float)’:
hud/hud.cpp:2390:51: warning: the address of ‘Hud_text_flash’ will always evaluate as ‘true’ [-Waddress]
hud/hudparse.cpp: In function ‘void load_gauge_primary_weapons(int, int, int, SCP_vector<int>*, color*)’:
hud/hudparse.cpp:8326:57: warning: ‘base_res[1]’ may be used uninitialized in this function [-Wmaybe-uninitialized]
hud/hudparse.cpp:8326:57: warning: ‘base_res[0]’ may be used uninitialized in this function [-Wmaybe-uninitialized]
hud/hudparse.cpp: In function ‘void load_gauge_secondary_weapons(int, int, int, SCP_vector<int>*, color*)’:
hud/hudparse.cpp:8519:57: warning: ‘base_res[1]’ may be used uninitialized in this function [-Wmaybe-uninitialized]
hud/hudparse.cpp:8519:57: warning: ‘base_res[0]’ may be used uninitialized in this function [-Wmaybe-uninitialized]
io/keycontrol.cpp: In function ‘void ppsk_hotkeys(int)’:
io/keycontrol.cpp:1289:61: warning: suggest parentheses around ‘+’ in operand of ‘&’ [-Wparentheses]
model/modelread.cpp: In function ‘int model_load(char*, int, model_subsystem*, int, int)’:
model/modelread.cpp:2495:2: warning: assuming signed overflow does not occur when assuming that (X + c) < X is always false [-Wstrict-overflow]
network/multiutil.cpp: In function ‘void dcf_multi()’:
network/multiutil.cpp:3240:8: warning: variable ‘new_flags’ set but not used [-Wunused-but-set-variable]
network/multi_team.cpp: In function ‘void multi_team_report()’:
network/multi_team.cpp:591:73: warning: array subscript is above array bounds [-Warray-bounds]
parse/parselo.cpp: In function ‘void vsprintf(SCP_string&, const char*, __va_list_tag*)’:
parse/parselo.cpp:3690:20: warning: ‘char’ is promoted to ‘int’ when passed through ‘...’ [enabled by default]
parse/parselo.cpp:3690:20: note: (so you should pass ‘int’ not ‘char’ to ‘va_arg’)
parse/parselo.cpp:3690:20: note: if this code is reached, the program will abort
weapon/weapons.cpp: In function ‘int weapon_create(vec3d*, matrix*, int, int, int, int, int, float, ship_subsys*)’:
weapon/weapons.cpp:4943:70: warning: operation on ‘* position’ may be undefined [-Wsequence-point]
TagsNo tags attached.
Attached Files

-Relationships
related to 0002894resolvedchief1983 Compiler warning fixes for clang 
+Relationships

-Notes

~0016973

Goober5000 (administrator)

Marking this as resolved for the same reason as 0002894.
+Notes

-Issue History
Date Modified Username Field Change
2013-06-29 08:37 Firewave New Issue
2013-06-29 08:37 Firewave Status new => assigned
2013-06-29 08:37 Firewave Assigned To => chief1983
2020-04-13 15:19 Goober5000 Relationship added related to 0002894
2020-04-13 15:19 Goober5000 Status assigned => resolved
2020-04-13 15:19 Goober5000 Resolution open => fixed
2020-04-13 15:19 Goober5000 Note Added: 0016973
+Issue History