View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002368 | FSSCP | gameplay | public | 2011-01-04 00:10 | 2011-01-07 22:04 |
| Reporter | FUBAR-BDHR | Assigned To | FUBAR-BDHR | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 3.6.13 | ||||
| Fixed in Version | 3.6.13 | ||||
| Summary | 0002368: Subsystems with vanish flag still play sound from player ship | ||||
| Description | That's basically the issue. Should have fix attached in few minutes. | ||||
| Tags | No tags attached. | ||||
|
2011-01-04 00:18
|
mantis_2368.patch (622 bytes)
Index: ship/shiphit.cpp
===================================================================
--- ship/shiphit.cpp (revision 6920)
+++ ship/shiphit.cpp (working copy)
@@ -221,7 +221,8 @@
// Don't log or display info about the activation subsytem
int display = (psub->type != SUBSYSTEM_ACTIVATION);
- if (display) {
+ if (display && !(subsys->flags & SSF_VANISHED)) // Don't display or play sound if is' supposed to vanish.
+ {
mission_log_add_entry(LOG_SHIP_SUBSYS_DESTROYED, ship_p->ship_name, psub->subobj_name, log_index );
if ( ship_obj == Player_obj ) {
snd_play( &Snds[SND_SUBSYS_DIE_1], 0.0f );
|
|
2011-01-04 00:19
|
|
|
|
Patch attached and test mission uploaded. Mission is from Diaspora but the events should work on any ship class so it getting converted to a Uly shouldn't be an issue. |
|
|
Fixed in r6930 |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2011-01-04 00:10 | FUBAR-BDHR | New Issue | |
| 2011-01-04 00:10 | FUBAR-BDHR | Status | new => assigned |
| 2011-01-04 00:10 | FUBAR-BDHR | Assigned To | => FUBAR-BDHR |
| 2011-01-04 00:18 | FUBAR-BDHR | File Added: mantis_2368.patch | |
| 2011-01-04 00:19 | FUBAR-BDHR | File Added: 0.fs2 | |
| 2011-01-04 00:21 | FUBAR-BDHR | Note Added: 0012586 | |
| 2011-01-07 22:04 | FUBAR-BDHR | Note Added: 0012590 | |
| 2011-01-07 22:04 | FUBAR-BDHR | Status | assigned => resolved |
| 2011-01-07 22:04 | FUBAR-BDHR | Fixed in Version | => 3.6.13 |
| 2011-01-07 22:04 | FUBAR-BDHR | Resolution | open => fixed |
