2018-11-13 12:46 EST


View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0001843FSSCPuser interfacepublic2008-12-14 11:04
ReporterJoshua 
Assigned Tophreak 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusresolvedResolutionopen 
Product Version3.6.9 
Target VersionFixed in Version 
Summary0001843: MIssion skipping sorta screwed.
DescriptionI failed "Slaying Ravana" 10 times (My first time on Hard), and eventually managed to get it right. However, during my mission fail spree, the message box that said "You have failed this mission 5 times, do you want to skip it?" showed up. I clicked "do not show this again".

Then, on the next mission, I was shotdown by the Hawkwood. Then, the "You have failed this mission 5 times, do you want to skip?" showed up, although, as you can see, have only failed the mission once.
Additional InformationI am using the Nightly build from 6 december
TagsNo tags attached.
Attached Files
  • diff file icon potential-fix-mantis-1843.diff (518 bytes) 2008-12-14 02:51 -
    Index: code/mission/missioncampaign.cpp
    ===================================================================
    --- code/mission/missioncampaign.cpp	(revision 4994)
    +++ code/mission/missioncampaign.cpp	(working copy)
    @@ -2444,6 +2444,7 @@
     
     	// Goober5000 - player-persistent variables are handled when the mission is
     	// over, not necessarily when the mission is accepted
    +	Player->failures_this_session = 0;
     
     	// DKA 12/11/98 - Unneeded already evaluated and stored
     	// determine what new mission we are moving to.
    
    diff file icon potential-fix-mantis-1843.diff (518 bytes) 2008-12-14 02:51 +

-Relationships
related to 0001849resolvedphreak Actually 3.6.10, but the option isn't there yet. Whenever I pass a mission, it says I have failed the mission five times. 
+Relationships

-Notes

~0010409

Echelon9 (developer)

See attached (potential-fix-mantis-1843.diff) for a proposed patch against r4994 trunk.

It adds into mission_campaign_mission_over() in missioncampaign.cpp the line "Player->failures_this_session = 0;" to ensure that Player->failures_this_session equals 0 at the start of a new mission.

Currently, my reading of the code would be that FS2_Open only resets the Player->failures_this_session to be 0 if the user chooses to skip the mission, but not if the offer is declined and the user subsequently passes the mission.

I wasn't able to reproduce this actual bug given my limited time, so consider this a very early prospective solution. I'd appreciate testing from those that can rebuild a nightly trunk build with the attached diff.

~0010411

phreak (developer)

looks like it will work, committed.

~0010413

Joshua (reporter)

Last edited: 2008-12-14 07:08

I managed to repeat the scenario with Love The Treason... ... But hate the traitor. (I was using the same build as before, have not tried the fix yet. It is not really something one would wish to test)

~0010414

Echelon9 (developer)

Joshua, was that repro with Love the Treason... using a newer post r4995 build?

If so, I'll have to look into the proposed patch again.

~0010415

Joshua (reporter)

Negative, it was with an older build (the 6 december one). I had not reproduced the bug yet, so I posted that note there to say I now have.

I'll test the bugfix as soon as the new windows nightly comes out.

~0010416

Echelon9 (developer)

Ok, thanks for the update. I'll be looking forward to hearing how it goes (unfortunately, it can be a rather time intensive bug to reproduce repeatedly on different platforms as I'm sure you've experienced)

~0010417

Joshua (reporter)

Last edited: 2008-12-14 09:14

The problem does no longer seem to occure. Nice job.

+Notes

-Issue History
Date Modified Username Field Change
2008-12-10 14:54 Joshua New Issue
2008-12-14 02:51 Echelon9 Note Added: 0010409
2008-12-14 02:51 Echelon9 File Added: potential-fix-mantis-1843.diff
2008-12-14 03:07 phreak Note Added: 0010411
2008-12-14 06:27 Joshua Note Added: 0010413
2008-12-14 07:07 Echelon9 Note Added: 0010414
2008-12-14 07:08 Joshua Note Edited: 0010413
2008-12-14 07:12 Joshua Note Added: 0010415
2008-12-14 07:16 Echelon9 Note Added: 0010416
2008-12-14 09:04 Joshua Note Added: 0010417
2008-12-14 09:14 Joshua Note Edited: 0010417
2008-12-14 11:04 phreak Assigned To => phreak
2008-12-14 11:04 phreak Status new => resolved
2008-12-20 11:59 phreak Relationship added related to 0001849
+Issue History