View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0000930 | FSSCP | gameplay | public | 2006-06-01 06:05 | 2023-11-01 04:05 |
Reporter | Goober5000 | Assigned To | MageKing17 | ||
Priority | normal | Severity | minor | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Target Version | 3.8 | Fixed in Version | 3.8 | ||
Summary | 0000930: Weird event bug in the FS2 demo campaign | ||||
Description | This assert happens in the first mission immediately after the first wave of Libra is destroyed. Reproducible on every playthrough. The event referred to in the array is Destroy Libra. Assert: Mission_events[*e2 & 0xffff].born_on_date != 0 File: E:\Languages\Visual Studio Projects\Visual C++\fs2_open\code\Mission\MissionTraining.cpp Line: 697 [This filename points to the location of a file on the computer that built this executable] Call stack: ------------------------------------------------------------------ insertion_sort() sort_training_objectives() training_check_objectives() game_simulation_frame() game_frame() game_do_frame() game_do_state() gameseq_process_events() game_main() WinMain() WinMainCRTStartup() KERNEL32.DLL bff8b560() KERNEL32.DLL bff8b412() KERNEL32.DLL bff89dd5() ------------------------------------------------------------------ | ||||
Steps To Reproduce | Demo campaign can be downloaded from this thread. http://www.hard-light.net/forums/index.php/topic,36960.0.html | ||||
Tags | No tags attached. | ||||
|
Libra being destroyed is considered a special event. Special events don't appear to get a timestamp() for born_on_date (in missiongoals.cpp, mission_get_event_status()). I'm not really into the mission design aspect of this thing, but from the mission it looks like Virgo wing has an arrival que with is-destroyed-delay for only 3 of the 4 ships from Libra wing. This would give it a partial true (I think) and then be considered a special event. You know that stuff a lot better than I do though so I'll leave the rest to you to figure out. ;) |
|
* BUMP * ... umm, just because it should be bumped, I guess ... |
|
LOL. :) Yeah, not really sure what to do here. Also, it's low on the priority list. |
|
Closing: 1) Very old (almost 3 years now!) 2) Demo??? 3) There are |<---->| <- that many changes since then |
|
Reopening since MageKing17 has independently discovered, and made progress on, the same issue. |
|
It's also not limited to the demo; any similarly-constructed event would have the same issue (of course, it's such a strange way to make an event that I'm not surprised nobody's complained about this assertion outside the demo). Since it works just fine in Release builds, and I can see no inherent reason to prohibit sorting just because born_on_date is 0, just removing the assertions would seem to be the simplest solution; that's what will be in the PR I'll be submitting soonish to fix this and other demo-related issues. |
|
And here's the PR: https://github.com/scp-fs2open/fs2open.github.com/pull/1156 |
|
The PR was merged; this assertion is a thing of the past. |
|
I finally discovered that the *actual* cause of this bug is that born_on_date is never initialized when the event is parsed. An upcoming PR will fix this. |
|
Actually, I take that back. It is initialized, just not in the place I thought it would be. Carry on. |
|
And finally, I think I've nailed the actual *actual* cause of this bug. See Github 5747: https://github.com/scp-fs2open/fs2open.github.com/pull/5747 |
Date Modified | Username | Field | Change |
---|---|---|---|
2006-06-01 06:05 | Goober5000 | New Issue | |
2006-06-01 06:06 | Goober5000 | Description Updated | |
2006-06-01 08:36 | taylor | Note Added: 0005684 | |
2006-07-16 00:17 | taylor | Note Added: 0006194 | |
2006-07-16 00:36 | Goober5000 | Note Added: 0006195 | |
2009-06-07 15:29 | portej05 | Status | new => closed |
2009-06-07 15:29 | portej05 | Note Added: 0010958 | |
2009-06-07 15:29 | portej05 | Resolution | open => no change required |
2017-01-23 04:48 | Goober5000 | Assigned To | => MageKing17 |
2017-01-23 04:48 | Goober5000 | Status | closed => assigned |
2017-01-23 04:48 | Goober5000 | Note Added: 0016852 | |
2017-01-23 04:56 | MageKing17 | Note Added: 0016853 | |
2017-01-24 20:53 | MageKing17 | Status | assigned => code review |
2017-01-24 20:53 | MageKing17 | Note Added: 0016855 | |
2017-02-03 22:47 | MageKing17 | Status | code review => resolved |
2017-02-03 22:47 | MageKing17 | Resolution | no change required => fixed |
2017-02-03 22:47 | MageKing17 | Fixed in Version | => 3.8 |
2017-02-03 22:47 | MageKing17 | Target Version | => 3.8 |
2017-02-03 22:47 | MageKing17 | Note Added: 0016858 | |
2020-04-14 00:46 | Goober5000 | Status | resolved => assigned |
2020-04-14 00:46 | Goober5000 | Resolution | fixed => reopened |
2020-04-14 00:46 | Goober5000 | Note Added: 0016976 | |
2020-04-14 03:11 | Goober5000 | Status | assigned => resolved |
2020-04-14 03:11 | Goober5000 | Resolution | reopened => fixed |
2020-04-14 03:11 | Goober5000 | Note Added: 0016977 | |
2023-11-01 04:05 | Goober5000 | Note Added: 0017151 |