View Issue Details

IDProjectCategoryView StatusLast Update
0000990FSSCPmultiplayerpublic2011-06-24 21:36
Reporterkarajorma Assigned Tokarajorma  
PrioritynormalSeveritycrashReproducibilityalways
Status closedResolutionfixed 
PlatformWindowsOSWindows XP HomeOS VersionSP2
Summary0000990: Pressing F2 causes crash in multiplayer
DescriptionAny attempt to get into the options screen using latest CVS crashes the game.

Debug builds report this

Assert: (pos >= 0) && (pos <= num_pos)
File: D:\C++\Freespace\fs2_open 3.6.9\code\UI\slider.cpp
Line: 193
[This filename points to the location of a file on the computer that built this executable]

Call stack:
------------------------------------------------------------------
    draw() options_menu_do_frame() game_do_state() gameseq_process_events() game_main() WinMain() WinMainCRTStartup() kernel32.dll 7c816d4f()
------------------------------------------------------------------

When running in the debugger num_pos = 5 but pos = 114 (hence the assertion).

Doesn't matter whether the 3.6.9 or main branch is used.
TagsNo tags attached.

Activities

taylor

2006-07-15 17:18

administrator   ~0006174

Does making a new pilot help any?

karajorma

2006-07-15 17:23

administrator   ~0006176

Nope. First thing I tried. Forgot to mention it though :)

taylor

2006-07-15 17:35

administrator   ~0006177

Hmm, I've gotten this before, but only because of pilot file corruption. And it's working fine for me with current 3_6_9 CVS so I kinda doubt it's a basic code problem.

The only slider with 5 positions on the primary options screen is the skill slider. The skill slider is set via the Game_skill_leval variable, which is read from the pilot file, but initialized with DEFAULT_SKILL_LEVEL/game_get_default_skill_level(). Check managepilot.cpp, both where it's initialize and where it's read out of the pilot file to see if one of those places is setting it to something high like that.

karajorma

2006-07-15 17:51

administrator   ~0006178

Hmmmm looks like it was pilot file corruption after all. Deleting all the pilot files and then creating completely new ones seems to have worked. No idea why it didn't the first time. Might be cause I created the new pilot in the barracks rather than from the main logon screen cause I was a little hasty and clicked commit to quickly on startup.

What's really odd is that this appeared after a crash and my pilot files on both PCs were corrupted in the exact same way.

karajorma

2006-07-19 13:57

administrator   ~0006223

Hmmm. Unless this particular incidence of pilot corruption can be repeated I think we can probably chalk this one down as a one off.

Goober5000

2006-07-20 00:30

administrator   ~0006243

Shouldn't that be (pos < num_pos)?

taylor

2006-07-20 02:29

administrator   ~0006254

Actually I think that "pos" is a special case, and could actually be equal to num_pos. There is a special offset so that you can have a zero without a frame for it. Then have 1 to num_pos with bitmaps.

That may be more of a hold-over from the FS1 days, but I'd probably advise against changing it until every single control/screen was tested to not hit that assert before actually making the change in CVS.

taylor

2006-07-24 19:06

administrator   ~0006328

Thought that karajorma was going to do this, but oh well...


Closered.

Goober5000

2009-03-10 06:54

administrator   ~0010722

Reassigning to karajorma. :D Happened tonight while playing a FSPort multi game as a client.

Zacam

2011-06-23 00:13

administrator   ~0012724

Last edited: 2011-06-24 21:35

Unable to reproduce F2 during any state (other than during death/respawn) causing a crash.

Edit during PXO and SA testing, neither Host nor Client was able to cause a crash by using F2 at any point other than when during death.

Closing issue as 0002377 is much more accurately descriptive an issue.

Issue History

Date Modified Username Field Change
2006-07-15 17:02 karajorma New Issue
2006-07-15 17:18 taylor Note Added: 0006174
2006-07-15 17:23 karajorma Note Added: 0006176
2006-07-15 17:35 taylor Note Added: 0006177
2006-07-15 17:51 karajorma Note Added: 0006178
2006-07-19 13:57 karajorma Note Added: 0006223
2006-07-20 00:30 Goober5000 Note Added: 0006243
2006-07-20 02:29 taylor Note Added: 0006254
2006-07-24 19:06 taylor Status new => closed
2006-07-24 19:06 taylor Note Added: 0006328
2009-03-10 06:53 Goober5000 Status closed => assigned
2009-03-10 06:53 Goober5000 Assigned To => karajorma
2009-03-10 06:54 Goober5000 Note Added: 0010722
2009-03-10 06:54 Goober5000 Status assigned => confirmed
2011-06-23 00:13 Zacam Note Added: 0012724
2011-06-23 19:34 Zacam Category --------- => multiplayer
2011-06-24 21:35 Zacam Note Edited: 0012724
2011-06-24 21:36 Zacam Status confirmed => closed
2011-06-24 21:36 Zacam Resolution open => fixed