View Issue Details

IDProjectCategoryView StatusLast Update
0000890FSSCPgameplaypublic2006-05-13 06:44
Reporterpahis Assigned Totaylor  
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Summary0000890: Wingmen no longer praise player after kills
DescriptionI have noticed that the wingmen no longer send messages after you kill enemies. I mean the messages such as "Good kill!" or "That is a confirmed kill!" that appear sometimes after player manages to destroy enemy fighter/bomber. All other messages will come such ass dying wingmen, enemies arriving or wingmen calling for support. This problem is not crucial but annoying.
Additional InformationThis begun when I switched to build 3.6.8 (fs2_open_r-20060323.exe) and optimized 3.6.8 (fs2_open_r-P420060323.exe). Now I use 20060412-fs2_open_r.exe. But when I used build 3.6.7 (fs2_open_367.exe) the messages did come.

Here are the used flags:
H:\Pelit\Freespace2\20060412-fs2_open_r.exe -mod mediavps -spec -glow -jpgtga -mipmap -nomotiondebris -2d_poof -cache_bitmaps -missile_lighting -3dwarp -warp_flash -snd_preload

Audio mode is DirectSound and the video mode is OpenGL.
TagsNo tags attached.

Activities

pahis

2006-04-20 23:45

reporter   ~0005349

Last edited: 2006-04-21 18:45

Update: messages seem to work with sentry guns and cargo containers.
Update: switched to a new CVS build (20060421-fs2_open_r.exe). Problems still exists.

edited on: 04-21-06 14:45

edited on: 04-21-06 14:45

ARSPR

2006-04-22 06:38

reporter   ~0005373

Last edited: 2006-04-22 06:40

Well, while you fix it and if it is easy, can you code a Launcher Flag to DISABLE them?

I haven't noticed this bug till you have appointed it, but I DO PREFER actual behaviour not having all this useless and stupid ingame speech.

edited on: 04-22-06 02:40

pahis

2006-04-27 18:16

reporter   ~0005406

I again switched to another CVS (fs2_open_r_20060425_Kara.exe). Problem still exists.

Backslash

2006-04-28 04:14

developer   ~0005408

Funny thing is messages AREN'T supposed to work with sentry guns and cargo containers. At least according to the comments.

But you're right. Come to think of it, I haven't heard the "Check your 6" message in a while either.

And I agree ARSPR -- once fixed, it would be nice to have this optional. That and Command's incessant "Incoming jump signature!". Maybe I'll lump those into one command line switch.

From 3.6.7 (September 2005) to March of this year is quite a big jump -- hard to track down what exactly changed, but I think I've narrowed it down to revision 2.288 of ship.cpp ...
http://fs2source.warpcore.org/cgi-bin/cvsweb/cvsweb.cgi/fs2_open/code/ship/ship.cpp

taylor

2006-04-28 06:07

administrator   ~0005413

Good catch Backslash, the message_bools check needs to be inverted. It's currently returning if the ship CAN praise, not if it can't. The quick addition of a "!" should fix it.

taylor

2006-05-11 22:59

administrator   ~0005499

Well, since no one else has made such an easy fix I guess it's left up to me. :)

This fix will go in with my big commit this weekend.

taylor

2006-05-13 06:44

administrator   ~0005506

Fixered.

Issue History

Date Modified Username Field Change
2006-04-20 20:56 pahis New Issue
2006-04-20 22:25 Goober5000 Status new => assigned
2006-04-20 22:25 Goober5000 Assigned To => Goober5000
2006-04-20 23:45 pahis Note Added: 0005349
2006-04-21 18:45 pahis Note Edited: 0005349
2006-04-21 18:45 pahis Note Edited: 0005349
2006-04-22 06:38 ARSPR Note Added: 0005373
2006-04-22 06:40 ARSPR Note Edited: 0005373
2006-04-27 18:16 pahis Note Added: 0005406
2006-04-28 04:14 Backslash Note Added: 0005408
2006-04-28 06:07 taylor Note Added: 0005413
2006-05-11 22:59 taylor Note Added: 0005499
2006-05-11 22:59 taylor Assigned To Goober5000 => taylor
2006-05-13 06:44 taylor Status assigned => resolved
2006-05-13 06:44 taylor Resolution open => fixed
2006-05-13 06:44 taylor Note Added: 0005506