View Issue Details

IDProjectCategoryView StatusLast Update
0000868FSSCPgameplaypublic2006-03-19 04:10
ReporterGoober5000 Assigned Totaylor  
PrioritynormalSeverityfeatureReproducibilityalways
Status resolvedResolutionfixed 
Summary0000868: Cargo scans on capships don't show up later
DescriptionScan a capital ship subsystem that contains cargo. When the cargo is revealed, it will be printed on the HUD. Later on, when you target the subsystem again, it will only display the first letter of the cargo. There are similar problems displaying it in the mission log as well.
TagsNo tags attached.

Activities

taylor

2006-03-18 21:47

administrator   ~0005176

This seems to work fine for me. I gave the code a quick look and I don't see any reason that it would mess up. Cargo_names[] is just a ptr to the actual name in another array though so it is possible to only get the first letter if the code is wrong. I don't see such a problem area in CVS though. I could just be missing it of course.

2006-03-18 22:13

 

scanned.jpg (76,915 bytes)   
scanned.jpg (76,915 bytes)   

2006-03-18 22:13

 

log.jpg (47,278 bytes)   
log.jpg (47,278 bytes)   

2006-03-18 22:13

 

retargeted.jpg (97,782 bytes)   
retargeted.jpg (97,782 bytes)   

Goober5000

2006-03-18 22:14

administrator   ~0005177

Last edited: 2006-03-18 22:15

Well, see for yourself (screenshots attached). :) This is in sm2-08. I scanned the navigation subsystem and it looks fine on the HUD when you first scan it. I switched to the mission log and it's split onto two lines there. Then I switch back to the mission and the "ed" is missing off the end.

edited on: 03-18-06 17:15

taylor

2006-03-18 23:55

administrator   ~0005178

Ahhh, I see it now. I never went to the event portion of the log, just the mission log in general. The event log function to add text modifies the ptr passed, in this case the original cargo name. That's wrong obviously so I just copied the cargo string to the text[] char array in the log display function and that fixed it up.

I'll commit the fix in a little bit.

taylor

2006-03-19 00:50

administrator   ~0005179

Crap, found another bug during testing. Trying to scan the comm subsystem and going to the event log will Assert() in gr_force_fit_string(). I'll need to work that out before making the commit.

taylor

2006-03-19 03:30

administrator   ~0005181

Ok, think that's fixed now. The basic problem was that split_str_once() will produce a split in the middle of a word which gave you the one line with just a "D" on it. If the first split of the word is too long to fit in the required pixel space then you get the Assert() in the font code. The fix (so far) is to make sure split_str_once() doesn't split the middle of a word and then the word in the mission log will show up in it's entirety on the new line.

I've only seen this problem with the mission log so far, but it could show up anywhere that split_str_once() is used. I'm going to test more before getting this in CVS, just in case.

taylor

2006-03-19 04:10

administrator   ~0005182

Seems to pass everything, so it's now in CVS. :)

taylor

2006-03-19 04:10

administrator   ~0005183

Fixered.

Issue History

Date Modified Username Field Change
2006-03-18 20:07 Goober5000 New Issue
2006-03-18 21:47 taylor Note Added: 0005176
2006-03-18 22:13 Goober5000 File Added: scanned.jpg
2006-03-18 22:13 Goober5000 File Added: log.jpg
2006-03-18 22:13 Goober5000 File Added: retargeted.jpg
2006-03-18 22:14 Goober5000 Note Added: 0005177
2006-03-18 22:15 Goober5000 Note Edited: 0005177
2006-03-18 23:55 taylor Note Added: 0005178
2006-03-18 23:55 taylor Status new => assigned
2006-03-18 23:55 taylor Assigned To => taylor
2006-03-19 00:50 taylor Note Added: 0005179
2006-03-19 03:30 taylor Note Added: 0005181
2006-03-19 04:10 taylor Note Added: 0005182
2006-03-19 04:10 taylor Status assigned => resolved
2006-03-19 04:10 taylor Resolution open => fixed
2006-03-19 04:10 taylor Note Added: 0005183